From 4e37b0bab041b72f3d40cb161f9a60f78e289d69 Mon Sep 17 00:00:00 2001
From: "Lucas Perais (lpe)" <lpe@odoo.com>
Date: Tue, 22 Jun 2021 14:57:46 +0000
Subject: [PATCH] [FIX] web: navbar: do not change url hash on item clicked

Before this commit, when clicking on menus or debug items or use menu items
the URL briefly changed pushing an unwanted history entry.

We do want those to be links (tag `a`) with an href to be able to open in a new tab.
But we don't want the current url hash to change because of it.

This commit fixes this.
---
 addons/web/static/src/core/debug/debug_menu.xml       |  2 +-
 addons/web/static/src/webclient/navbar/navbar.xml     | 11 ++++++-----
 .../web/static/src/webclient/user_menu/user_menu.xml  |  2 +-
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/addons/web/static/src/core/debug/debug_menu.xml b/addons/web/static/src/core/debug/debug_menu.xml
index 3c383283ea3..948caad0e78 100644
--- a/addons/web/static/src/core/debug/debug_menu.xml
+++ b/addons/web/static/src/core/debug/debug_menu.xml
@@ -12,7 +12,7 @@
                     <t t-if="!element.hide">
                         <t t-if="element.type == 'item'">
                             <DropdownItem payload="{ callback: element.callback }">
-                                <a t-if="element.href" t-att-href="element.href" t-esc="element.description"/>
+                                <a t-if="element.href" t-att-href="element.href" t-esc="element.description" t-on-click.prevent=""/>
                                 <span t-else="" t-esc="element.description"/>
                             </DropdownItem>
                         </t>
diff --git a/addons/web/static/src/webclient/navbar/navbar.xml b/addons/web/static/src/webclient/navbar/navbar.xml
index f2da688d5c9..4061c8512cb 100644
--- a/addons/web/static/src/webclient/navbar/navbar.xml
+++ b/addons/web/static/src/webclient/navbar/navbar.xml
@@ -20,7 +20,7 @@
           t-esc="currentApp.name"
           class="o_menu_brand"
           t-ref="menuBrand"
-          t-on-click="menuService.selectMenu(currentApp)"
+          t-on-click.prevent="menuService.selectMenu(currentApp)"
         />
 
         <!-- Current App Sections -->
@@ -54,7 +54,7 @@
           t-att-class="{ o_dropdown_active: menuService.getCurrentApp() === app }"
           payload="app"
         >
-          <a t-att-href="getMenuItemHref(app)" t-esc="app.name" />
+          <a t-att-href="getMenuItemHref(app)" t-esc="app.name" t-on-click.prevent="" />
         </MenuItem>
       </t>
     </Dropdown>
@@ -80,6 +80,7 @@
           <MenuItem title="section.name" class="o_nav_entry" payload="section" hotkey="hotkey">
             <a
               t-att-href="getMenuItemHref(section)"
+              t-on-click.prevent=""
               t-att-data-section="section.id"
               t-esc="section.name"
             />
@@ -115,7 +116,7 @@
   <t t-name="web.NavBar.SectionsMenu.Dropdown.MenuSlot" owl="1">
     <t t-foreach="items" t-as="item" t-key="item.id">
       <MenuItem t-if="!item.childrenTree.length" payload="item">
-        <a t-att-href="getMenuItemHref(item)" t-esc="item.name" />
+        <a t-att-href="getMenuItemHref(item)" t-esc="item.name" t-on-click.prevent="" />
       </MenuItem>
 
       <t t-else="">
@@ -126,7 +127,7 @@
           t-key="subItem.id"
           class="o_dropdown_menu_group_entry"
           payload="subItem">
-          <a t-att-href="getMenuItemHref(subItem)" t-esc="subItem.name" />
+          <a t-att-href="getMenuItemHref(subItem)" t-esc="subItem.name" t-on-click.prevent="" />
         </MenuItem>
       </t>
     </t>
@@ -140,7 +141,7 @@
 
           <t t-if="!section.childrenTree.length">
             <MenuItem class="o_more_dropdown_section" payload="section">
-              <a t-att-href="getMenuItemHref(section)" t-esc="section.name" />
+              <a t-att-href="getMenuItemHref(section)" t-esc="section.name" t-on-click.prevent="" />
             </MenuItem>
           </t>
           <t t-else="">
diff --git a/addons/web/static/src/webclient/user_menu/user_menu.xml b/addons/web/static/src/webclient/user_menu/user_menu.xml
index ee94e2a5e34..076f5298245 100644
--- a/addons/web/static/src/webclient/user_menu/user_menu.xml
+++ b/addons/web/static/src/webclient/user_menu/user_menu.xml
@@ -9,7 +9,7 @@
                     <t t-if="!element.hide">
                         <t t-if="element.type == 'item'">
                             <UserMenuItem payload="{ callback: element.callback, id: element.id }">
-                                <a t-if="element.href" t-att-href="element.href" t-esc="element.description"/>
+                                <a t-if="element.href" t-att-href="element.href" t-esc="element.description" t-on-click.prevent="" />
                                 <span t-else="" t-esc="element.description"/>
                             </UserMenuItem>
                         </t>