From 4decbcc55c6c468b7572fc8840d344bf1947c42b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Theys?= <seb@odoo.com>
Date: Wed, 12 Sep 2018 17:25:57 +0200
Subject: [PATCH] [IMP] account,sale,web: use classes for section and note

Instead of using custom CSS.

PR: #26801
task-1876864
---
 addons/account/views/report_invoice.xml      |  2 +-
 addons/sale/report/sale_report_templates.xml |  2 +-
 addons/sale/static/src/scss/sale_portal.scss |  9 ---------
 addons/sale/views/sale_portal_templates.xml  |  2 +-
 addons/web/static/src/scss/report.scss       | 15 ---------------
 5 files changed, 3 insertions(+), 27 deletions(-)

diff --git a/addons/account/views/report_invoice.xml b/addons/account/views/report_invoice.xml
index 18fac77f256..3a21d717719 100644
--- a/addons/account/views/report_invoice.xml
+++ b/addons/account/views/report_invoice.xml
@@ -75,7 +75,7 @@
                                 <t t-set="current_subtotal" t-value="current_subtotal + line.price_subtotal" groups="account.group_show_line_subtotals_tax_excluded"/>
                                 <t t-set="current_subtotal" t-value="current_subtotal + line.price_total" groups="account.group_show_line_subtotals_tax_included"/>
 
-                                <tr t-attf-class="{{ 'o_is_' + line.display_type if line.display_type else '' }}">
+                                <tr t-att-class="'bg-200 font-weight-bold' if line.display_type == 'line_section' else 'font-italic' if line.display_type == 'line_note' else ''">
                                     <t t-if="not line.display_type" name="account_invoice_line_accountable">
                                         <td name="account_invoice_line_name"><span t-field="line.name"/></td>
                                         <td class="d-none"><span t-field="line.origin"/></td>
diff --git a/addons/sale/report/sale_report_templates.xml b/addons/sale/report/sale_report_templates.xml
index 49daf9f74df..72816ae3941 100644
--- a/addons/sale/report/sale_report_templates.xml
+++ b/addons/sale/report/sale_report_templates.xml
@@ -94,7 +94,7 @@
                         <t t-set="current_subtotal" t-value="current_subtotal + line.price_subtotal" groups="account.group_show_line_subtotals_tax_excluded"/>
                         <t t-set="current_subtotal" t-value="current_subtotal + line.price_total" groups="account.group_show_line_subtotals_tax_included"/>
 
-                        <tr t-attf-class="{{ 'o_is_' + line.display_type if line.display_type else '' }}">
+                        <tr t-att-class="'bg-200 font-weight-bold' if line.display_type == 'line_section' else 'font-italic' if line.display_type == 'line_note' else ''">
                             <t t-if="not line.display_type">
                                 <td><span t-field="line.name"/></td>
                                 <td class="text-right">
diff --git a/addons/sale/static/src/scss/sale_portal.scss b/addons/sale/static/src/scss/sale_portal.scss
index 671002b1e98..dd3528e3628 100644
--- a/addons/sale/static/src/scss/sale_portal.scss
+++ b/addons/sale/static/src/scss/sale_portal.scss
@@ -8,12 +8,3 @@
 .orders_label_text_align {
     vertical-align: 15%;
 }
-
-tr.o_is_line_note {
-    font-style: italic;
-}
-
-tr.o_is_line_section {
-    font-weight: bold;
-    background-color: #DDDDDD;
-}
diff --git a/addons/sale/views/sale_portal_templates.xml b/addons/sale/views/sale_portal_templates.xml
index 8b97bfa546c..58b2752430e 100644
--- a/addons/sale/views/sale_portal_templates.xml
+++ b/addons/sale/views/sale_portal_templates.xml
@@ -468,7 +468,7 @@
                             <t t-set="current_subtotal" t-value="current_subtotal + line.price_subtotal" groups="account.group_show_line_subtotals_tax_excluded"/>
                             <t t-set="current_subtotal" t-value="current_subtotal + line.price_total" groups="account.group_show_line_subtotals_tax_included"/>
 
-                            <tr t-attf-class="{{ 'o_is_' + line.display_type if line.display_type else '' }}">
+                            <tr t-att-class="'bg-200 font-weight-bold' if line.display_type == 'line_section' else 'font-italic' if line.display_type == 'line_note' else ''">
                                 <t t-if="not line.display_type">
                                     <td id="product_name"><span t-field="line.name"/></td>
                                     <td class="text-right">
diff --git a/addons/web/static/src/scss/report.scss b/addons/web/static/src/scss/report.scss
index d93cfb89277..37a7630225b 100644
--- a/addons/web/static/src/scss/report.scss
+++ b/addons/web/static/src/scss/report.scss
@@ -44,18 +44,3 @@ body {
 .o_underline {
     text-decoration: underline;
 }
-
-/*
-    The goal of the following lines is to contain CSS hacks related to allowing
-    section and note on sale order and invoice.
-*/
-.row.o_is_line_section,
-.table > tbody > tr.o_is_line_section td {
-    font-weight: bold;
-    background-color: #DDDDDD;
-}
-
-.row.o_is_line_note,
-tr.o_is_line_note {
-    font-style: italic;
-}