From 4dd50925c4d051e94ebd849e2a62dcde601d768f Mon Sep 17 00:00:00 2001
From: Jaykishan Solanki <jao@odoo.com>
Date: Fri, 7 Jul 2017 18:53:30 +0530
Subject: [PATCH] [IMP] sale: Group by `confirm date` by default on `Sales
 Analysis` report

PURPOSE
=======

Currently 'Sales Analysis' report have by default group by creation date. here matters if confirmed SO is the confirmation date(for sales commission, etc), not the creation date.

SPECIFICATION
=============

'Sales Analysis' have default group by 'Confirmation Date'  instead of 'Creation Date'

PS: Validate 2 SO to have a confirmation date.
---
 addons/sale/data/sale_demo.xml           | 4 ++--
 addons/sale/report/sale_report_views.xml | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/addons/sale/data/sale_demo.xml b/addons/sale/data/sale_demo.xml
index ec2212457d7..e68b4e03664 100644
--- a/addons/sale/data/sale_demo.xml
+++ b/addons/sale/data/sale_demo.xml
@@ -180,7 +180,6 @@
             <field name="user_id" ref="base.user_root"/>
             <field name="pricelist_id" ref="product.list0"/>
             <field name="team_id" ref="sales_team.crm_team_1"/>
-            <field name="state">sale</field>
         </record>
 
         <record id="sale_order_line_15" model="sale.order.line">
@@ -246,7 +245,6 @@
             <field name="user_id" ref="base.user_demo"/>
             <field name="pricelist_id" ref="product.list0"/>
             <field name="team_id" ref="sales_team.crm_team_1"/>
-            <field name="state">sale</field>
         </record>
 
         <record id="sale_order_line_20" model="sale.order.line">
@@ -552,7 +550,9 @@
 
         <!-- Confirm some Sales Orders-->
         <function model="sale.order" name="action_confirm" eval="[[ref('sale_order_4')]]"/>
+        <function model="sale.order" name="action_confirm" eval="[[ref('sale_order_6')]]"/>
         <function model="sale.order" name="action_confirm" eval="[[ref('sale_order_7')]]"/>
+        <function model="sale.order" name="action_confirm" eval="[[ref('sale_order_8')]]"/>
         <function model="sale.order" name="action_confirm" eval="[[ref('sale_order_9')]]"/>
         <function model="sale.order" name="action_confirm" eval="[[ref('sale_order_10')]]"/>
         <function model="sale.order" name="action_confirm" eval="[[ref('sale_order_11')]]"/>
diff --git a/addons/sale/report/sale_report_views.xml b/addons/sale/report/sale_report_views.xml
index f42514261ff..97d41d68a4f 100644
--- a/addons/sale/report/sale_report_views.xml
+++ b/addons/sale/report/sale_report_views.xml
@@ -7,7 +7,7 @@
          <field name="arch" type="xml">
              <pivot string="Sales Analysis" disable_linking="True">
                  <field name="team_id" type="col"/>
-                 <field name="date" interval="month" type="row"/>
+                 <field name="confirmation_date" interval="month" type="row"/>
                  <field name="price_subtotal" type="measure"/>
              </pivot>
          </field>