From 4dd36a86e95b4883f8a0a2fc3ed2ceb72a2559ae Mon Sep 17 00:00:00 2001 From: oco-odoo Date: Fri, 31 Jan 2020 15:22:34 +0000 Subject: [PATCH] [FIX] account: fix bank account requirement on account.payment form When making a payment for multiple vendor bills at once, it is possible that payments will be generated without any recipient bank account for payment methods normally requiring one. In such cases, the user needs to be able to correct the payments by cancelling them. It was not possible. closes odoo/odoo#45082 X-original-commit: 9aec95dccef48a9ec89691f5721619ffc0e4da56 Signed-off-by: oco-odoo --- addons/hr_expense/wizard/hr_expense_sheet_register_payment.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/hr_expense/wizard/hr_expense_sheet_register_payment.py b/addons/hr_expense/wizard/hr_expense_sheet_register_payment.py index 0c7050b1d7a..375962e4426 100644 --- a/addons/hr_expense/wizard/hr_expense_sheet_register_payment.py +++ b/addons/hr_expense/wizard/hr_expense_sheet_register_payment.py @@ -68,7 +68,7 @@ class HrExpenseSheetRegisterPaymentWizard(models.TransientModel): won't be displayed but some modules might change that, depending on the payment type.""" for payment in self: payment.show_partner_bank_account = payment.payment_method_id.code in self.env['account.payment']._get_method_codes_using_bank_account() - payment.require_partner_bank_account = payment.payment_method_id.code in self.env['account.payment']._get_method_codes_needing_bank_account() + payment.require_partner_bank_account = payment.state == 'draft' and payment.payment_method_id.code in self.env['account.payment']._get_method_codes_needing_bank_account() @api.depends('journal_id') def _compute_hide_payment_method(self):