From 4dcef34df0e55f7b8677a35910351b56ae64dfda Mon Sep 17 00:00:00 2001
From: Yannick Tivisse <yti@odoo.com>
Date: Mon, 4 Nov 2019 16:39:09 +0100
Subject: [PATCH] [IMP] product: Adapt tests to work with/without demo data

---
 addons/product/tests/test_pricelist.py        |   6 +-
 .../test_product_attribute_value_config.py    | 143 +++++++++---------
 .../product/tests/test_product_pricelist.py   |  65 ++++++--
 addons/product/tests/test_seller.py           |   8 +-
 4 files changed, 139 insertions(+), 83 deletions(-)

diff --git a/addons/product/tests/test_pricelist.py b/addons/product/tests/test_pricelist.py
index 41e9d206463..610865f5af1 100644
--- a/addons/product/tests/test_pricelist.py
+++ b/addons/product/tests/test_pricelist.py
@@ -9,8 +9,8 @@ class TestPricelist(TransactionCase):
     def setUp(self):
         super(TestPricelist, self).setUp()
 
-        self.datacard = self.env.ref('product.product_delivery_02')
-        self.usb_adapter = self.env.ref('product.product_delivery_01')
+        self.datacard = self.env['product.product'].create({'name': 'Office Lamp'})
+        self.usb_adapter = self.env['product.product'].create({'name': 'Office Chair'})
         self.uom_ton = self.env.ref('uom.product_uom_ton')
         self.uom_unit_id = self.ref('uom.product_uom_unit')
         self.uom_dozen_id = self.ref('uom.product_uom_dozen')
@@ -73,7 +73,7 @@ class TestPricelist(TransactionCase):
         # make sure 'tonne' resolves down to 1 'kg'.
         self.uom_ton.write({'rounding': 0.001})
         # setup product stored in 'tonnes', with a discounted pricelist for qty > 3 tonnes
-        spam_id = self.usb_adapter.copy({
+        spam_id = self.env['product.product'].create({
             'name': '1 tonne of spam',
             'uom_id': self.uom_ton.id,
             'uom_po_id': self.uom_ton.id,
diff --git a/addons/product/tests/test_product_attribute_value_config.py b/addons/product/tests/test_product_attribute_value_config.py
index 2cd783d0f6a..4c7f34e1d1d 100644
--- a/addons/product/tests/test_product_attribute_value_config.py
+++ b/addons/product/tests/test_product_attribute_value_config.py
@@ -6,108 +6,114 @@ from psycopg2 import IntegrityError
 
 from odoo.exceptions import UserError, ValidationError
 from odoo.tests import tagged
-from odoo.tests.common import TransactionCase
+from odoo.tests.common import SavepointCase
 from odoo.tools import mute_logger
 
 
-class TestProductAttributeValueSetup(TransactionCase):
-    def setUp(self):
-        super(TestProductAttributeValueSetup, self).setUp()
+class TestProductAttributeValueSetup(SavepointCase):
+    @classmethod
+    def setUpClass(cls):
+        super(TestProductAttributeValueSetup, cls).setUpClass()
 
-        self.computer = self.env['product.template'].create({
+        cls.computer = cls.env['product.template'].create({
             'name': 'Super Computer',
             'price': 2000,
         })
 
-        self._add_ssd_attribute()
-        self._add_ram_attribute()
-        self._add_hdd_attribute()
+        cls._add_ssd_attribute()
+        cls._add_ram_attribute()
+        cls._add_hdd_attribute()
 
-        self.computer_case = self.env['product.template'].create({
+        cls.computer_case = cls.env['product.template'].create({
             'name': 'Super Computer Case'
         })
 
-        self._add_size_attribute()
+        cls._add_size_attribute()
 
-    def _add_ssd_attribute(self):
-        self.ssd_attribute = self.env['product.attribute'].create({'name': 'Memory', 'sequence': 1})
-        self.ssd_256 = self.env['product.attribute.value'].create({
+    @classmethod
+    def _add_ssd_attribute(cls):
+        cls.ssd_attribute = cls.env['product.attribute'].create({'name': 'Memory', 'sequence': 1})
+        cls.ssd_256 = cls.env['product.attribute.value'].create({
             'name': '256 GB',
-            'attribute_id': self.ssd_attribute.id,
+            'attribute_id': cls.ssd_attribute.id,
             'sequence': 1,
         })
-        self.ssd_512 = self.env['product.attribute.value'].create({
+        cls.ssd_512 = cls.env['product.attribute.value'].create({
             'name': '512 GB',
-            'attribute_id': self.ssd_attribute.id,
+            'attribute_id': cls.ssd_attribute.id,
             'sequence': 2,
         })
 
-        self._add_ssd_attribute_line()
+        cls._add_ssd_attribute_line()
 
-    def _add_ssd_attribute_line(self):
-        self.computer_ssd_attribute_lines = self.env['product.template.attribute.line'].create({
-            'product_tmpl_id': self.computer.id,
-            'attribute_id': self.ssd_attribute.id,
-            'value_ids': [(6, 0, [self.ssd_256.id, self.ssd_512.id])],
+    @classmethod
+    def _add_ssd_attribute_line(cls):
+        cls.computer_ssd_attribute_lines = cls.env['product.template.attribute.line'].create({
+            'product_tmpl_id': cls.computer.id,
+            'attribute_id': cls.ssd_attribute.id,
+            'value_ids': [(6, 0, [cls.ssd_256.id, cls.ssd_512.id])],
         })
-        self.computer_ssd_attribute_lines.product_template_value_ids[0].price_extra = 200
-        self.computer_ssd_attribute_lines.product_template_value_ids[1].price_extra = 400
+        cls.computer_ssd_attribute_lines.product_template_value_ids[0].price_extra = 200
+        cls.computer_ssd_attribute_lines.product_template_value_ids[1].price_extra = 400
 
-    def _add_ram_attribute(self):
-        self.ram_attribute = self.env['product.attribute'].create({'name': 'RAM', 'sequence': 2})
-        self.ram_8 = self.env['product.attribute.value'].create({
+    @classmethod
+    def _add_ram_attribute(cls):
+        cls.ram_attribute = cls.env['product.attribute'].create({'name': 'RAM', 'sequence': 2})
+        cls.ram_8 = cls.env['product.attribute.value'].create({
             'name': '8 GB',
-            'attribute_id': self.ram_attribute.id,
+            'attribute_id': cls.ram_attribute.id,
             'sequence': 1,
         })
-        self.ram_16 = self.env['product.attribute.value'].create({
+        cls.ram_16 = cls.env['product.attribute.value'].create({
             'name': '16 GB',
-            'attribute_id': self.ram_attribute.id,
+            'attribute_id': cls.ram_attribute.id,
             'sequence': 2,
         })
-        self.ram_32 = self.env['product.attribute.value'].create({
+        cls.ram_32 = cls.env['product.attribute.value'].create({
             'name': '32 GB',
-            'attribute_id': self.ram_attribute.id,
+            'attribute_id': cls.ram_attribute.id,
             'sequence': 3,
         })
-        self.computer_ram_attribute_lines = self.env['product.template.attribute.line'].create({
-            'product_tmpl_id': self.computer.id,
-            'attribute_id': self.ram_attribute.id,
-            'value_ids': [(6, 0, [self.ram_8.id, self.ram_16.id, self.ram_32.id])],
+        cls.computer_ram_attribute_lines = cls.env['product.template.attribute.line'].create({
+            'product_tmpl_id': cls.computer.id,
+            'attribute_id': cls.ram_attribute.id,
+            'value_ids': [(6, 0, [cls.ram_8.id, cls.ram_16.id, cls.ram_32.id])],
         })
-        self.computer_ram_attribute_lines.product_template_value_ids[0].price_extra = 20
-        self.computer_ram_attribute_lines.product_template_value_ids[1].price_extra = 40
-        self.computer_ram_attribute_lines.product_template_value_ids[2].price_extra = 80
+        cls.computer_ram_attribute_lines.product_template_value_ids[0].price_extra = 20
+        cls.computer_ram_attribute_lines.product_template_value_ids[1].price_extra = 40
+        cls.computer_ram_attribute_lines.product_template_value_ids[2].price_extra = 80
 
-    def _add_hdd_attribute(self):
-        self.hdd_attribute = self.env['product.attribute'].create({'name': 'HDD', 'sequence': 3})
-        self.hdd_1 = self.env['product.attribute.value'].create({
+    @classmethod
+    def _add_hdd_attribute(cls):
+        cls.hdd_attribute = cls.env['product.attribute'].create({'name': 'HDD', 'sequence': 3})
+        cls.hdd_1 = cls.env['product.attribute.value'].create({
             'name': '1 To',
-            'attribute_id': self.hdd_attribute.id,
+            'attribute_id': cls.hdd_attribute.id,
             'sequence': 1,
         })
-        self.hdd_2 = self.env['product.attribute.value'].create({
+        cls.hdd_2 = cls.env['product.attribute.value'].create({
             'name': '2 To',
-            'attribute_id': self.hdd_attribute.id,
+            'attribute_id': cls.hdd_attribute.id,
             'sequence': 2,
         })
-        self.hdd_4 = self.env['product.attribute.value'].create({
+        cls.hdd_4 = cls.env['product.attribute.value'].create({
             'name': '4 To',
-            'attribute_id': self.hdd_attribute.id,
+            'attribute_id': cls.hdd_attribute.id,
             'sequence': 3,
         })
 
-        self._add_hdd_attribute_line()
+        cls._add_hdd_attribute_line()
 
-    def _add_hdd_attribute_line(self):
-        self.computer_hdd_attribute_lines = self.env['product.template.attribute.line'].create({
-            'product_tmpl_id': self.computer.id,
-            'attribute_id': self.hdd_attribute.id,
-            'value_ids': [(6, 0, [self.hdd_1.id, self.hdd_2.id, self.hdd_4.id])],
+    @classmethod
+    def _add_hdd_attribute_line(cls):
+        cls.computer_hdd_attribute_lines = cls.env['product.template.attribute.line'].create({
+            'product_tmpl_id': cls.computer.id,
+            'attribute_id': cls.hdd_attribute.id,
+            'value_ids': [(6, 0, [cls.hdd_1.id, cls.hdd_2.id, cls.hdd_4.id])],
         })
-        self.computer_hdd_attribute_lines.product_template_value_ids[0].price_extra = 2
-        self.computer_hdd_attribute_lines.product_template_value_ids[1].price_extra = 4
-        self.computer_hdd_attribute_lines.product_template_value_ids[2].price_extra = 8
+        cls.computer_hdd_attribute_lines.product_template_value_ids[0].price_extra = 2
+        cls.computer_hdd_attribute_lines.product_template_value_ids[1].price_extra = 4
+        cls.computer_hdd_attribute_lines.product_template_value_ids[2].price_extra = 8
 
     def _add_ram_exclude_for(self):
         self._get_product_value_id(self.computer_ram_attribute_lines, self.ram_16).update({
@@ -117,27 +123,28 @@ class TestProductAttributeValueSetup(TransactionCase):
             })]
         })
 
-    def _add_size_attribute(self):
-        self.size_attribute = self.env['product.attribute'].create({'name': 'Size', 'sequence': 4})
-        self.size_m = self.env['product.attribute.value'].create({
+    @classmethod
+    def _add_size_attribute(cls):
+        cls.size_attribute = cls.env['product.attribute'].create({'name': 'Size', 'sequence': 4})
+        cls.size_m = cls.env['product.attribute.value'].create({
             'name': 'M',
-            'attribute_id': self.size_attribute.id,
+            'attribute_id': cls.size_attribute.id,
             'sequence': 1,
         })
-        self.size_l = self.env['product.attribute.value'].create({
+        cls.size_l = cls.env['product.attribute.value'].create({
             'name': 'L',
-            'attribute_id': self.size_attribute.id,
+            'attribute_id': cls.size_attribute.id,
             'sequence': 2,
         })
-        self.size_xl = self.env['product.attribute.value'].create({
+        cls.size_xl = cls.env['product.attribute.value'].create({
             'name': 'XL',
-            'attribute_id': self.size_attribute.id,
+            'attribute_id': cls.size_attribute.id,
             'sequence': 3,
         })
-        self.computer_case_size_attribute_lines = self.env['product.template.attribute.line'].create({
-            'product_tmpl_id': self.computer_case.id,
-            'attribute_id': self.size_attribute.id,
-            'value_ids': [(6, 0, [self.size_m.id, self.size_l.id, self.size_xl.id])],
+        cls.computer_case_size_attribute_lines = cls.env['product.template.attribute.line'].create({
+            'product_tmpl_id': cls.computer_case.id,
+            'attribute_id': cls.size_attribute.id,
+            'value_ids': [(6, 0, [cls.size_m.id, cls.size_l.id, cls.size_xl.id])],
         })
 
     def _get_product_value_id(self, product_template_attribute_lines, product_attribute_value):
diff --git a/addons/product/tests/test_product_pricelist.py b/addons/product/tests/test_product_pricelist.py
index acad92c3930..814d6595447 100644
--- a/addons/product/tests/test_product_pricelist.py
+++ b/addons/product/tests/test_product_pricelist.py
@@ -11,15 +11,62 @@ class TestProductPricelist(TransactionCase):
     def setUp(self):
         super(TestProductPricelist, self).setUp()
         self.ProductPricelist = self.env['product.pricelist']
-        self.res_partner_4 = self.env.ref('base.res_partner_4')
-        self.computer_SC234 = self.env.ref("product.product_product_3")
-        self.ipad_retina_display = self.env.ref('product.product_product_4')
-        self.custom_computer_kit = self.env.ref("product.product_product_5")
-        self.ipad_mini = self.env.ref("product.product_product_6")
-        self.apple_in_ear_headphones = self.env.ref("product.product_product_7")
-        self.laptop_E5023 = self.env.ref('product.product_delivery_01')
-        self.laptop_S3450 = self.env.ref("product.product_product_25")
-        self.category_5_id = self.ref('product.product_category_5')
+        self.res_partner_4 = self.env['res.partner'].create({'name': 'Ready Mat'})
+        self.res_partner_1 = self.env['res.partner'].create({'name': 'Wood Corner'})
+        self.category_5_id = self.env['product.category'].create({
+            'name': 'Office Furniture',
+            'parent_id': self.env.ref('product.product_category_1').id
+        }).id
+        self.computer_SC234 = self.env['product.product'].create({
+            'name': 'Desk Combination',
+            'categ_id': self.category_5_id,
+        })
+        self.ipad_retina_display = self.env['product.product'].create({
+            'name': 'Customizable Desk',
+        })
+        self.custom_computer_kit = self.env['product.product'].create({
+            'name': 'Corner Desk Right Sit',
+            'categ_id': self.category_5_id,
+        })
+        self.ipad_mini = self.env['product.product'].create({
+            'name': 'Large Cabinet',
+            'categ_id': self.category_5_id,
+            'standard_price': 800.0,
+        })
+        self.env['product.supplierinfo'].create([
+            {
+                'name': self.res_partner_1.id,
+                'product_tmpl_id': self.ipad_mini.product_tmpl_id.id,
+                'delay': 3,
+                'min_qty': 1,
+                'price': 750,
+            }, {
+                'name': self.res_partner_4.id,
+                'product_tmpl_id': self.ipad_mini.product_tmpl_id.id,
+                'delay': 3,
+                'min_qty': 1,
+                'price': 790,
+            }, {
+                'name': self.res_partner_4.id,
+                'product_tmpl_id': self.ipad_mini.product_tmpl_id.id,
+                'delay': 3,
+                'min_qty': 3,
+                'price': 785,
+            }
+        ])
+        self.apple_in_ear_headphones = self.env['product.product'].create({
+            'name': 'Storage Box',
+            'categ_id': self.category_5_id,
+        })
+        self.laptop_E5023 = self.env['product.product'].create({
+            'name': 'Office Chair',
+            'categ_id': self.category_5_id,
+        })
+        self.laptop_S3450 = self.env['product.product'].create({
+            'name': 'Acoustic Bloc Screens',
+            'categ_id': self.category_5_id,
+        })
+
         self.uom_unit_id = self.ref('uom.product_uom_unit')
         self.list0 = self.ref('product.list0')
 
diff --git a/addons/product/tests/test_seller.py b/addons/product/tests/test_seller.py
index 637c59b78c9..e8e92afbf84 100644
--- a/addons/product/tests/test_seller.py
+++ b/addons/product/tests/test_seller.py
@@ -8,15 +8,17 @@ class TestSeller(TransactionCase):
 
     def setUp(self):
         super(TestSeller, self).setUp()
-        self.product_service = self.env.ref('product.product_product_2')
+        self.product_service = self.env['product.product'].create({
+            'name': 'Virtual Home Staging',
+        })
         self.product_service.default_code = 'DEFCODE'
         self.product_consu = self.env['product.product'].create({
             'name': 'Boudin',
             'type': 'consu',
         })
         self.product_consu.default_code = 'DEFCODE'
-        self.asustec = self.env.ref('base.res_partner_1')
-        self.camptocamp = self.env.ref('base.res_partner_12')
+        self.asustec = self.env['res.partner'].create({'name': 'Wood Corner'})
+        self.camptocamp = self.env['res.partner'].create({'name': 'Azure Interior'})
 
     def test_10_sellers(self):
         self.product_service.write({'seller_ids': [