From 4dcc5322822d3a3d5e13e95ea53027330dccc93f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= <tde@odoo.com>
Date: Fri, 21 Aug 2020 09:11:24 +0000
Subject: [PATCH] [IMP] website_event_track_online: rename Reminder to Favorite

SPECIFICATIONS

Button to add a track in wishlist is either mentionned as wishlist, reminder
or event favorite. This is due to its naming evolving during various iterations
of dev and spec.

We set it to Favorite once for all.

UPDATE

  * website_event_track_online.track_widget_reminder
  * website_event_track_session.session_topbar

LINKS

Task ID-2314778 (event online fixes)
PR #56340

X-Original-PR #56254
X-Original-Commit odoo/odoo@73619ab9f61bbf214aaeb9bb70de4ee81bd2066d
---
 .../static/src/js/tours/wevent_register_tour.js    | 14 +++++++-------
 .../static/src/js/event_track_reminder.js          |  6 +++---
 .../views/event_track_templates_list.xml           |  4 ++--
 .../views/event_track_templates_reminder.xml       |  8 +++++---
 4 files changed, 17 insertions(+), 15 deletions(-)

diff --git a/addons/test_event_full/static/src/js/tours/wevent_register_tour.js b/addons/test_event_full/static/src/js/tours/wevent_register_tour.js
index 1b12c66d920..2d44644cdb3 100644
--- a/addons/test_event_full/static/src/js/tours/wevent_register_tour.js
+++ b/addons/test_event_full/static/src/js/tours/wevent_register_tour.js
@@ -24,27 +24,27 @@ var discoverTalkSteps = function (talkName, fromList, reminderOn, toggleReminder
     }
     if (reminderOn) {
         steps = steps.concat([{
-            content: "Check Reminder is on",
+            content: "Check Favorite is on",
             trigger: 'div.o_wetrack_js_reminder i.fa-bell',
-            extra_trigger: 'span.o_wetrack_js_reminder_text:contains("Reminder On")',
+            extra_trigger: 'span.o_wetrack_js_reminder_text:contains("Favorite On")',
             run: function () {}, // it's a check
         }]);
     }
     else {
         steps = steps.concat([{
-            content: "Check Reminder is Off",
-            trigger: 'span.o_wetrack_js_reminder_text:contains("Set Reminder")',
+            content: "Check Favorite is Off",
+            trigger: 'span.o_wetrack_js_reminder_text:contains("Set Favorite")',
             run: function () {}, // it's a check
         }]);
         if (toggleReminder) {
             steps = steps.concat([{
-                content: "Set Reminder",
+                content: "Set Favorite",
                 trigger: 'span.o_wetrack_js_reminder_text',
                 run: 'click',
             }, {
-                content: "Check Reminder is On",
+                content: "Check Favorite is On",
                 trigger: 'div.o_wetrack_js_reminder i.fa-bell',
-                extra_trigger: 'span.o_wetrack_js_reminder_text:contains("Reminder On")',
+                extra_trigger: 'span.o_wetrack_js_reminder_text:contains("Favorite On")',
                 run: function () {}, // it's a check
             }]);
         }
diff --git a/addons/website_event_track/static/src/js/event_track_reminder.js b/addons/website_event_track/static/src/js/event_track_reminder.js
index a4d86dd9452..18fc3a4ab2e 100644
--- a/addons/website_event_track/static/src/js/event_track_reminder.js
+++ b/addons/website_event_track/static/src/js/event_track_reminder.js
@@ -55,7 +55,7 @@ publicWidget.registry.websiteEventTrackReminder = publicWidget.Widget.extend({
                 });
             } else {
                 self.reminderOn = reminderOnValue;
-                var reminderText = self.reminderOn ? _t('Reminder On') : _t('Set Reminder');
+                var reminderText = self.reminderOn ? _t('Favorite On') : _t('Set Favorite');
                 self.$('.o_wetrack_js_reminder_text').text(reminderText);
                 self._updateDisplay();
                 var message = self.reminderOn ? _t('Talk added to your Favorites') : _t('Talk removed from your Favorites');
@@ -74,10 +74,10 @@ publicWidget.registry.websiteEventTrackReminder = publicWidget.Widget.extend({
         var $trackLink = this.$el.find('i');
         if (this.reminderOn) {
             $trackLink.addClass('fa-bell').removeClass('fa-bell-o');
-            $trackLink.attr('title', _t('Reminder On'));
+            $trackLink.attr('title', _t('Favorite On'));
         } else {
             $trackLink.addClass('fa-bell-o').removeClass('fa-bell');
-            $trackLink.attr('title', _t('Set Reminder'));
+            $trackLink.attr('title', _t('Set Favorite'));
         }
     },
 
diff --git a/addons/website_event_track/views/event_track_templates_list.xml b/addons/website_event_track/views/event_track_templates_list.xml
index 85059f44c71..505a68ef4aa 100644
--- a/addons/website_event_track/views/event_track_templates_list.xml
+++ b/addons/website_event_track/views/event_track_templates_list.xml
@@ -38,7 +38,7 @@
                     <!-- Optional wishlist filter -->
                     <li t-if="option_track_wishlist" class="nav-item dropdown mr-2 my-1">
                         <a href="#" role="button" class="btn dropdown-toggle" data-toggle="dropdown">
-                            <i class="fa fa-folder-open"/> Wishlist
+                            <i class="fa fa-folder-open"/> Favorites
                         </a>
                         <div class="dropdown-menu">
                             <a t-att-href="'/event/%s/track?%s' % (
@@ -53,7 +53,7 @@
                                     keep_query('*', search_wishlist='1')
                                 )"
                                 t-attf-class="dropdown-item d-flex align-items-center justify-content-between #{'active' if search_wishlist else ''}">
-                                Wishlisted
+                                Favorites
                             </a>
                         </div>
                     </li>
diff --git a/addons/website_event_track/views/event_track_templates_reminder.xml b/addons/website_event_track/views/event_track_templates_reminder.xml
index 5731dc81ce7..df996d5abd6 100644
--- a/addons/website_event_track/views/event_track_templates_reminder.xml
+++ b/addons/website_event_track/views/event_track_templates_reminder.xml
@@ -10,15 +10,17 @@
     <div t-att-class="'o_wetrack_js_reminder btn %s %s' % (
         'btn-link' if reminder_light else 'btn-outline-primary',
         'btn-sm' if reminder_small else '')">
+        <t t-if="track.is_reminder_on" t-set="title">Favorite On</t>
+        <t t-else="track.is_reminder_on" t-set="title">Set Favorite</t>
         <i t-att-class="'fa fa-bell%s inactive_color_%s' % ('' if track.is_reminder_on else '-o', 'dark' if reminder_light and not light_theme else 'light')"
            t-att-data-track-id="track.id"
-           t-att-title="'Reminder On' if track.is_reminder_on else 'Set a Reminder'"
+           t-att-title="title"
            t-att-data-reminder-on="bool(track.is_reminder_on)"></i>
         <span t-if="not reminder_light" class="o_wetrack_js_reminder_text">
             <t t-if="not track.is_reminder_on">
-                Set Reminder
+                Set Favorite
             </t><t t-else="">
-                Reminder On
+                Favorite On
             </t>
         </span>
     </div>