From 4d7efe41f5e30d0f7e99e09a30619649790433b2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= <tde@odoo.com>
Date: Wed, 10 Nov 2021 08:21:36 +0000
Subject: [PATCH] [MOV] gamification: move menus definition

Purpose of this commit is to have all gamification menus defined in a single
file. It helps reorganizing a module TOC (menus) when doing some b2b like
on an app. Otherwise menus are split across several files and finding them
and keeping them organized is not easy.

Task-2678295

Part-of: odoo/odoo#79599
---
 addons/gamification/__manifest__.py           |  1 +
 .../views/gamification_goal_views.xml         |  7 ----
 .../views/gamification_karma_rank_views.xml   |  2 --
 .../gamification_karma_tracking_views.xml     |  5 ---
 .../gamification/views/gamification_menus.xml | 33 +++++++++++++++++++
 5 files changed, 34 insertions(+), 14 deletions(-)
 create mode 100644 addons/gamification/views/gamification_menus.xml

diff --git a/addons/gamification/__manifest__.py b/addons/gamification/__manifest__.py
index f746a485af4..84bd41c577e 100644
--- a/addons/gamification/__manifest__.py
+++ b/addons/gamification/__manifest__.py
@@ -31,6 +31,7 @@ Both goals and badges are flexibles and can be adapted to a large range of modul
         'views/gamification_goal_definition_views.xml',
         'views/gamification_challenge_views.xml',
         'views/gamification_challenge_line_views.xml',
+        'views/gamification_menus.xml',
         'data/cron.xml',
         'security/gamification_security.xml',
         'security/ir.model.access.csv',
diff --git a/addons/gamification/views/gamification_goal_views.xml b/addons/gamification/views/gamification_goal_views.xml
index 82582b42c83..e8ce7e13dbd 100644
--- a/addons/gamification/views/gamification_goal_views.xml
+++ b/addons/gamification/views/gamification_goal_views.xml
@@ -209,11 +209,4 @@
             </kanban>
         </field>
     </record>
-
-    <!-- menus in settings - technical feature required -->
-    <menuitem id="gamification_menu" name="Gamification Tools" parent="base.menu_administration" groups="base.group_no_one" />
-        <menuitem id="gamification_challenge_menu" parent="gamification_menu" action="challenge_list_action" sequence="0"/>
-        <menuitem id="gamification_goal_menu" parent="gamification_menu" action="goal_list_action" sequence="10"/>
-        <menuitem id="gamification_definition_menu" parent="gamification_menu" action="goal_definition_list_action" sequence="20"/>
-        <menuitem id="gamification_badge_menu" parent="gamification_menu" action="badge_list_action" sequence="30"/>
 </odoo>
diff --git a/addons/gamification/views/gamification_karma_rank_views.xml b/addons/gamification/views/gamification_karma_rank_views.xml
index 36f841fa37f..7d3a6844d51 100644
--- a/addons/gamification/views/gamification_karma_rank_views.xml
+++ b/addons/gamification/views/gamification_karma_rank_views.xml
@@ -81,7 +81,5 @@
                 </form>
             </field>
         </record>
-
-        <menuitem id="gamification_karma_ranks_menu" parent="gamification_menu" action="gamification_karma_ranks_action" sequence="40"/>
     </data>
 </odoo>
diff --git a/addons/gamification/views/gamification_karma_tracking_views.xml b/addons/gamification/views/gamification_karma_tracking_views.xml
index 998d0ff91ec..0592bf3e1de 100644
--- a/addons/gamification/views/gamification_karma_tracking_views.xml
+++ b/addons/gamification/views/gamification_karma_tracking_views.xml
@@ -54,10 +54,5 @@
         <field name="res_model">gamification.karma.tracking</field>
         <field name="view_mode">tree,form</field>
     </record>
-
-    <menuitem id="gamification_karma_tracking_menu"
-        parent="gamification_menu"
-        action="gamification_karma_tracking_action"
-        sequence="50"/>
     </data>
 </odoo>
diff --git a/addons/gamification/views/gamification_menus.xml b/addons/gamification/views/gamification_menus.xml
new file mode 100644
index 00000000000..593fda4b518
--- /dev/null
+++ b/addons/gamification/views/gamification_menus.xml
@@ -0,0 +1,33 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <!-- menus in settings - technical feature required -->
+    <menuitem id="gamification_menu"
+              name="Gamification Tools"
+              parent="base.menu_administration"
+              groups="base.group_no_one" />
+
+    <menuitem id="gamification_challenge_menu"
+              parent="gamification_menu"
+              action="challenge_list_action"
+              sequence="0"/>
+    <menuitem id="gamification_goal_menu"
+              parent="gamification_menu"
+              action="goal_list_action"
+              sequence="10"/>
+    <menuitem id="gamification_definition_menu"
+              parent="gamification_menu"
+              action="goal_definition_list_action"
+              sequence="20"/>
+    <menuitem id="gamification_badge_menu"
+              parent="gamification_menu"
+              action="badge_list_action"
+              sequence="30"/>
+    <menuitem id="gamification_karma_ranks_menu"
+              parent="gamification_menu"
+              action="gamification_karma_ranks_action"
+              sequence="40"/>
+    <menuitem id="gamification_karma_tracking_menu"
+              parent="gamification_menu"
+              action="gamification_karma_tracking_action"
+              sequence="50"/>
+</odoo>