From 4d73c391dc8ec31cacf5ee02f7acfb6c4e6a70d0 Mon Sep 17 00:00:00 2001 From: "Shaan Thakkar (THSH)" Date: Thu, 28 Dec 2023 09:20:26 +0000 Subject: [PATCH] [FIX] mass_mailing_sale: wrong domain on quotation count MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Steps to Reproduce ================== 1). Create an empty quotation and link it to a mass mailing (same medium and source). 2). ​Open the mailing form, the stat button displays "1 Quotation" 3). ​Click to open it -> Empty Screen Technical ========== There are no records in this view as it is based on the sales report model. If a quote has no line, there is nothing to display. After this commit ================= Now empty quotes will not be counted. Task-3635429 closes odoo/odoo#152241 X-original-commit: 05c2859ccebcfc60e27a4833c57f98c2d7944bbb Signed-off-by: Warnon Aurélien (awa) --- addons/mass_mailing_sale/models/mailing_mailing.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/mass_mailing_sale/models/mailing_mailing.py b/addons/mass_mailing_sale/models/mailing_mailing.py index 605dbdabfd5..df9b7f41a76 100644 --- a/addons/mass_mailing_sale/models/mailing_mailing.py +++ b/addons/mass_mailing_sale/models/mailing_mailing.py @@ -16,7 +16,7 @@ class MassMailing(models.Model): @api.depends('mailing_domain') def _compute_sale_quotation_count(self): quotation_data = self.env['sale.order'].sudo()._read_group( - [('source_id', 'in', self.source_id.ids)], + [('source_id', 'in', self.source_id.ids), ('order_line', '!=', False)], ['source_id'], ['__count'], ) mapped_data = {source.id: count for source, count in quotation_data}