From 4d4557b596b3215474aecb20c7717fd6307ddec6 Mon Sep 17 00:00:00 2001
From: "Achraf (abz)" <abz@odoo.com>
Date: Wed, 5 May 2021 09:02:51 +0000
Subject: [PATCH] [FIX] account: Prevent user to change product via journal
 items after posting
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

What are the steps to reproduce your issue ?

    1. Go to Account/Journal Items
    2. Open a posted item
    3. Change product

What is currently happening ?

    The product is changed in the account move

What are you expecting to happen ?

    The account move lines cannot be changed when the status is posted

How to fix the bug ?

    Make the field read-only when the status is posted

opw-2517325

closes odoo/odoo#70533

X-original-commit: 1b8f7ad00e9274b4b8f82ef77864997286611593
Signed-off-by: Achraf <abz-odoo@users.noreply.github.com>
Signed-off-by: William André (wan) <wan@odoo.com>
---
 addons/account/views/account_move_views.xml | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/addons/account/views/account_move_views.xml b/addons/account/views/account_move_views.xml
index 514bc74b94e..f6213e67916 100644
--- a/addons/account/views/account_move_views.xml
+++ b/addons/account/views/account_move_views.xml
@@ -18,19 +18,19 @@
                             <field name="name"/>
                             <field name="partner_id"
                                 domain="['|', ('parent_id', '=', False), ('is_company', '=', True)]"
-                                attrs="{'readonly': [('parent_state', '=', 'posted')]}"/>
+                                readonly="1"/>
                         </group>
                         <notebook colspan="4">
                             <page string="Information" name="information">
                                 <group>
                                     <group string="Amount">
-                                        <field name="account_id" options="{'no_create': True}" domain="[('company_id', '=', company_id)]" attrs="{'readonly':[('parent_state','=','posted')]}"/>
-                                        <field name="debit" attrs="{'readonly':[('parent_state','=','posted')]}"/>
-                                        <field name="credit" attrs="{'readonly':[('parent_state','=','posted')]}"/>
-                                        <field name="quantity" attrs="{'readonly':[('parent_state','=','posted')]}"/>
+                                        <field name="account_id" options="{'no_create': True}" domain="[('company_id', '=', company_id)]" readonly="1"/>
+                                        <field name="debit" readonly="1"/>
+                                        <field name="credit" readonly="1"/>
+                                        <field name="quantity" readonly="1"/>
                                     </group>
                                     <group string="Accounting Documents">
-                                        <field name="move_id" attrs="{'readonly':[('parent_state','=','posted')]}"/>
+                                        <field name="move_id" readonly="1"/>
                                         <field name="statement_id" readonly="True" attrs="{'invisible': [('statement_id','=',False)]}"/>
                                     </group>
                                     <group string="Dates">
@@ -42,7 +42,7 @@
                                         <field name="tax_line_id" readonly="1" attrs="{'invisible': [('tax_line_id','=',False)]}"/>
                                         <field name="tax_ids" widget="many2many_tags" readonly="1" attrs="{'invisible': [('tax_ids','=',[])]}"/>
                                         <field name="tax_tag_invert" readonly="1" groups="base.group_no_one"/>
-                                        <field name="tax_exigible" attrs="{'readonly':[('parent_state','=','posted')]}"/>
+                                        <field name="tax_exigible" readonly="1"/>
                                         <field name="tax_audit"/>
                                     </group>
                                     <group string="Matching" attrs="{'invisible':[('matched_debit_ids', '=', []),('matched_credit_ids', '=', [])]}">
@@ -64,7 +64,7 @@
                                         <field name="amount_currency"/>
                                     </group>
                                     <group string="Product" attrs="{'invisible': [('product_id', '=', False)]}">
-                                        <field name="product_id"/>
+                                        <field name="product_id" readonly="1"/>
                                     </group>
                                     <group string="States">
                                         <field name="blocked"/>
@@ -72,7 +72,7 @@
                                     <group string="Analytic" groups="analytic.group_analytic_accounting,analytic.group_analytic_tags">
                                         <field name="analytic_account_id" groups="analytic.group_analytic_accounting"
                                             domain="['|', ('company_id', '=', company_id), ('company_id', '=', False)]"
-                                            attrs="{'readonly':[('parent_state','=','posted')]}"/>
+                                            readonly="1"/>
                                         <field name="analytic_tag_ids" groups="analytic.group_analytic_tags"
                                             widget="many2many_tags"/>
                                     </group>
@@ -997,7 +997,7 @@
                                             </group>
                                             <group>
                                                 <field name="analytic_tag_ids" groups="analytic.group_analytic_tags" widget="many2many_tags"/>
-                                                <field name="account_id" options="{'no_create': True}" domain="[('company_id', '=', company_id)]" attrs="{'readonly':[('parent_state','=','posted')]}"/>
+                                                <field name="account_id" options="{'no_create': True}" domain="[('company_id', '=', company_id)]" readonly="1"/>
                                                 <field name="tax_ids" widget="many2many_tags"/>
                                                 <field name="analytic_account_id" groups="analytic.group_analytic_accounting"/>
                                             </group>