From 4cdc7c565d25bf92f98da7b3f85b256f27a8eb23 Mon Sep 17 00:00:00 2001 From: TWA Date: Mon, 6 Aug 2018 09:16:47 +0000 Subject: [PATCH] [IMP] mail,crm,...: Replace occurences of name_get()[0][1] by display_name Purpose ======= display_name is equal to doing name_get()[0][1] Replacing name_get()[0][1] by display_name could be good for 2 things: - Uniformization of the code - Probable optimization if name_get is used inside a for loop on a recordset (as the values will be prefetched and put in the cache). TaskID: 1849250 closes odoo/enterprise#2515 --- models/sale_coupon_program.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/models/sale_coupon_program.py b/models/sale_coupon_program.py index 0fdaf0fcfe0..3a02ff59cc9 100644 --- a/models/sale_coupon_program.py +++ b/models/sale_coupon_program.py @@ -94,7 +94,7 @@ class SaleCouponProgram(models.Model): program = super(SaleCouponProgram, self).create(vals) if not vals.get('discount_line_product_id', False): discount_line_product_id = self.env['product.product'].create({ - 'name': program.reward_id.name_get()[0][1], + 'name': program.reward_id.display_name, 'type': 'service', 'taxes_id': False, 'supplier_taxes_id': False, @@ -113,7 +113,7 @@ class SaleCouponProgram(models.Model): 'discount_apply_on', 'discount_specific_product_id', 'discount_fixed_amount' ] if any(field in reward_fields for field in vals): - self.mapped('discount_line_product_id').write({'name': self[0].reward_id.name_get()[0][1]}) + self.mapped('discount_line_product_id').write({'name': self[0].reward_id.display_name}) return res def unlink(self):