From 6ddfabaf17d258c0c54749e663f88072e874802f Mon Sep 17 00:00:00 2001
From: Mustufa Rangwala <mra@tinyerp.com>
Date: Thu, 4 Dec 2008 12:23:34 +0530
Subject: [PATCH 01/24] mrp_repair

bzr revid: mra@tinyerp.com-20081204065334-zjp08syur6t8z8e9
---
 addons/mrp_repair/report/order.rml | 265 ++++++++++++++++-------------
 1 file changed, 148 insertions(+), 117 deletions(-)

diff --git a/addons/mrp_repair/report/order.rml b/addons/mrp_repair/report/order.rml
index 223bcd38fbe..34c6902308f 100644
--- a/addons/mrp_repair/report/order.rml
+++ b/addons/mrp_repair/report/order.rml
@@ -70,24 +70,17 @@
     <blockTableStyle id="Table6">
       <blockAlignment value="LEFT"/>
       <blockValign value="TOP"/>
-      <lineStyle kind="LINEBELOW" colorName="#cccccc" start="0,-1" stop="0,-1"/>
-      <lineStyle kind="LINEBELOW" colorName="#cccccc" start="1,-1" stop="1,-1"/>
-      <lineStyle kind="LINEBELOW" colorName="#cccccc" start="2,-1" stop="2,-1"/>
-      <lineStyle kind="LINEBELOW" colorName="#cccccc" start="3,-1" stop="3,-1"/>
-      <lineStyle kind="LINEBELOW" colorName="#cccccc" start="4,-1" stop="4,-1"/>
-      <lineStyle kind="LINEBELOW" colorName="#cccccc" start="5,-1" stop="5,-1"/>
+      <lineStyle kind="LINEBELOW" colorName="#000000" start="0,-1" stop="0,-1"/>
+      <lineStyle kind="LINEBELOW" colorName="#000000" start="1,-1" stop="1,-1"/>
+      <lineStyle kind="LINEBELOW" colorName="#000000" start="2,-1" stop="2,-1"/>
+      <lineStyle kind="LINEBELOW" colorName="#000000" start="3,-1" stop="3,-1"/>
+      <lineStyle kind="LINEBELOW" colorName="#000000" start="4,-1" stop="4,-1"/>
+      <lineStyle kind="LINEBELOW" colorName="#000000" start="5,-1" stop="5,-1"/>
     </blockTableStyle>
-    <blockTableStyle id="Table9">
-      <blockAlignment value="LEFT"/>
-      <blockValign value="TOP"/>
-    </blockTableStyle>
-    <blockTableStyle id="Table10">
-      <blockAlignment value="LEFT"/>
-      <blockValign value="TOP"/>
-    </blockTableStyle>
-    <blockTableStyle id="Table11">
+    <blockTableStyle id="Table7">
       <blockAlignment value="LEFT"/>
       <blockValign value="TOP"/>
+      <lineStyle kind="LINEBELOW" colorName="#000000" start="3,1" stop="-1,-1"/>
     </blockTableStyle>
     <blockTableStyle id="Table8">
       <blockAlignment value="LEFT"/>
@@ -101,34 +94,39 @@
     <paraStyle name="P3" fontName="Helvetica" fontSize="9.0" leading="11" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
     <paraStyle name="P4" fontName="Helvetica-Oblique" fontSize="7.0" leading="9" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
     <paraStyle name="P5" fontName="Helvetica-Bold" fontSize="9.0" leading="11" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
-    <paraStyle name="P6" fontName="Helvetica" fontSize="8.0" leading="10" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
-    <paraStyle name="P7" fontName="Helvetica-Bold" fontSize="15.0" leading="19" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
+    <paraStyle name="P6" fontName="Helvetica" fontSize="9.0" leading="11" alignment="CENTER" spaceBefore="0.0" spaceAfter="0.0"/>
+    <paraStyle name="P7" fontName="Helvetica" fontSize="8.0" leading="10" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
     <paraStyle name="P8" fontName="Helvetica-Bold" fontSize="15.0" leading="19" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
-    <paraStyle name="P9" fontName="Helvetica-Bold" fontSize="5.0" leading="7" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
-    <paraStyle name="P10" fontName="Helvetica-Bold" fontSize="7.0" leading="9" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
-    <paraStyle name="P11" fontName="Helvetica" fontSize="8.0" leading="10" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
-    <paraStyle name="P12" fontName="Helvetica-Bold" fontSize="9.0" leading="11" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
-    <paraStyle name="P13" fontName="Helvetica-Bold" fontSize="10.0" leading="13" alignment="CENTER" spaceBefore="6.0" spaceAfter="6.0"/>
-    <paraStyle name="P14" fontName="Helvetica-Bold" fontSize="8.0" leading="10" alignment="CENTER" spaceBefore="6.0" spaceAfter="6.0"/>
-    <paraStyle name="P15" fontName="Helvetica" fontSize="8.0" leading="10" alignment="CENTER" spaceBefore="0.0" spaceAfter="0.0"/>
-    <paraStyle name="P16" fontName="Helvetica-Bold" fontSize="10.0" leading="13" alignment="CENTER" spaceBefore="6.0" spaceAfter="6.0"/>
+    <paraStyle name="P9" fontName="Helvetica-Bold" fontSize="15.0" leading="19" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
+    <paraStyle name="P10" fontName="Helvetica-Bold" fontSize="5.0" leading="7" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
+    <paraStyle name="P11" fontName="Helvetica-Bold" fontSize="7.0" leading="9" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
+    <paraStyle name="P12" fontName="Helvetica" fontSize="8.0" leading="10" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
+    <paraStyle name="P13" fontName="Helvetica-Bold" fontSize="9.0" leading="11" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
+    <paraStyle name="P14" fontName="Helvetica-Bold" fontSize="10.0" leading="13" alignment="CENTER" spaceBefore="6.0" spaceAfter="6.0"/>
+    <paraStyle name="P15" fontName="Helvetica-Bold" fontSize="8.0" leading="10" alignment="CENTER" spaceBefore="6.0" spaceAfter="6.0"/>
+    <paraStyle name="P16" fontName="Helvetica" fontSize="8.0" leading="10" alignment="CENTER" spaceBefore="0.0" spaceAfter="0.0"/>
     <paraStyle name="P17" fontName="Helvetica-Bold" fontSize="10.0" leading="13" alignment="CENTER" spaceBefore="6.0" spaceAfter="6.0"/>
-    <paraStyle name="P18" fontName="Helvetica-Bold" fontSize="10.0" leading="13" alignment="RIGHT" spaceBefore="6.0" spaceAfter="6.0"/>
-    <paraStyle name="P19" fontName="Helvetica" fontSize="9.0" leading="11" alignment="CENTER" spaceBefore="0.0" spaceAfter="0.0"/>
-    <paraStyle name="P20" fontName="Helvetica-Oblique" fontSize="2.0" leading="3" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
-    <paraStyle name="P21" fontName="Helvetica"/>
-    <paraStyle name="P22" fontName="Times-Roman"/>
-    <paraStyle name="P23" fontName="Times-Roman"/>
-    <paraStyle name="P24" fontName="Helvetica-Oblique" fontSize="2.0" leading="3"/>
-    <paraStyle name="P25" fontName="Helvetica-Oblique" fontSize="2.0" leading="3" alignment="RIGHT"/>
-    <paraStyle name="P26" fontName="Helvetica-Bold" fontSize="9.0" leading="11"/>
-    <paraStyle name="P27" fontName="Helvetica" fontSize="9.0" leading="11" alignment="CENTER" spaceBefore="0.0" spaceAfter="0.0"/>
-    <paraStyle name="P28" fontName="Helvetica-Bold" fontSize="9.0" leading="11" alignment="RIGHT"/>
-    <paraStyle name="P29" fontName="Helvetica" fontSize="9.0" leading="11" alignment="RIGHT"/>
-    <paraStyle name="P30" fontName="Helvetica" fontSize="9.0" leading="11" alignment="RIGHT"/>
-    <paraStyle name="P31" fontName="Helvetica-Bold" fontSize="9.0" leading="11" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
-    <paraStyle name="P32" fontName="Helvetica" fontSize="2.0" leading="3" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
-    <paraStyle name="P33" fontName="Helvetica" fontSize="5.0" leading="7" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
+    <paraStyle name="P18" fontName="Helvetica-Bold" fontSize="10.0" leading="13" alignment="CENTER" spaceBefore="6.0" spaceAfter="6.0"/>
+    <paraStyle name="P19" fontName="Helvetica-Bold" fontSize="10.0" leading="13" alignment="RIGHT" spaceBefore="6.0" spaceAfter="6.0"/>
+    <paraStyle name="P20" fontName="Helvetica" fontSize="9.0" leading="11" alignment="CENTER" spaceBefore="0.0" spaceAfter="0.0"/>
+    <paraStyle name="P21" fontName="Helvetica-Oblique" fontSize="2.0" leading="3" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
+    <paraStyle name="P22" fontName="Helvetica-Bold" fontSize="9.0" leading="11"/>
+    <paraStyle name="P23" fontName="Helvetica"/>
+    <paraStyle name="P24" fontName="Helvetica-Bold" fontSize="9.0" leading="11" alignment="RIGHT"/>
+    <paraStyle name="P25" fontName="Helvetica" fontSize="9.0" leading="11" alignment="RIGHT"/>
+    <paraStyle name="P26" fontName="Helvetica" fontSize="9.0" leading="11" alignment="RIGHT"/>
+    <paraStyle name="P27" fontName="Helvetica-Bold" fontSize="9.0" leading="11" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
+    <paraStyle name="P28" fontName="Helvetica" fontSize="2.0" leading="3" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
+    <paraStyle name="P29" fontName="Times-Roman"/>
+    <paraStyle name="P30" fontName="Helvetica-Bold" fontSize="9.0" leading="11" alignment="RIGHT"/>
+    <paraStyle name="P31" fontName="Helvetica" fontSize="9.0" leading="11" alignment="RIGHT"/>
+    <paraStyle name="P32" fontName="Helvetica" fontSize="9.0" leading="11" alignment="RIGHT"/>
+    <paraStyle name="P33" fontName="Helvetica" fontSize="9.0" leading="11" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
+    <paraStyle name="P34" fontName="Helvetica" fontSize="9.0" leading="11" alignment="CENTER" spaceBefore="0.0" spaceAfter="0.0"/>
+    <paraStyle name="P35" fontName="Helvetica" fontSize="9.0" leading="11" alignment="CENTER" spaceBefore="0.0" spaceAfter="0.0"/>
+    <paraStyle name="P36" fontName="Helvetica" fontSize="9.0" leading="11" alignment="RIGHT" spaceBefore="0.0" spaceAfter="0.0"/>
+    <paraStyle name="P37" fontName="Helvetica-Oblique" fontSize="2.0" leading="3" alignment="LEFT" spaceBefore="0.0" spaceAfter="0.0"/>
+    <paraStyle name="P38" fontName="Helvetica" fontSize="9.0" leading="11" alignment="CENTER" spaceBefore="0.0" spaceAfter="0.0"/>
     <paraStyle name="Standard" fontName="Times-Roman"/>
     <paraStyle name="Text body" fontName="Times-Roman" spaceBefore="0.0" spaceAfter="6.0"/>
     <paraStyle name="Heading" fontName="Helvetica" fontSize="8.0" leading="10" spaceBefore="12.0" spaceAfter="6.0"/>
@@ -166,7 +164,7 @@
   </stylesheet>
   <images/>
   <story>
-    <para style="P11">[[ repeatIn(objects,'o') ]]</para>
+    <para style="P12">[[ repeatIn(objects,'o') ]]</para>
     <blockTable colWidths="265.0,51.0,225.0" style="Table1">
       <tr>
         <td>
@@ -180,12 +178,12 @@
           <para style="P3">
             <font color="white"> </font>
           </para>
-          <para style="P12">Invoice address :[[ o.partner_id and o.partner_id.property_payment_term.name ]]</para>
+          <para style="P13">Invoice address :[[ o.partner_id and o.partner_id.property_payment_term.name ]]</para>
           <para style="P3">[[ o.partner_invoice_id.street ]] [[ o.partner_invoice_id.street2 and (', %s' % o.partner_invoice_id.street2 or '') ]]</para>
           <para style="P3">[[ o.partner_invoice_id.zip or '' ]] [[ o.partner_invoice_id.city or '' ]] [[ o.partner_invoice_id.country_id and (', %s' % (o.partner_invoice_id.country_id and o.partner_invoice_id.country_id.name or '')) ]]</para>
         </td>
         <td>
-          <para style="P11">
+          <para style="P12">
             <font color="white"> </font>
           </para>
         </td>
@@ -210,94 +208,94 @@
         </td>
       </tr>
     </blockTable>
-    <para style="P11">
+    <para style="P12">
       <font color="white"> </font>
     </para>
-    <para style="P9">
-      <font color="white"> </font>
-    </para>
-    <para style="P7">[[ o.state&lt;&gt;'draft' and removeParentNode('para') ]]Repair Quotation <font face="Helvetica">N° : [[ o.name ]]</font></para>
-    <para style="P8">[[ o.state=='draft' and removeParentNode('para') ]]Repair Order N° : [[ o.name ]]</para>
     <para style="P10">
       <font color="white"> </font>
     </para>
-    <para style="P6">
+    <para style="P8">[[ o.state&lt;&gt;'draft' and removeParentNode('para') ]]Repair Quotation <font face="Helvetica">N° : [[ o.name ]]</font></para>
+    <para style="P9">[[ o.state=='draft' and removeParentNode('para') ]]Repair Order N° : [[ o.name ]]</para>
+    <para style="P11">
+      <font color="white"> </font>
+    </para>
+    <para style="P7">
       <font color="white"> </font>
     </para>
     <blockTable colWidths="130.0,136.0,136.0,136.0" style="Table2">
       <tr>
         <td>
-          <para style="P14">Product to Repair </para>
+          <para style="P15">Product to Repair </para>
         </td>
         <td>
-          <para style="P14">Lot Number</para>
+          <para style="P15">Lot Number</para>
         </td>
         <td>
-          <para style="P14">Guarantee Limit </para>
+          <para style="P15">Guarantee Limit </para>
         </td>
         <td>
-          <para style="P14">Printing Date</para>
+          <para style="P15">Printing Date</para>
         </td>
       </tr>
     </blockTable>
     <blockTable colWidths="130.0,136.0,136.0,136.0" style="Table3">
       <tr>
         <td>
-          <para style="P15">[[ o.product_id.name or '' ]]</para>
+          <para style="P16">[[ o.product_id.name or '' ]]</para>
         </td>
         <td>
-          <para style="P15">[[ o.prodlot_id.name or ' ' ]]</para>
+          <para style="P16">[[ o.prodlot_id.name or ' ' ]]</para>
         </td>
         <td>
-          <para style="P15">[[ time.strftime('%d/%m/%Y', time.strptime(o.guarantee_limit, '%Y-%m-%d')) ]]</para>
+          <para style="P16">[[ time.strftime('%d/%m/%Y', time.strptime(o.guarantee_limit, '%Y-%m-%d')) ]]</para>
         </td>
         <td>
-          <para style="P15">[[ time.strftime('%d/%m/%Y')]] </para>
+          <para style="P16">[[ time.strftime('%d/%m/%Y')]] </para>
         </td>
       </tr>
     </blockTable>
-    <para style="P11">
+    <para style="P12">
       <font color="white"> </font>
     </para>
-    <para style="P11">
+    <para style="P12">
       <font color="white"> </font>
     </para>
     <blockTable colWidths="165.0,165.0,71.0,70.0,64.0" repeatRows="1" style="Table4">
       <tr>
         <td>
-          <para style="P13">Description</para>
+          <para style="P14">Description</para>
         </td>
         <td>
-          <para style="P13">VAT</para>
+          <para style="P14">VAT</para>
         </td>
         <td>
-          <para style="P16">Quantity</para>
+          <para style="P17">Quantity</para>
         </td>
         <td>
-          <para style="P17">Unit Price</para>
+          <para style="P18">Unit Price</para>
         </td>
         <td>
-          <para style="P18">Price</para>
+          <para style="P19">Price</para>
         </td>
       </tr>
     </blockTable>
     <section>
-      <para style="P32"/>
-      <para style="P31">Operation Line(s)</para>
+      <para style="P28"/>
+      <para style="P27">Operation Line(s)</para>
       <blockTable colWidths="26.0,142.0,153.0,95.0,52.0,69.0" style="Table5">
         <tr>
           <td>
-            <para style="P4">[[ repeatIn(o.operations,'line') ]] </para> <para style="P4">Add [[ ((line.type == 'add') or removeParentNode('para')) and '' ]] </para>
+            <para style="P4"><font face="Times-Roman" size="2.0">[[ repeatIn(o.operations,'line') ]]</font>Add [[ ((line.type == 'add') or removeParentNode('para')) and '' ]] </para>
             <para style="P4">Remove [[ ((line.type == 'remove') or removeParentNode('para')) and '' ]]</para>
           </td>
           <td>
             <para style="P3">[[ line.name ]]</para>
           </td>
           <td>
-            <para style="P27">[[ ','.join(map( lambda x: x.name, line.tax_id)) or '0.00' ]]</para>
+            <para style="P6">[[ ','.join(map( lambda x: x.name, line.tax_id)) or '0.00' ]]</para>
           </td>
           <td>
-            <para style="P19">[[ line.product_uom_qty or '0.00' ]] [[ line.product_uom.name ]] </para>
+            <para style="P20">[[ line.product_uom_qty or '0.00' ]] [[ line.product_uom.name ]] </para>
           </td>
           <td>
             <para style="P1">[[ line.price_unit ]]</para>
@@ -308,23 +306,23 @@
         </tr>
       </blockTable>
     </section>
-    <para style="P26">Fees Line(s)</para>
-    <para style="P20">
+    <para style="P22">Fees Line(s)</para>
+    <para style="P21">
       <font color="white"> </font>
     </para>
     <blockTable colWidths="28.0,145.0,150.0,96.0,51.0,69.0" style="Table6">
       <tr>
         <td>
-          <para style="P20">[[ repeatIn(o.fees_lines,'fees') ]]</para>
+          <para style="P21">[[ repeatIn(o.fees_lines,'fees') ]]</para>
         </td>
         <td>
           <para style="P3">[[ fees.name ]]</para>
         </td>
         <td>
-          <para style="P27">[[ ','.join(map( lambda x: x.name, fees.tax_id)) or '0.00' ]]</para>
+          <para style="P6">[[ ','.join(map( lambda x: x.name, fees.tax_id)) or '0.00' ]]</para>
         </td>
         <td>
-          <para style="P19">[[ fees.product_uom_qty or '0.00' ]] [[ fees.product_uom.name ]] </para>
+          <para style="P20">[[ fees.product_uom_qty or '0.00' ]] [[ fees.product_uom.name ]] </para>
         </td>
         <td>
           <para style="P1">[[ fees.price_unit ]]</para>
@@ -334,55 +332,90 @@
         </td>
       </tr>
     </blockTable>
-    <para style="P24">
-      <font color="white"> </font>
-    </para>
-    <para style="P24">
-      <font color="white"> </font>
-    </para>
-    <blockTable colWidths="444.0,61.0,34.0" style="Table9">
+    <blockTable colWidths="90.0,90.0,221.0,57.0,54.0,28.0" style="Table7">
       <tr>
         <td>
-          <para style="P28">Net Total :</para>
+          <para style="Table Contents">
+            <font color="white"> </font>
+          </para>
         </td>
         <td>
-          <para style="P29">[[ o.amount_untaxed or '0.00' ]]</para>
+          <para style="Table Contents">
+            <font color="white"> </font>
+          </para>
         </td>
         <td>
-          <para style="P29">[[ o.pricelist_id.currency_id.name ]]</para>
+          <para style="Table Contents">
+            <font color="white"> </font>
+          </para>
+        </td>
+        <td>
+          <para style="P24">Net Total :</para>
+        </td>
+        <td>
+          <para style="P25">[[ o.amount_untaxed or '0.00' ]]</para>
+        </td>
+        <td>
+          <para style="P25">[[ o.pricelist_id.currency_id.name ]]</para>
+        </td>
+      </tr>
+      <tr>
+        <td>
+          <para style="Table Contents">
+            <font color="white"> </font>
+          </para>
+        </td>
+        <td>
+          <para style="Table Contents">
+            <font color="white"> </font>
+          </para>
+        </td>
+        <td>
+          <para style="Table Contents">
+            <font color="white"> </font>
+          </para>
+        </td>
+        <td>
+          <para style="P24">Taxes:</para>
+        </td>
+        <td>
+          <para style="P25">[[ o.amount_tax or '0.00']]</para>
+        </td>
+        <td>
+          <para style="P25">[[ o.pricelist_id.currency_id.name ]]</para>
+        </td>
+      </tr>
+      <tr>
+        <td>
+          <para style="Table Contents">
+            <font color="white"> </font>
+          </para>
+        </td>
+        <td>
+          <para style="Table Contents">
+            <font color="white"> </font>
+          </para>
+        </td>
+        <td>
+          <para style="Table Contents">
+            <font color="white"> </font>
+          </para>
+        </td>
+        <td>
+          <para style="P24">Total :</para>
+        </td>
+        <td>
+          <para style="P26">[[ total(o) ]]</para>
+        </td>
+        <td>
+          <para style="P25">[[ o.pricelist_id.currency_id.name ]]</para>
         </td>
       </tr>
     </blockTable>
-    <blockTable colWidths="444.0,61.0,34.0" style="Table10">
-      <tr>
-        <td>
-          <para style="P28">Taxes:</para>
-        </td>
-        <td>
-          <para style="P29">[[ o.amount_tax or '0.00']]</para>
-        </td>
-        <td>
-          <para style="P29">[[ o.pricelist_id.currency_id.name ]]</para>
-        </td>
-      </tr>
-    </blockTable>
-    <blockTable colWidths="444.0,61.0,34.0" style="Table11">
-      <tr>
-        <td>
-          <para style="P28">Total :</para>
-        </td>
-        <td>
-          <para style="P30">[[ total(o) ]]</para>
-        </td>
-        <td>
-          <para style="P29">[[ o.pricelist_id.currency_id.name ]]</para>
-        </td>
-      </tr>
-    </blockTable>
-    <para style="Standard">
+    <para style="P29">
       <font color="white"> </font>
     </para>
-    <para style="Standard">
+    <para style="P29">
       <font color="white"> </font>
     </para>
     <blockTable colWidths="534.0" style="Table8">
@@ -392,8 +425,6 @@
         </td>
       </tr>
     </blockTable>
-    <para style="P21">
-      <font color="white"> </font>
-    </para>
+    <para style="P23"/>
   </story>
 </document>
\ No newline at end of file

From ca3887a6e07fd946a4f83d4eb7ed8358dff59000 Mon Sep 17 00:00:00 2001
From: Husen Daudi <hda@tinyerp.com>
Date: Fri, 5 Dec 2008 10:56:39 +0530
Subject: [PATCH 02/24] Improve task view

bzr revid: hda@tinyerp.com-20081205052639-1uf4wm5kmp5hvpyc
---
 addons/project/project_view.xml             | 4 ++--
 addons/project/security/ir.model.access.csv | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/addons/project/project_view.xml b/addons/project/project_view.xml
index b7ec8362408..32c7ed49c27 100644
--- a/addons/project/project_view.xml
+++ b/addons/project/project_view.xml
@@ -210,7 +210,7 @@
                     <field name="remaining_hours" widget="float_time"/>
                     <group col="4" colspan="4">
                         <button icon="gtk-cancel" special="cancel" string="Cancel"/>
-                        <button icon="gtk-ok" name="compute_hours" string="Compute" type="object"/>
+                        <button icon="gtk-ok" name="compute_hours" string="Update" type="object"/>
                     </group>
                 </form>
             </field>
@@ -250,7 +250,7 @@
                             <field name="delay_hours" widget="float_time"/>
                             <group col="3" colspan="2">
 	                            <field name="remaining_hours" select="2" widget="float_time" attrs="{'readonly':[('state','!=','draft')]}" colspan="2"/>
-	                            <button name="%(action_config_compute_remaining)d" string="Compute" type="action" colspan="1" target="new"/>
+	                            <button name="%(action_config_compute_remaining)d" string="Review" type="action" colspan="1" target="new" attrs="{'invisible':[('state','=','draft')]}"/>
                             </group>
                             <field name="effective_hours" widget="float_time"/>
 
diff --git a/addons/project/security/ir.model.access.csv b/addons/project/security/ir.model.access.csv
index 40f5cfdb94b..1fe6bb56123 100644
--- a/addons/project/security/ir.model.access.csv
+++ b/addons/project/security/ir.model.access.csv
@@ -6,3 +6,4 @@
 "access_project_task_manager","project.task manager","model_project_task","project.group_project_manager",1,1,1,1
 "access_project_task","project.task","model_project_task","project.group_project_user",1,1,1,1
 "access_project_task_work","project.task.work","model_project_task_work","project.group_project_user",1,1,1,1
+"access_config_compute_remaining","project.config.compute.remaining","model_config_compute_remaining","project.group_project_manager",1,1,1,1

From 4c505f51aa77b7c86fa41dc4a79af17988b4e4ca Mon Sep 17 00:00:00 2001
From: Mustufa Rangwala <mra@tinyerp.com>
Date: Fri, 5 Dec 2008 14:57:33 +0530
Subject: [PATCH 03/24] base module quality

bzr revid: mra@tinyerp.com-20081205092733-60b9iki2gxtgiolp
---
 addons/base_module_merge/__init__.py          |  24 ++
 addons/base_module_merge/__terp__.py          |  44 +++
 .../base_module_merge_wizard.xml              |  20 ++
 addons/base_module_merge/wizard/__init__.py   |  25 ++
 .../wizard/base_module_merge.py               | 302 ++++++++++++++++++
 addons/base_module_quality/__init__.py        |   1 +
 addons/base_module_quality/__terp__.py        |   6 +-
 .../base_module_quality.py                    |  27 ++
 .../base_module_quality_view.xml              |   0
 .../base_module_quality_wizard.xml            |   6 +
 addons/base_module_quality/wizard/__init__.py |  27 ++
 .../wizard/module_quality_check.py            |  85 +++++
 .../wizard/pylint_test/__init__.py            |  25 ++
 .../wizard/pylint_test/pylint_test.py         | 162 ++++++++++
 14 files changed, 751 insertions(+), 3 deletions(-)
 create mode 100644 addons/base_module_merge/__init__.py
 create mode 100644 addons/base_module_merge/__terp__.py
 create mode 100644 addons/base_module_merge/base_module_merge_wizard.xml
 create mode 100644 addons/base_module_merge/wizard/__init__.py
 create mode 100644 addons/base_module_merge/wizard/base_module_merge.py
 delete mode 100644 addons/base_module_quality/base_module_quality_view.xml
 create mode 100644 addons/base_module_quality/base_module_quality_wizard.xml
 create mode 100644 addons/base_module_quality/wizard/__init__.py
 create mode 100644 addons/base_module_quality/wizard/module_quality_check.py
 create mode 100644 addons/base_module_quality/wizard/pylint_test/__init__.py
 create mode 100644 addons/base_module_quality/wizard/pylint_test/pylint_test.py

diff --git a/addons/base_module_merge/__init__.py b/addons/base_module_merge/__init__.py
new file mode 100644
index 00000000000..8b433928f46
--- /dev/null
+++ b/addons/base_module_merge/__init__.py
@@ -0,0 +1,24 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution	
+#    Copyright (C) 2004-2008 Tiny SPRL (<http://tiny.be>). All Rights Reserved
+#    $Id$
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU General Public License as published by
+#    the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU General Public License for more details.
+#
+#    You should have received a copy of the GNU General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+import wizard
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
+
diff --git a/addons/base_module_merge/__terp__.py b/addons/base_module_merge/__terp__.py
new file mode 100644
index 00000000000..aa912d04f99
--- /dev/null
+++ b/addons/base_module_merge/__terp__.py
@@ -0,0 +1,44 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution	
+#    Copyright (C) 2004-2008 Tiny SPRL (<http://tiny.be>). All Rights Reserved
+#    $Id$
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU General Public License as published by
+#    the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU General Public License for more details.
+#
+#    You should have received a copy of the GNU General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+{
+    "name" : "Module Merger",
+    "version" : "1.0",
+    "author" : "Tiny",
+    "website" : "http://tinyerp.com",
+    "category" : "Generic Modules/Base",
+    "description": """
+    * The wizard asks a many2many of modules
+    * And then generate a module which is the merge of all selected modules
+    * The new module is provided as a .zip file
+
+    The merge will works in all situations:
+    * Merging all .py files with the same name in the new module
+    * merging all .xml files and take care of id's.
+    """,
+    "depends" : ["base"],
+    "init_xml" : [ ],
+    "demo_xml" : [ ],
+    "update_xml" : [ "base_module_merge_wizard.xml" ],
+    "installable": True
+}
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
+
diff --git a/addons/base_module_merge/base_module_merge_wizard.xml b/addons/base_module_merge/base_module_merge_wizard.xml
new file mode 100644
index 00000000000..d9bf8755acb
--- /dev/null
+++ b/addons/base_module_merge/base_module_merge_wizard.xml
@@ -0,0 +1,20 @@
+<?xml version="1.0"?>
+<openerp>
+	<data>
+		<wizard
+			id="wizard_base_module_merger"
+			string="Merge module"
+			model="ir.module.module"
+			multi="True"
+			name="base_module_merge.module_merge"/>
+
+		
+		<menuitem
+			parent="base.menu_management"
+			type="wizard"
+			action="wizard_base_module_merger"
+			id="menu_wizard_base_module_merger"/>
+
+
+	</data>
+</openerp>
diff --git a/addons/base_module_merge/wizard/__init__.py b/addons/base_module_merge/wizard/__init__.py
new file mode 100644
index 00000000000..6b33adb9c66
--- /dev/null
+++ b/addons/base_module_merge/wizard/__init__.py
@@ -0,0 +1,25 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution	
+#    Copyright (C) 2004-2008 Tiny SPRL (<http://tiny.be>). All Rights Reserved
+#    $Id$
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU General Public License as published by
+#    the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU General Public License for more details.
+#
+#    You should have received a copy of the GNU General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import base_module_merge
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
+
diff --git a/addons/base_module_merge/wizard/base_module_merge.py b/addons/base_module_merge/wizard/base_module_merge.py
new file mode 100644
index 00000000000..5e474b94fae
--- /dev/null
+++ b/addons/base_module_merge/wizard/base_module_merge.py
@@ -0,0 +1,302 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution	
+#    Copyright (C) 2004-2008 Tiny SPRL (<http://tiny.be>). All Rights Reserved
+#    $Id$
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU General Public License as published by
+#    the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU General Public License for more details.
+#
+#    You should have received a copy of the GNU General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import wizard
+import osv
+import pooler
+import tools
+import os
+from xml.dom import minidom
+
+info_start_form = '''<?xml version="1.0"?>
+<form string="Module Merging">
+    <field name="modules_list" colspan="4"/>
+</form>'''
+
+info_start_fields = {
+    'modules_list': {'string':'Modules', 'type':'many2many','relation':'ir.module.module','help':'Select Modules which you want to merge in single module'},
+}
+
+
+intro_start_form = '''<?xml version="1.0"?>
+<form string="Module Recording">
+    <separator string="Module Information" colspan="4"/>
+    <field name="name"/>
+    <field name="directory_name"/>
+    <field name="version"/>
+    <field name="author"/>
+    <field name="website" colspan="4"/>
+    <field name="category" colspan="4"/>
+    <field name="data_kind"/>
+    <newline/>
+    <field name="description" colspan="4"/>
+</form>'''
+
+intro_start_fields = {
+    'name': {'string':'Module Name', 'type':'char', 'size':64, 'required':True},
+    'directory_name': {'string':'Directory Name', 'type':'char', 'size':32, 'required':True},
+    'version': {'string':'Version', 'type':'char', 'size':16, 'required':True},
+    'author': {'string':'Author', 'type':'char', 'size':64, 'default': lambda *args: 'Tiny', 'required':True},
+    'category': {'string':'Category', 'type':'char', 'size':64, 'default': lambda *args: 'Vertical Modules/Parametrization', 'required':True},
+    'website': {'string':'Documentation URL', 'type':'char', 'size':64, 'default': lambda *args: 'http://tinyerp.com', 'required':True},
+    'description': {'string':'Full Description', 'type':'text', 'required':True},
+    'data_kind': {'string':'Type of Data', 'type':'selection', 'selection':[('demo','Demo Data'),('update','Normal Data')], 'required':True, 'default': lambda *args:'update'},
+}
+
+intro_save_form = '''<?xml version="1.0"?>
+<form string="Module Recording">
+    <separator string="Module successfully created !" colspan="4"/>
+    <field name="module_filename"/>
+    <newline/>
+    <field name="module_file"/>
+    <separator string="Information" colspan="4"/>
+    <label string="If you think your module could interrest others people, we'd like you to publish it on TinyERP.com, in the 'Modules' section. You can do it through the website or using features of the 'base_module_publish' module." colspan="4" align="0.0"/>
+    <label string="Thanks in advance for your contribution." colspan="4" align="0.0"/>
+</form>'''
+
+intro_save_fields = {
+    'module_file': {'string': 'Module .zip File', 'type':'binary', 'readonly':True},
+    'module_filename': {'string': 'Filename', 'type':'char', 'size': 64, 'readonly':True},
+}
+import zipfile
+from zipfile import PyZipFile, ZIP_DEFLATED
+import StringIO
+import base64
+
+class base_module_merge(wizard.interface):
+
+    def _zip_writestr(self,file_name,data):
+        info = zipfile.ZipInfo(file_name)
+        info.compress_type = zipfile.ZIP_DEFLATED
+        info.external_attr = 2175008768
+        self.archive.writestr(info,data)
+        return True
+
+    def _remove_prefix_ref(self,fromurl,path):
+        infile=tools.file_open(os.path.join(fromurl,path))
+        xml=infile.read()
+        mydom = minidom.parseString(xml)
+        for child in mydom.getElementsByTagName("field"):
+            for attr in child.attributes.keys():
+                if attr=='ref':
+                    old=child.getAttribute(attr)
+                    if len(old.split('.')) > 1:
+                        if old.split('.')[0] in self.dependencies:
+                            child.setAttribute(attr,old.split('.')[1])
+        return mydom.toxml()
+
+    def _parse_init(self,path,filename):
+        res=[]
+        path=os.path.join(path,filename)
+        infile=open(path,'r')
+        for i in infile:
+            i=i.strip()
+            if len(i)>0:
+                if i[0]!="#":
+                    res.append( i.strip().split('\n')[0])
+        infile.close()
+        return res
+
+    def _zippy(self,archive, fromurl, path, src=True):
+        if path!='':
+            url = os.path.join(fromurl, path)
+        else:
+            url=fromurl
+        if os.path.isdir(url):
+            if path.split('/')[-1].startswith('.'):
+                return False
+            for fname in os.listdir(url):
+                self._zippy(self.archive, fromurl, path and os.path.join(path, fname) or fname, src=src)
+        else:
+            if src:
+                exclude = ['pyo', 'pyc']
+            else:
+                exclude = ['py','pyo','pyc']
+            if (path.split('.')[-1] not in exclude):
+                if os.path.basename(path)=='__init__.py':
+                    datas=self._parse_init(fromurl,path)
+                    if path in self.dict_init:
+                        self.dict_init[path]+=datas
+                    else:
+                        self.dict_init[path]=datas
+                    return True
+                if os.path.basename(path)=='__terp__.py':
+                    terp_file=os.path.join(fromurl,path)
+                    terp_info=eval(tools.file_open(terp_file).read())
+                    self.init_xml+=terp_info['init_xml']
+                    self.demo_xml+=terp_info['demo_xml']
+                    self.update_xml+=terp_info['update_xml']
+                    return True
+                try:
+                    info = self.archive.getinfo(path)
+                except KeyError:
+                    if path.split('.')[-1] == 'xml':
+                        xml_doc=self._remove_prefix_ref(fromurl,path)
+                        xml_doc = xml_doc.encode("utf-8")
+                        self._zip_writestr(path, xml_doc)
+                    else:
+                        file_data=tools.file_open(os.path.join(fromurl, path)).read()
+                        self._zip_writestr(path, file_data)
+                else:
+                    path2=os.path.split(fromurl)[-1]
+                    new_path=path2+'_'+os.path.split(path)[-1]
+                    if len(os.path.split(path))>1:
+                        new_path=os.path.join(os.path.split(path)[0],new_path)
+                    if path.split('.')[-1] == 'xml':
+                        xml_doc=self._remove_prefix_ref(fromurl,path)
+                        xml_doc = xml_doc.encode("utf-8")
+                        self._zip_writestr(new_path, xml_doc)
+                        if len(os.path.split(path))>1:
+                            terp_file=os.path.join(fromurl,'__terp__.py')
+                            terp_info=eval(tools.file_open(terp_file).read())
+                            if os.path.basename(path) in terp_info['init_xml']:
+                                print "in init_xml",new_path
+                                self.init_xml+=[os.path.basename(new_path)]
+                            elif os.path.basename(path) in terp_info['demo_xml']:
+                                print "in demo_xml",new_path
+                                self.demo_xml+=[os.path.basename(new_path)]
+                            elif os.path.basename(path) in terp_info['update_xml']:
+                                print "in update_xml",new_path
+                                self.update_xml+=[os.path.basename(new_path)]
+                    else:
+                        file_data=tools.file_open(os.path.join(fromurl, path)).read()
+                        self._zip_writestr(new_path, file_data)
+                    if new_path.split('.')[-1] == 'py':
+                        new_import='import '+os.path.basename(new_path).split('.')[0]
+                        if os.path.dirname(path)=='':
+                            dict_key='__init__.py'
+                        else:
+                            dict_key=os.path.join(os.path.dirname(path),'__init__.py')
+                        if dict_key in self.dict_init:
+                            self.dict_init[dict_key]+=[new_import]
+                        else:
+                            self.dict_init[dict_key]=[new_import]
+        return True
+
+    def rec_depend(self,cr, uid, ids, data, context=None, level=50):
+        pool = pooler.get_pool(cr.dbname)
+        dep_obj=pool.get('ir.module.module.dependency')
+        if level<1:
+            raise Exception, 'Recursion error in modules dependencies !'
+        for module in pool.get('ir.module.module').browse(cr, uid, ids):
+            dep_ids = dep_obj.search(cr, uid, [('module_id', '=', module.id)])
+            if dep_ids:
+                ids2 = []
+                for dep in dep_obj.browse(cr, uid, dep_ids):
+                    dep_name=pool.get('ir.module.module').search(cr, uid, [('name','=',dep.name)])
+                    ids2.append(dep_name[0])
+                self.rec_depend(cr, uid, ids2, data, context, level-1)
+            if module.name not in data['form']['dependencies']:
+                data['form']['dependencies'].append(module.name)
+        return True
+
+    def _compute_dependencies(self, cr, uid, data, context):
+        data['form']['dependencies']=[]
+        self.rec_depend(cr,uid,data['form']['modules_list'][0][2],data,context)
+        self.dependencies=data['form']['dependencies']
+        pool = pooler.get_pool(cr.dbname)
+        return {}
+
+    def _create_module(self, cr, uid, data, context):
+        self.dict_init={}
+        self.init_xml=[]
+        self.demo_xml=[]
+        self.update_xml=[]
+        self.archname = StringIO.StringIO('wb')
+        self.archive = zipfile.ZipFile(self.archname, "w", ZIP_DEFLATED)
+        for module in self.dependencies:
+            ad = tools.config['addons_path']
+            url = os.path.join(ad, module)
+            if not os.path.isdir(url):
+                url=url+'.zip'
+            self._zippy(self.archive, url, '', src=True)
+        dname = data['form']['directory_name']
+        data['form']['depen']=[]
+
+        data['form']['init_xml']=reduce(lambda l, x: x not in l and l.append(x) or l, self.init_xml, [])
+        data['form']['demo_xml']=reduce(lambda l, x: x not in l and l.append(x) or l, self.demo_xml, [])
+        data['form']['update_xml']=reduce(lambda l, x: x not in l and l.append(x) or l, self.update_xml, [])
+        _terp = """{
+            "name" : "%(name)s",
+            "version" : "%(version)s",
+            "author" : "%(author)s",
+            "website" : "%(website)s",
+            "category" : "%(category)s",
+            "description":\"\"\"%(description)s\"\"\",
+            "depends" : %(depen)s,
+            "init_xml" : %(init_xml)s,
+            "demo_xml" : %(demo_xml)s,
+            "update_xml" : %(update_xml)s,
+            "active": True,
+            "installable": True
+    } """ % data['form']
+        for name,datastr in self.dict_init.items():
+            self.dict_init[name]=reduce(lambda l, x: x not in l and l.append(x) or l, self.dict_init[name], [])
+            init_data='\n'.join(self.dict_init[name])
+            self._zip_writestr(name, init_data)
+        self._zip_writestr('__terp__.py', _terp)
+        self.archive.close()
+        return {
+            'module_file': base64.encodestring(self.archname.getvalue()),
+            'module_filename': data['form']['directory_name']+'-'+data['form']['version']+'.zip'
+        }
+
+    states = {
+        'init': {
+            'actions': [],
+            'result': {
+                'type':'form',
+                'arch':info_start_form,
+                'fields': info_start_fields,
+                'state':[
+                    ('end', 'Cancel', 'gtk-cancel'),
+                    ('info', 'Continue', 'gtk-ok'),
+                ]
+            }
+        },
+        'info': {
+            'actions': [_compute_dependencies],
+            'result': {
+                'type':'form',
+                'arch':intro_start_form,
+                'fields': intro_start_fields,
+                'state':[
+                    ('end', 'Cancel', 'gtk-cancel'),
+                    ('save', 'Continue', 'gtk-ok'),
+                ]
+            }
+        },
+        'save': {
+            'actions': [_create_module],
+            'result': {
+                'type':'form',
+                'arch':intro_save_form,
+                'fields': intro_save_fields,
+                'state':[
+                    ('end', 'Close', 'gtk-ok'),
+                ]
+            }
+        }
+    }
+base_module_merge('base_module_merge.module_merge')
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
+
diff --git a/addons/base_module_quality/__init__.py b/addons/base_module_quality/__init__.py
index 18f7cbc52c4..b5ad29991f8 100644
--- a/addons/base_module_quality/__init__.py
+++ b/addons/base_module_quality/__init__.py
@@ -21,6 +21,7 @@
 ##############################################################################
 
 import base_module_quality
+import wizard
 
 
 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
diff --git a/addons/base_module_quality/__terp__.py b/addons/base_module_quality/__terp__.py
index ced15f682bd..f80077e2b94 100644
--- a/addons/base_module_quality/__terp__.py
+++ b/addons/base_module_quality/__terp__.py
@@ -23,13 +23,13 @@
     "name" : "Base module quality",
     "author" : "Tiny",
     "version" : "1.0",
-    "depends" : ["base", "product"],
+    "depends" : ["base",],
     "description": "Sample module to check the quality",
     "init_xml" : [],
-    "update_xml" : ["base_module_quality_view.xml"],
+    "update_xml" : ["base_module_quality_wizard.xml"],
     "category" : "Tiny Specific Modules/Base module quality",
     "active": False,
-    "installable": False
+    "installable": True
 }
 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
 
diff --git a/addons/base_module_quality/base_module_quality.py b/addons/base_module_quality/base_module_quality.py
index e69de29bb2d..ab46c3b44be 100644
--- a/addons/base_module_quality/base_module_quality.py
+++ b/addons/base_module_quality/base_module_quality.py
@@ -0,0 +1,27 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2004-2008 Tiny SPRL (<http://tiny.be>). All Rights Reserved
+#    $Id$
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU General Public License as published by
+#    the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU General Public License for more details.
+#
+#    You should have received a copy of the GNU General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import netsvc
+from osv import fields, osv
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
+
diff --git a/addons/base_module_quality/base_module_quality_view.xml b/addons/base_module_quality/base_module_quality_view.xml
deleted file mode 100644
index e69de29bb2d..00000000000
diff --git a/addons/base_module_quality/base_module_quality_wizard.xml b/addons/base_module_quality/base_module_quality_wizard.xml
new file mode 100644
index 00000000000..be0048feb80
--- /dev/null
+++ b/addons/base_module_quality/base_module_quality_wizard.xml
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+    <data>
+		<wizard id="base_module_quality" model="ir.module.module" name="base.module.quality" string="Check the Quality of module"/>
+    </data>
+</openerp>
\ No newline at end of file
diff --git a/addons/base_module_quality/wizard/__init__.py b/addons/base_module_quality/wizard/__init__.py
new file mode 100644
index 00000000000..a8454f95f3f
--- /dev/null
+++ b/addons/base_module_quality/wizard/__init__.py
@@ -0,0 +1,27 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2004-2008 Tiny SPRL (<http://tiny.be>). All Rights Reserved
+#    $Id$
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU General Public License as published by
+#    the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU General Public License for more details.
+#
+#    You should have received a copy of the GNU General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import module_quality_check
+
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
+
diff --git a/addons/base_module_quality/wizard/module_quality_check.py b/addons/base_module_quality/wizard/module_quality_check.py
new file mode 100644
index 00000000000..648b24366f6
--- /dev/null
+++ b/addons/base_module_quality/wizard/module_quality_check.py
@@ -0,0 +1,85 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2004-2008 Tiny SPRL (<http://tiny.be>). All Rights Reserved
+#    $Id$
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU General Public License as published by
+#    the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU General Public License for more details.
+#
+#    You should have received a copy of the GNU General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+import wizard
+import pooler
+import osv
+import netsvc
+
+import sys
+import tools
+import os
+import pylint
+
+form_check = '''<?xml version="1.0"?>
+<form string="Quality check">
+    <field name="test" />
+</form>'''
+
+fields_check = {
+    'test': {
+        'string':'Tests', 'type':'selection', 'size':64, 'required':True,
+        'selection': [('pylint', 'Pylint'), ('othertest','other')],
+        'default': lambda *args: 'pylint'
+    },
+    }
+view_form = """<?xml version="1.0"?>
+<form string="Check quality">
+    <group colspan="2" col="4">
+        <field name="module_info" nolabel="1" colspan="4"/>
+    </group>
+</form>"""
+
+view_field = {
+    "module_info": {'type': 'text', 'string': 'check quality',
+        'readonly': True,},
+}
+
+class wiz_quality_check(wizard.interface):
+
+    def _check(self, cr, uid, data, context):
+        if data['form']['test'] == 'pylint':
+            pool=pooler.get_pool(cr.dbname)
+            module_data = pool.get('ir.module.module').browse(cr, uid, data['ids'])
+            from pylint_test import pylint_test
+            ad = tools.config['addons_path']
+            url = os.path.join(ad, module_data[0].name)
+            result = pylint_test._test_pylint(self, url)
+            string_ret = ''
+            for i in result:
+                string_ret = string_ret + i + ':\n' + result[i]
+
+        return {'module_info':string_ret}
+    states = {
+        'init': {
+            'actions': [],
+            'result': {'type':'form', 'arch':form_check, 'fields':fields_check, 'state':[('end','Cancel'),('do','Do Test')]}
+        },
+        'do': {
+            'actions': [_check],
+            'result': {'type':'form', 'arch':view_form, 'fields':view_field, 'state':[('end','Ok')]},
+        },
+
+    }
+wiz_quality_check('base.module.quality')
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
+
diff --git a/addons/base_module_quality/wizard/pylint_test/__init__.py b/addons/base_module_quality/wizard/pylint_test/__init__.py
new file mode 100644
index 00000000000..79bc02a75a6
--- /dev/null
+++ b/addons/base_module_quality/wizard/pylint_test/__init__.py
@@ -0,0 +1,25 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2004-2008 Tiny SPRL (<http://tiny.be>). All Rights Reserved
+#    $Id$
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU General Public License as published by
+#    the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU General Public License for more details.
+#
+#    You should have received a copy of the GNU General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import pylint_test
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
+
diff --git a/addons/base_module_quality/wizard/pylint_test/pylint_test.py b/addons/base_module_quality/wizard/pylint_test/pylint_test.py
new file mode 100644
index 00000000000..73e72307d29
--- /dev/null
+++ b/addons/base_module_quality/wizard/pylint_test/pylint_test.py
@@ -0,0 +1,162 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2004-2008 Tiny SPRL (<http://tiny.be>). All Rights Reserved
+#    $Id$
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU General Public License as published by
+#    the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU General Public License for more details.
+#
+#    You should have received a copy of the GNU General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import netsvc
+from osv import fields, osv
+import os
+
+def _test_pylint(self, url):
+    list_files = os.listdir(url)
+    dict_files = {}
+    for file in list_files:
+        if file.split('.')[-1] == 'py':
+            save_file = file.split('.')[0]+".txt"
+            file_path = os.path.join(url, file)
+            a1 = os.system('pylint '+file_path+'>> '+save_file+' ')
+            a2 = os.system('cat '+save_file+' | tail -4 >> temp.txt')
+            fp = open('temp.txt','r')
+            result = fp.read()
+            fp.close()
+            str_result = ''
+            try:
+                for line in result:
+                    str_result = str_result + line
+            finally:
+                fp = open('temp.txt','w')
+                fp.write('')
+                fp.close()
+            if str_result.startswith('Global'):
+                dict_files[file] = str_result
+    return dict_files
+#
+#class res_partner_contact(osv.osv):
+#    _name = "res.partner.contact"
+#    _description = "res.partner.contact"
+#
+#    def _title_get(self,cr, user, context={}):
+#        obj = self.pool.get('res.partner.title')
+#        ids = obj.search(cr, user, [])
+#        res = obj.read(cr, user, ids, ['shortcut', 'name','domain'], context)
+#        res = [(r['shortcut'], r['name']) for r in res if r['domain']=='contact']
+#        return res
+#
+#    _columns = {
+#        'name': fields.char('Last Name', size=30,required=True),
+#        'first_name': fields.char('First Name', size=30),
+#        'mobile':fields.char('Mobile',size=30),
+#        'title': fields.selection(_title_get, 'Title'),
+#        'website':fields.char('Website',size=120),
+#        'lang_id':fields.many2one('res.lang','Language'),
+#        'job_ids':fields.one2many('res.partner.job','contact_id','Functions and Addresses'),
+#        'country_id':fields.many2one('res.country','Nationality'),
+#        'birthdate':fields.date('Birth Date'),
+#        'active' : fields.boolean('Active'),
+#        'partner_id':fields.related('job_ids','address_id','partner_id',type='many2one', relation='res.partner', string='Main Employer'),
+#        'function_id':fields.related('job_ids','function_id',type='many2one', relation='res.partner.function', string='Main Job'),
+#    }
+#    _defaults = {
+#        'active' : lambda *a: True,
+#    }
+#    def name_get(self, cr, user, ids, context={}):
+#        #will return name and first_name.......
+#        if not len(ids):
+#            return []
+#        res = []
+#        for r in self.read(cr, user, ids, ['name','first_name','title']):
+#            addr = r['title'] and str(r['title'])+" " or ''
+#            addr +=str(r['name'] or '')
+#            if r['name'] and r['first_name']:
+#                addr += ' '
+#            addr += str(r['first_name'] or '')
+#            res.append((r['id'], addr))
+#        return res
+#res_partner_contact()
+#
+#class res_partner_address(osv.osv):
+#
+#    #overriding of the name_get defined in base in order to remove the old contact name
+#    def name_get(self, cr, user, ids, context={}):
+#        if not len(ids):
+#            return []
+#        res = []
+#        for r in self.read(cr, user, ids, ['zip','city','partner_id', 'street']):
+#            if context.get('contact_display', 'contact')=='partner':
+#                res.append((r['id'], r['partner_id'][1]))
+#            else:
+#                addr = str('')
+#                addr += str(r['street'] or '') + ' ' + str(r['zip'] or '') + ' ' + str(r['city'] or '')
+#                res.append((r['id'], addr.strip() or '/'))
+#        return res
+#
+#    _name = 'res.partner.address'
+#    _inherit='res.partner.address'
+#    _description ='Partner Address'
+#    _columns = {
+#        'job_ids':fields.one2many('res.partner.job', 'address_id', 'Contacts'),
+#    }
+#res_partner_address()
+#
+#class res_partner_job(osv.osv):
+#
+#    def name_get(self, cr, uid, ids, context={}):
+#        if not len(ids):
+#            return []
+#        res = []
+#        for r in self.browse(cr, uid, ids):
+#            res.append((r.id, self.pool.get('res.partner.contact').name_get(cr, uid, [r.contact_id.id])[0][1] +", "+ r.function_id.name))
+#        return res
+#
+#    def search(self, cr, user, args, offset=0, limit=None, order=None,
+#            context=None, count=False):
+#        for arg in args:
+#            if arg[0]=='address_id':
+#                self._order = 'sequence_partner'
+#            if arg[0]=='contact_id':
+#                self._order = 'sequence_contact'
+#        return super(res_partner_job,self).search(cr, user, args, offset, limit, order, context, count)
+#
+#    _name = 'res.partner.job'
+#    _description ='Contact Job Title'
+#    _order = 'sequence_contact'
+#    _columns = {
+#        'name': fields.related('address_id','partner_id', type='many2one', relation='res.partner', string='Partner'),
+#        'address_id':fields.many2one('res.partner.address','Address'),
+#        'contact_id':fields.many2one('res.partner.contact','Contact', required=True, ondelete='cascade'),
+#        'function_id': fields.many2one('res.partner.function','Job Title'),
+#        'sequence_contact':fields.integer('Sequence',help='Order of importance of this address in the list of addresses of the linked contact'),
+#        'sequence_partner':fields.integer('Sequence',help='Order of importance of this job title in the list of job title of the linked partner'),
+#        'email': fields.char('E-Mail', size=240),
+#        'phone': fields.char('Phone', size=64),
+#        'date_start' : fields.date('Date Start'),
+#        'date_stop' : fields.date('Date Stop'),
+#        'state' : fields.selection([('past', 'Past'),('current', 'Current')], 'State', required=True),
+#    }
+#
+#    _defaults = {
+#        'sequence_contact' : lambda *a: 0,
+#        'state' : lambda *a: 'current',
+#    }
+#res_partner_job()
+
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
+

From a50a5b7d9e75aa2a50cfec954d5d6f9d3ce7db8f Mon Sep 17 00:00:00 2001
From: Fabien Pinckaers <fp@tinyerp.com>
Date: Fri, 5 Dec 2008 11:47:16 +0100
Subject: [PATCH 04/24] improved_ref

bzr revid: fp@tinyerp.com-20081205104716-p5rjhm9y0oq13d69
---
 addons/purchase/purchase.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/addons/purchase/purchase.py b/addons/purchase/purchase.py
index 942c3f960d9..d13901574e5 100644
--- a/addons/purchase/purchase.py
+++ b/addons/purchase/purchase.py
@@ -466,7 +466,9 @@ class purchase_order_line(osv.osv):
                     'date': date_order,
                     })[pricelist]
         dt = (DateTime.now() + DateTime.RelativeDateTime(days=prod['seller_delay'] or 0.0)).strftime('%Y-%m-%d %H:%M:%S')
-        prod_name = self.pool.get('product.product').name_get(cr, uid, [product], context=context)[0][1]
+        context['partner_id'] = partner_id
+        prod_name = self.pool.get('product.product').browse(cr, uid,product, context=context).partner_ref
+
 
         res = {'value': {'price_unit': price, 'name':prod_name, 'taxes_id':prod['supplier_taxes_id'], 'date_planned': dt,'notes':prod['description_purchase'], 'product_uom': uom}}
         domain = {}

From 638ee7ffea55fdf6b0d762f63dfeccdf681b964d Mon Sep 17 00:00:00 2001
From: Mustufa Rangwala <mra@tinyerp.com>
Date: Fri, 5 Dec 2008 16:28:19 +0530
Subject: [PATCH 05/24] base_module_qualtiy modifs

bzr revid: mra@tinyerp.com-20081205105819-2bsfctoovewgvuxa
---
 .../wizard/pylint_test/pylint_test.py         | 125 +++---------------
 1 file changed, 15 insertions(+), 110 deletions(-)

diff --git a/addons/base_module_quality/wizard/pylint_test/pylint_test.py b/addons/base_module_quality/wizard/pylint_test/pylint_test.py
index 73e72307d29..7a990992257 100644
--- a/addons/base_module_quality/wizard/pylint_test/pylint_test.py
+++ b/addons/base_module_quality/wizard/pylint_test/pylint_test.py
@@ -24,8 +24,16 @@ import netsvc
 from osv import fields, osv
 import os
 
-def _test_pylint(self, url):
+def _test_pylint(self, url, add_folder=None):
     list_files = os.listdir(url)
+    new_list = []
+    subfolder = {}
+    for i in list_files:
+        if os.path.isdir(i):
+            path = os.path.join(url, i)
+            new_list.append(os.listdir(path))
+            res = _test_pylint(self, path, add_folder=i)
+            subfolder.update(res)
     dict_files = {}
     for file in list_files:
         if file.split('.')[-1] == 'py':
@@ -45,117 +53,14 @@ def _test_pylint(self, url):
                 fp.write('')
                 fp.close()
             if str_result.startswith('Global'):
-                dict_files[file] = str_result
+                if add_folder:
+                    dict_files[add_folder + '/' + file] = str_result
+                else:
+                    dict_files[file] = str_result
+    dict_files.update(subfolder)
     return dict_files
+
 #
-#class res_partner_contact(osv.osv):
-#    _name = "res.partner.contact"
-#    _description = "res.partner.contact"
-#
-#    def _title_get(self,cr, user, context={}):
-#        obj = self.pool.get('res.partner.title')
-#        ids = obj.search(cr, user, [])
-#        res = obj.read(cr, user, ids, ['shortcut', 'name','domain'], context)
-#        res = [(r['shortcut'], r['name']) for r in res if r['domain']=='contact']
-#        return res
-#
-#    _columns = {
-#        'name': fields.char('Last Name', size=30,required=True),
-#        'first_name': fields.char('First Name', size=30),
-#        'mobile':fields.char('Mobile',size=30),
-#        'title': fields.selection(_title_get, 'Title'),
-#        'website':fields.char('Website',size=120),
-#        'lang_id':fields.many2one('res.lang','Language'),
-#        'job_ids':fields.one2many('res.partner.job','contact_id','Functions and Addresses'),
-#        'country_id':fields.many2one('res.country','Nationality'),
-#        'birthdate':fields.date('Birth Date'),
-#        'active' : fields.boolean('Active'),
-#        'partner_id':fields.related('job_ids','address_id','partner_id',type='many2one', relation='res.partner', string='Main Employer'),
-#        'function_id':fields.related('job_ids','function_id',type='many2one', relation='res.partner.function', string='Main Job'),
-#    }
-#    _defaults = {
-#        'active' : lambda *a: True,
-#    }
-#    def name_get(self, cr, user, ids, context={}):
-#        #will return name and first_name.......
-#        if not len(ids):
-#            return []
-#        res = []
-#        for r in self.read(cr, user, ids, ['name','first_name','title']):
-#            addr = r['title'] and str(r['title'])+" " or ''
-#            addr +=str(r['name'] or '')
-#            if r['name'] and r['first_name']:
-#                addr += ' '
-#            addr += str(r['first_name'] or '')
-#            res.append((r['id'], addr))
-#        return res
-#res_partner_contact()
-#
-#class res_partner_address(osv.osv):
-#
-#    #overriding of the name_get defined in base in order to remove the old contact name
-#    def name_get(self, cr, user, ids, context={}):
-#        if not len(ids):
-#            return []
-#        res = []
-#        for r in self.read(cr, user, ids, ['zip','city','partner_id', 'street']):
-#            if context.get('contact_display', 'contact')=='partner':
-#                res.append((r['id'], r['partner_id'][1]))
-#            else:
-#                addr = str('')
-#                addr += str(r['street'] or '') + ' ' + str(r['zip'] or '') + ' ' + str(r['city'] or '')
-#                res.append((r['id'], addr.strip() or '/'))
-#        return res
-#
-#    _name = 'res.partner.address'
-#    _inherit='res.partner.address'
-#    _description ='Partner Address'
-#    _columns = {
-#        'job_ids':fields.one2many('res.partner.job', 'address_id', 'Contacts'),
-#    }
-#res_partner_address()
-#
-#class res_partner_job(osv.osv):
-#
-#    def name_get(self, cr, uid, ids, context={}):
-#        if not len(ids):
-#            return []
-#        res = []
-#        for r in self.browse(cr, uid, ids):
-#            res.append((r.id, self.pool.get('res.partner.contact').name_get(cr, uid, [r.contact_id.id])[0][1] +", "+ r.function_id.name))
-#        return res
-#
-#    def search(self, cr, user, args, offset=0, limit=None, order=None,
-#            context=None, count=False):
-#        for arg in args:
-#            if arg[0]=='address_id':
-#                self._order = 'sequence_partner'
-#            if arg[0]=='contact_id':
-#                self._order = 'sequence_contact'
-#        return super(res_partner_job,self).search(cr, user, args, offset, limit, order, context, count)
-#
-#    _name = 'res.partner.job'
-#    _description ='Contact Job Title'
-#    _order = 'sequence_contact'
-#    _columns = {
-#        'name': fields.related('address_id','partner_id', type='many2one', relation='res.partner', string='Partner'),
-#        'address_id':fields.many2one('res.partner.address','Address'),
-#        'contact_id':fields.many2one('res.partner.contact','Contact', required=True, ondelete='cascade'),
-#        'function_id': fields.many2one('res.partner.function','Job Title'),
-#        'sequence_contact':fields.integer('Sequence',help='Order of importance of this address in the list of addresses of the linked contact'),
-#        'sequence_partner':fields.integer('Sequence',help='Order of importance of this job title in the list of job title of the linked partner'),
-#        'email': fields.char('E-Mail', size=240),
-#        'phone': fields.char('Phone', size=64),
-#        'date_start' : fields.date('Date Start'),
-#        'date_stop' : fields.date('Date Stop'),
-#        'state' : fields.selection([('past', 'Past'),('current', 'Current')], 'State', required=True),
-#    }
-#
-#    _defaults = {
-#        'sequence_contact' : lambda *a: 0,
-#        'state' : lambda *a: 'current',
-#    }
-#res_partner_job()
 
 
 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

From a312c37c8652cb967171e55a395b4dcdc424ef95 Mon Sep 17 00:00:00 2001
From: Mustufa Rangwala <mra@tinyerp.com>
Date: Fri, 5 Dec 2008 16:33:11 +0530
Subject: [PATCH 06/24] base_module_quality

bzr revid: mra@tinyerp.com-20081205110311-tioofhfhdd6slwrz
---
 addons/base_module_quality/wizard/module_quality_check.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/base_module_quality/wizard/module_quality_check.py b/addons/base_module_quality/wizard/module_quality_check.py
index 648b24366f6..d4f0a19d4d2 100644
--- a/addons/base_module_quality/wizard/module_quality_check.py
+++ b/addons/base_module_quality/wizard/module_quality_check.py
@@ -50,7 +50,7 @@ view_form = """<?xml version="1.0"?>
 
 view_field = {
     "module_info": {'type': 'text', 'string': 'check quality',
-        'readonly': True,},
+        'readonly': True},
 }
 
 class wiz_quality_check(wizard.interface):

From bf4d49d238c58a68999d23b475968c93c4005373 Mon Sep 17 00:00:00 2001
From: Mantavya Gajjar <mga@tinyerp.com>
Date: Fri, 5 Dec 2008 16:36:48 +0530
Subject: [PATCH 07/24] change implementation for the opening page / group list
 * change in create menu * add new wizard that open the page in form view

bzr revid: mga@tinyerp.com-20081205110648-rxgy2sfxl3tp5lkm
---
 addons/wiki/wiki.py                |   2 +
 addons/wiki/wiki_view.xml          |   1 +
 addons/wiki/wizard/__init__.py     |   1 +
 addons/wiki/wizard/create_menu.py  |  26 +++---
 addons/wiki/wizard/open_page.py    |  68 +++++++++++++++
 addons/wiki/wizard/sort_algo.py    | 133 -----------------------------
 addons/wiki/wizard/wizard_view.xml |   6 ++
 7 files changed, 92 insertions(+), 145 deletions(-)
 create mode 100644 addons/wiki/wizard/open_page.py
 delete mode 100644 addons/wiki/wizard/sort_algo.py

diff --git a/addons/wiki/wiki.py b/addons/wiki/wiki.py
index ba2e432ca63..77092a92fd0 100644
--- a/addons/wiki/wiki.py
+++ b/addons/wiki/wiki.py
@@ -44,6 +44,8 @@ class WikiGroup(osv.osv):
        'create_date':fields.datetime("Created Date", select=True),
        'template': fields.text('Wiki Template'),
        'section': fields.boolean("Make Section ?"),
+       'home':fields.many2one('wiki.wiki', 'Pages'),
+       'action_id': fields.many2one('ir.ui.menu', 'Menu')
     }
 WikiGroup()
 
diff --git a/addons/wiki/wiki_view.xml b/addons/wiki/wiki_view.xml
index 0d6e69ca6c2..0483007cb65 100644
--- a/addons/wiki/wiki_view.xml
+++ b/addons/wiki/wiki_view.xml
@@ -8,6 +8,7 @@
         <wizard
             id="wizard_group_menu_create"
             string="Create Menu"
+            menu="True"
             name="wiki.create.menu"/>
             
         <record model="ir.ui.view" id="wiki_group_tree">
diff --git a/addons/wiki/wizard/__init__.py b/addons/wiki/wizard/__init__.py
index e6d1c52fa11..3f27f8dc92e 100644
--- a/addons/wiki/wizard/__init__.py
+++ b/addons/wiki/wizard/__init__.py
@@ -1,3 +1,4 @@
+import open_page
 import create_menu
 import show_diff
 import make_index
\ No newline at end of file
diff --git a/addons/wiki/wizard/create_menu.py b/addons/wiki/wizard/create_menu.py
index f97430312bd..611a05a3c6d 100644
--- a/addons/wiki/wizard/create_menu.py
+++ b/addons/wiki/wizard/create_menu.py
@@ -20,7 +20,6 @@
 #
 ##############################################################################
 
-
 import time
 import wizard
 import osv
@@ -31,31 +30,34 @@ section_form = '''<?xml version="1.0"?>
     <separator string="Menu Information" colspan="4"/>
     <field name="menu_name"/>
     <field name="menu_parent_id"/>
+    <field name="page" colspan="4" domain="[('group_id','=', active_id)]"/>
 </form>'''
 
 section_fields = {
     'menu_name': {'string':'Menu Name', 'type':'char', 'required':True, 'size':64},
     'menu_parent_id': {'string':'Parent Menu', 'type':'many2one', 'relation':'ir.ui.menu', 'required':True},
+    'page': {'string':'Group Home Page', 'type':'many2one', 'relation':'wiki.wiki'},
 }
 
 def wiki_menu_create(self, cr, uid, data, context):
     pool = pooler.get_pool(cr.dbname)
     group = pool.get('wiki.groups').browse(cr, uid, data['id'])
+    action_id = pool.get('ir.actions.wizard').search(cr, uid, [('wiz_name','=','wiki.wiki.page.open')])
 
-    action_id = pool.get('ir.actions.act_window').create(cr, uid, {
-        'name': group.name,
-        'view_type':'form',
-        'view_mode':"tree,form",
-        'context': "{'group_id':%d, 'section':%d}" % (group.id, group.section),
-        'domain': "[('group_id','child_of',[%d])]" % (group.id,),
-        'res_model': 'wiki.wiki'
-    })
-    pool.get('ir.ui.menu').create(cr, uid, {
+    menu_id = pool.get('ir.ui.menu').create(cr, uid, {
         'name': data['form']['menu_name'],
         'parent_id': data['form']['menu_parent_id'],
-        'icon': 'STOCK_JUSTIFY_FILL',
-        'action': 'ir.actions.act_window,'+str(action_id)
+        'icon': 'STOCK_DIALOG_QUESTION',
+        'action': 'ir.actions.wizard,'+str(action_id[0])
     }, context)
+    
+    home = data['form']['page']
+    res = {
+        'home':home,
+        'action_id':menu_id
+    }
+    pool.get('wiki.groups').write(cr, uid, [data['id']], res)
+    
     return {}
 
 class wizard_create_menu(wizard.interface):
diff --git a/addons/wiki/wizard/open_page.py b/addons/wiki/wizard/open_page.py
new file mode 100644
index 00000000000..e4135df2bb9
--- /dev/null
+++ b/addons/wiki/wizard/open_page.py
@@ -0,0 +1,68 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution    
+#    Copyright (C) 2004-2008 Tiny SPRL (<http://tiny.be>). All Rights Reserved
+#    $Id$
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU General Public License as published by
+#    the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU General Public License for more details.
+#
+#    You should have received a copy of the GNU General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+
+import wizard
+import netsvc
+import time
+import pooler
+from osv import osv
+from tools.translate import _
+
+class wiz_timesheet_open(wizard.interface):
+    
+    def _open_wiki_page(self, cr, uid, data, context):
+        pool = pooler.get_pool(cr.dbname)
+        menu_id = data['id']
+        group_ids = pool.get('wiki.groups').search(cr, uid, [('action_id','=',menu_id)])
+
+        group = pool.get('wiki.groups').browse(cr, uid, group_ids[0])
+        
+        value = {
+            'context': "{'group_id':%d}" % (group.id),
+            'domain': "[('group_id','child_of',[%s])]" % (group.id),
+            'name': 'Wiki Page',
+            'view_type': 'form',
+            'view_mode': 'form,tree',
+            'res_model': 'wiki.wiki',
+            'view_id': False,
+            'type': 'ir.actions.act_window',
+        }
+        if group.home :
+            value['res_id'] = group.home.id
+        else:
+            value['view_type'] = 'form'
+            value['view_mode'] = 'tree,form'
+            
+        return value
+
+    states = {
+        'init' : {
+            'actions' : [],
+            'result' : {'type':'action', 'action':_open_wiki_page, 'state':'end'}
+        }
+    }
+wiz_timesheet_open('wiki.wiki.page.open')
+
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
+
diff --git a/addons/wiki/wizard/sort_algo.py b/addons/wiki/wizard/sort_algo.py
deleted file mode 100644
index 9579b8ff6b7..00000000000
--- a/addons/wiki/wizard/sort_algo.py
+++ /dev/null
@@ -1,133 +0,0 @@
-def sort(data, index):
-    for i in range(len(data)):
-        j = i + 1
-        for j in range(len(data)-1):
-            d1 = data[i].split('.')
-            d2 = data[j].split('.')
-            
-            l1 = len(d1)
-            l2 = len(d2)
-            max = 0
-            if l1 < l2:
-                max = l1
-            elif l2 < l1:
-                max = l2
-            else:
-                max = l1
-            
-            if max == 1:
-                if int(d1[0]) == int(d2[0]):
-                    if len(d1) < len(d2):
-                        tmp = data[i]
-                        data[i] = data[j]
-                        data[j] = tmp
-                        continue
-
-            for p in range(0, max):
-                val1 = val2 = 0
-                try:
-                    val1 = int(d1[p])
-                except:
-                    val1 = 0
-                    
-                try:
-                    val2 = int(d2[p])
-                except:
-                    val2 = 0
-                    
-                if val1 < val2:
-                    tmp = data[i]
-                    data[i] = data[j]
-                    data[j] = tmp
-            if data[i].startswith(data[j]):
-                tmp = data[i]
-                tmp = tmp.replace(data[j],'')
-
-def group(data):
-    gp = {}
-    for i in range(len(data)):
-        d1 = data[i].split('.')[0]
-        if gp.has_key(d1):
-            gp[d1].append(data[i])
-        else:
-            gp[d1] = [data[i]]
-    return gp
-
-def max(data):
-    max = 0
-    for i in range(len(data)):
-        d = str(data[i]).split('.')
-        if len(d) > max:
-            max = len(d)
-            
-    return max
-
-def toint(data):
-    for i in range(len(data)):
-        data[i] = int(data[i])
-        
-def rearrange(key, groups):
-    i = 1
-    new = {}
-    for ky in key:
-        new[i] = groups[str(ky)]
-        i += 1
-    return new
-
-def reindex(key, groups):
-    if groups[0] != key:
-        groups[0] = key
-    
-    lvl_group = {}
-    level = max(groups)
-    for i in range(len(groups)):
-        dg = str(groups[i]).split('.')
-        index = len(dg)
-        if lvl_group.has_key(str(index)):
-            lvl_group[str(index)].append(groups[i])
-        else:
-            lvl_group[str(index)] = [groups[i]]
-    
-    for i in range(2, level+1):
-        ixd = 1
-        gps = lvl_group[str(i)]
-        for j in range(len(gps)):
-            dt = gps[j].split('.')
-            new =""
-            for k in range(i-1):
-                new += str(dt[k])
-                new += '.'
-                
-            new += str(ixd)
-            ixd += 1
-            gps[j] = new
-            
-    print lvl_group
-    
-if __name__ == '__main__':
-    
-    data = ['1', '10.1', '10.3', '1.1', '1.2.3', '1.7', '3.1.8', '1.2.2', '1.2.10', '1.3', '1.4', '2', '20.2', '2.1', '2.2', '3', '3.1', '1.2.1', '2.1.2']
-    
-    sort(data, 0)
-    
-    grp = group(data)
-    
-    for gp in grp:
-        loop = max(grp[gp])
-        for lp in range(1, loop):
-            sort(grp[gp],lp)
-    
-    key = grp.keys()
-    toint(key)
-    key.sort()
-    
-    groups = rearrange(key, grp)
-    
-    new_data = []
-    for key in groups:
-        new_data.extend(groups[key])
-        #print groups[key]
-    
-    print 'XXXXXXXXXXXXXXXXX : ', new_data
-#    print groups
-#    
diff --git a/addons/wiki/wizard/wizard_view.xml b/addons/wiki/wizard/wizard_view.xml
index b1e73e689f4..bc10f5a2ae7 100644
--- a/addons/wiki/wizard/wizard_view.xml
+++ b/addons/wiki/wizard/wizard_view.xml
@@ -25,5 +25,11 @@
             string="Create Index"
             name="wiki.make.index"
             model="wiki.wiki"/>
+
+		<wizard
+		    id="wizard_open_page"
+		    string="Open Page"
+		    name="wiki.wiki.page.open"
+		    model="wiki.wiki"/>
     </data>
 </openerp>

From d9dfa863b06f14c8ae93ceed62b3306589597976 Mon Sep 17 00:00:00 2001
From: Mustufa Rangwala <mra@tinyerp.com>
Date: Fri, 5 Dec 2008 16:55:25 +0530
Subject: [PATCH 08/24] set height and width of display window on
 base_module_qualtiy

bzr revid: mra@tinyerp.com-20081205112525-t4zw0jpcxgi48ect
---
 .../base_module_quality/wizard/module_quality_check.py   | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/addons/base_module_quality/wizard/module_quality_check.py b/addons/base_module_quality/wizard/module_quality_check.py
index d4f0a19d4d2..de3f333338a 100644
--- a/addons/base_module_quality/wizard/module_quality_check.py
+++ b/addons/base_module_quality/wizard/module_quality_check.py
@@ -36,21 +36,18 @@ form_check = '''<?xml version="1.0"?>
 
 fields_check = {
     'test': {
-        'string':'Tests', 'type':'selection', 'size':64, 'required':True,
+        'string':'Tests', 'type':'selection',  'required':True,
         'selection': [('pylint', 'Pylint'), ('othertest','other')],
         'default': lambda *args: 'pylint'
     },
     }
 view_form = """<?xml version="1.0"?>
 <form string="Check quality">
-    <group colspan="2" col="4">
-        <field name="module_info" nolabel="1" colspan="4"/>
-    </group>
+        <field name="module_info" nolabel="1" colspan="4" height="150" width="400"/>
 </form>"""
 
 view_field = {
-    "module_info": {'type': 'text', 'string': 'check quality',
-        'readonly': True},
+    "module_info": {'type': 'text', 'string': 'check quality',  'readonly':True},
 }
 
 class wiz_quality_check(wizard.interface):

From 4196327f6820f35e968ec80c4ac71f1b28bc0956 Mon Sep 17 00:00:00 2001
From: Mustufa Rangwala <mra@tinyerp.com>
Date: Fri, 5 Dec 2008 17:36:58 +0530
Subject: [PATCH 09/24] modifs on base_module_quality

bzr revid: mra@tinyerp.com-20081205120658-ujsxa4ym2zq45jpc
---
 addons/base_module_quality/wizard/pylint_test/pylint_test.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/addons/base_module_quality/wizard/pylint_test/pylint_test.py b/addons/base_module_quality/wizard/pylint_test/pylint_test.py
index 7a990992257..df4491a8f85 100644
--- a/addons/base_module_quality/wizard/pylint_test/pylint_test.py
+++ b/addons/base_module_quality/wizard/pylint_test/pylint_test.py
@@ -39,8 +39,9 @@ def _test_pylint(self, url, add_folder=None):
         if file.split('.')[-1] == 'py':
             save_file = file.split('.')[0]+".txt"
             file_path = os.path.join(url, file)
-            a1 = os.system('pylint '+file_path+'>> '+save_file+' ')
+            os.system('pylint '+file_path+'>> '+save_file+' ')
             a2 = os.system('cat '+save_file+' | tail -4 >> temp.txt')
+            os.system('rm '+save_file+' ')
             fp = open('temp.txt','r')
             result = fp.read()
             fp.close()
@@ -57,6 +58,7 @@ def _test_pylint(self, url, add_folder=None):
                     dict_files[add_folder + '/' + file] = str_result
                 else:
                     dict_files[file] = str_result
+    os.system(' rm temp.txt ')
     dict_files.update(subfolder)
     return dict_files
 

From d65b408046c59d7ab403dfddb82dae857ba795b8 Mon Sep 17 00:00:00 2001
From: Stephane Wirtel <stephane@tinyerp.com>
Date: Fri, 5 Dec 2008 14:49:05 +0100
Subject: [PATCH 10/24] [IMP] Use the check_contract method

bzr revid: stephane@tinyerp.com-20081205134905-h4l1vd8izy7ljus0
---
 bin/addons/base/maintenance/maintenance.py | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/bin/addons/base/maintenance/maintenance.py b/bin/addons/base/maintenance/maintenance.py
index b7150a4891e..0eae4277f1c 100644
--- a/bin/addons/base/maintenance/maintenance.py
+++ b/bin/addons/base/maintenance/maintenance.py
@@ -63,7 +63,8 @@ class maintenance_contract(osv.osv):
         'date_start' : fields.date('Starting Date', readonly=True),
         'date_stop' : fields.date('Ending Date', readonly=True),
         'module_ids' : fields.many2many('maintenance.contract.module', 'maintenance_contract_module_rel', 'contract_id', 'module_id', 'Covered Modules', readonly=True),
-        'state' : fields.function(_valid_get, method=True, string="State", type="selection", selection=[('valid', 'Valid'),('unvalid', 'Unvalid')], readonly=True)
+        'state' : fields.function(_valid_get, method=True, string="State", type="selection", selection=[('valid', 'Valid'),('unvalid', 'Unvalid')], readonly=True),
+        'kind' : fields.selection([('full', 'Full'),('partial', 'Partial')], 'Kind', required=True, readonly=True),
     }
     _defaults = {
         'password' : lambda obj,cr,uid,context={} : '',
@@ -92,6 +93,10 @@ class maintenance_contract_wizard(osv.osv_memory):
         if not ids:
             return False
 
+        module_proxy = self.pool.get('ir.module.module')
+        module_ids = module_proxy.search(cr, uid, [('state', '=', 'installed')])
+        modules = module_proxy.read(cr, uid, module_ids, ['name', 'installed_version'])
+
         contract = self.read(cr, uid, ids, ['name', 'password'])[0]
 
         login, password, remote_db, remote_server, port = 'admin', 'admin', 'trunk', 'localhost', 8069
@@ -99,12 +104,12 @@ class maintenance_contract_wizard(osv.osv_memory):
         rpc = xmlrpclib.ServerProxy('http://%s:%d/xmlrpc/common' % (remote_server, port))
         ruid = rpc.login(remote_db, login, password)
         rpc = xmlrpclib.ServerProxy('http://%s:%d/xmlrpc/object' % (remote_server, port))
-        contract_info = rpc.execute(remote_db, ruid, password, 
-                          'maintenance.maintenance', 'get_module_for_contract', contract['name'], contract['password'])
-        if contract_info:
-            if contract_info['modules']:
+        contract_info = rpc.execute(remote_db, ruid, password, 'maintenance.maintenance', 'check_contract', modules, contract )
+        is_ok = contract_info['status'] in ('partial', 'full')
+        if is_ok:
+            if contract_info['modules_with_contract']:
                 module_ids = []
-                for name, version in contract_info['modules']:
+                for name, version in contract_info['modules_with_contract']:
                     contract_module = self.pool.get('maintenance.contract.module')
                     res = contract_module.search(cr, uid, [('name', '=', name),('version', '=', version)])
                     if not res:
@@ -120,11 +125,12 @@ class maintenance_contract_wizard(osv.osv_memory):
                     'password' : contract['password'],
                     'date_start' : contract_info['date_from'],
                     'date_stop' : contract_info['date_to'],
+                    'kind' : contract_info['status'],
                     'module_ids' : [(6,0,module_ids)],
                 }
             )
 
-        return self.write(cr, uid, ids, {'state' : ('unvalidated', 'validated')[bool(contract_info)] }, context=context)
+        return self.write(cr, uid, ids, {'state' : ('unvalidated', 'validated')[is_ok] }, context=context)
 
 maintenance_contract_wizard()
 

From 15856a5d38cb51d27bd3c802297f700f04df230c Mon Sep 17 00:00:00 2001
From: Mantavya Gajjar <mga@tinyerp.com>
Date: Fri, 5 Dec 2008 19:34:01 +0530
Subject: [PATCH 11/24] bug-fix : problem with the menu nowits possible to have
 single page multiple menus

bzr revid: mga@tinyerp.com-20081205140401-u1e0xyqccb872fj2
---
 addons/wiki/wiki.py               | 13 +++++++++++--
 addons/wiki/wizard/create_menu.py |  3 ++-
 addons/wiki/wizard/open_page.py   | 13 ++++++-------
 3 files changed, 19 insertions(+), 10 deletions(-)

diff --git a/addons/wiki/wiki.py b/addons/wiki/wiki.py
index 77092a92fd0..874516847cc 100644
--- a/addons/wiki/wiki.py
+++ b/addons/wiki/wiki.py
@@ -31,6 +31,16 @@ import time
 from StringIO import StringIO
 from HTMLParser import HTMLParser
 
+class GroupLink(osv.osv):
+    _name = "wiki.groups.link"
+    _description="Wiki Groups Links"
+    _rec_name = 'action_id'
+    _columns={
+       'group_id':fields.many2one('wiki.groups', 'Parent Group', ondelete='set null'),
+       'action_id': fields.many2one('ir.ui.menu', 'Menu')
+    }
+GroupLink()
+
 class WikiGroup(osv.osv):
     _name = "wiki.groups"
     _description="Wiki Groups"
@@ -44,8 +54,7 @@ class WikiGroup(osv.osv):
        'create_date':fields.datetime("Created Date", select=True),
        'template': fields.text('Wiki Template'),
        'section': fields.boolean("Make Section ?"),
-       'home':fields.many2one('wiki.wiki', 'Pages'),
-       'action_id': fields.many2one('ir.ui.menu', 'Menu')
+       'home':fields.many2one('wiki.wiki', 'Pages')
     }
 WikiGroup()
 
diff --git a/addons/wiki/wizard/create_menu.py b/addons/wiki/wizard/create_menu.py
index 611a05a3c6d..84da749015f 100644
--- a/addons/wiki/wizard/create_menu.py
+++ b/addons/wiki/wizard/create_menu.py
@@ -52,11 +52,12 @@ def wiki_menu_create(self, cr, uid, data, context):
     }, context)
     
     home = data['form']['page']
+    group_id = data['id']
     res = {
         'home':home,
-        'action_id':menu_id
     }
     pool.get('wiki.groups').write(cr, uid, [data['id']], res)
+    pool.get('wiki.groups.link').create(cr, uid, {'group_id':group_id, 'action_id':menu_id})
     
     return {}
 
diff --git a/addons/wiki/wizard/open_page.py b/addons/wiki/wizard/open_page.py
index e4135df2bb9..d601f303d61 100644
--- a/addons/wiki/wizard/open_page.py
+++ b/addons/wiki/wizard/open_page.py
@@ -33,13 +33,12 @@ class wiz_timesheet_open(wizard.interface):
     def _open_wiki_page(self, cr, uid, data, context):
         pool = pooler.get_pool(cr.dbname)
         menu_id = data['id']
-        group_ids = pool.get('wiki.groups').search(cr, uid, [('action_id','=',menu_id)])
-
-        group = pool.get('wiki.groups').browse(cr, uid, group_ids[0])
+        group_ids = pool.get('wiki.groups.link').search(cr, uid, [('action_id','=',menu_id)])
+        group = pool.get('wiki.groups.link').browse(cr, uid, group_ids[0])
         
         value = {
-            'context': "{'group_id':%d}" % (group.id),
-            'domain': "[('group_id','child_of',[%s])]" % (group.id),
+            'context': "{'group_id':%d}" % (group.group_id.id),
+            'domain': "[('group_id','child_of',[%s])]" % (group.group_id.id),
             'name': 'Wiki Page',
             'view_type': 'form',
             'view_mode': 'form,tree',
@@ -47,8 +46,8 @@ class wiz_timesheet_open(wizard.interface):
             'view_id': False,
             'type': 'ir.actions.act_window',
         }
-        if group.home :
-            value['res_id'] = group.home.id
+        if group.group_id.home:
+            value['res_id'] = group.group_id.home.id
         else:
             value['view_type'] = 'form'
             value['view_mode'] = 'tree,form'

From 3fc4fd57135e6b0b4c49c95c2f65603bbc3bd55d Mon Sep 17 00:00:00 2001
From: Mantavya Gajjar <mga@tinyerp.com>
Date: Fri, 5 Dec 2008 20:17:34 +0530
Subject: [PATCH 12/24] fix the problem of the dependency

bzr revid: mga@tinyerp.com-20081205144734-74be0bqklt0hxr3v
---
 addons/wiki/wiki.py | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/addons/wiki/wiki.py b/addons/wiki/wiki.py
index 874516847cc..f034d5a0dac 100644
--- a/addons/wiki/wiki.py
+++ b/addons/wiki/wiki.py
@@ -31,16 +31,6 @@ import time
 from StringIO import StringIO
 from HTMLParser import HTMLParser
 
-class GroupLink(osv.osv):
-    _name = "wiki.groups.link"
-    _description="Wiki Groups Links"
-    _rec_name = 'action_id'
-    _columns={
-       'group_id':fields.many2one('wiki.groups', 'Parent Group', ondelete='set null'),
-       'action_id': fields.many2one('ir.ui.menu', 'Menu')
-    }
-GroupLink()
-
 class WikiGroup(osv.osv):
     _name = "wiki.groups"
     _description="Wiki Groups"
@@ -58,6 +48,16 @@ class WikiGroup(osv.osv):
     }
 WikiGroup()
 
+class GroupLink(osv.osv):
+    _name = "wiki.groups.link"
+    _description="Wiki Groups Links"
+    _rec_name = 'action_id'
+    _columns={
+       'group_id':fields.many2one('wiki.groups', 'Parent Group', ondelete='set null'),
+       'action_id': fields.many2one('ir.ui.menu', 'Menu')
+    }
+GroupLink()
+
 class Wiki(osv.osv):
     _name="wiki.wiki"
     _description="Wiki Page"

From 284f847e4b5da39e4e0939759297d930f391801e Mon Sep 17 00:00:00 2001
From: Mantavya Gajjar <mga@tinyerp.com>
Date: Fri, 5 Dec 2008 20:24:49 +0530
Subject: [PATCH 13/24] fix dependency problem

bzr revid: mga@tinyerp.com-20081205145449-xmzj1ivbymn64x80
---
 addons/wiki/wiki.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/addons/wiki/wiki.py b/addons/wiki/wiki.py
index f034d5a0dac..15677c56367 100644
--- a/addons/wiki/wiki.py
+++ b/addons/wiki/wiki.py
@@ -31,6 +31,10 @@ import time
 from StringIO import StringIO
 from HTMLParser import HTMLParser
 
+class Wiki(osv.osv):
+    _name="wiki.wiki"
+Wiki()
+
 class WikiGroup(osv.osv):
     _name = "wiki.groups"
     _description="Wiki Groups"
@@ -59,7 +63,7 @@ class GroupLink(osv.osv):
 GroupLink()
 
 class Wiki(osv.osv):
-    _name="wiki.wiki"
+    _inherit="wiki.wiki"
     _description="Wiki Page"
     _order = 'section,create_date desc'
     _columns={

From a2798d40306f5a646d7338cf832cfdcad7f3d5be Mon Sep 17 00:00:00 2001
From: Mantavya Gajjar <mga@tinyerp.com>
Date: Sat, 6 Dec 2008 18:48:05 +0530
Subject: [PATCH 14/24] initial bug-fix for the voucher entry

bzr revid: mga@tinyerp.com-20081206131805-p352xscr1ccxeyh6
---
 addons/account_voucher/account_report.xml     | 23 ++++++++-------
 .../account_voucher_wizard.xml                |  4 +--
 .../account_voucher_workflow.xml              |  4 +--
 .../account_voucher/report/report_voucher.rml |  2 +-
 addons/account_voucher/voucher.py             | 28 ++++++++-----------
 addons/account_voucher/voucher_view.xml       |  4 +--
 6 files changed, 30 insertions(+), 35 deletions(-)

diff --git a/addons/account_voucher/account_report.xml b/addons/account_voucher/account_report.xml
index 134581c8816..d19ba827348 100755
--- a/addons/account_voucher/account_report.xml
+++ b/addons/account_voucher/account_report.xml
@@ -1,9 +1,9 @@
 <?xml version="1.0"?>
-<terp>
+<openerp>
 	<data>
 			
 		<report id="report_account_voucher"
-			string="Voucher Report (Cr/Dr)"
+			string="Voucher Report"
 			model="account.voucher"
 			name="voucher.cash_receipt"
 			rml="account_voucher/report/report_voucher.rml"
@@ -11,15 +11,14 @@
 			header = "False"
 			menu="True"/>
 			
-			
-		<report id="report_account_voucher_amt"
-			string="Voucher Report"
-			model="account.voucher"
-			name="voucher.cash_amount"
-			rml="account_voucher/report/report_voucher_amount.rml"
-			auto="False"
-			header = "False"
-			menu="True"/>
+<!--		<report id="report_account_voucher_amt"-->
+<!--			string="Voucher Report"-->
+<!--			model="account.voucher"-->
+<!--			name="voucher.cash_amount"-->
+<!--			rml="account_voucher/report/report_voucher_amount.rml"-->
+<!--			auto="False"-->
+<!--			header = "False"-->
+<!--			menu="True"/>-->
 			
 	</data>
-</terp>
\ No newline at end of file
+</openerp>
\ No newline at end of file
diff --git a/addons/account_voucher/account_voucher_wizard.xml b/addons/account_voucher/account_voucher_wizard.xml
index ffe7b25c87c..9557ffb4f4f 100644
--- a/addons/account_voucher/account_voucher_wizard.xml
+++ b/addons/account_voucher/account_voucher_wizard.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<terp>
+<openerp>
 	<data>
 	
         <wizard 
@@ -17,4 +17,4 @@
         	type="wizard"
         />
 	</data>
-</terp>
\ No newline at end of file
+</openerp>
\ No newline at end of file
diff --git a/addons/account_voucher/account_voucher_workflow.xml b/addons/account_voucher/account_voucher_workflow.xml
index 0299c79997d..9609e105444 100644
--- a/addons/account_voucher/account_voucher_workflow.xml
+++ b/addons/account_voucher/account_voucher_workflow.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<terp>
+<openerp>
 	<data>
 
 		<record id="wkf_voucher" model="workflow">
@@ -72,4 +72,4 @@
             <field name="signal">open_voucher</field>
         </record>
 	</data>
-</terp>
\ No newline at end of file
+</openerp>
\ No newline at end of file
diff --git a/addons/account_voucher/report/report_voucher.rml b/addons/account_voucher/report/report_voucher.rml
index 685983045ae..c4c210551c5 100755
--- a/addons/account_voucher/report/report_voucher.rml
+++ b/addons/account_voucher/report/report_voucher.rml
@@ -180,7 +180,7 @@
           <blockTable colWidths="251.0,110.0,115.0" style="Table2">
             <tr>
               <td>
-                <para style="P11">[[ (move_ids.partner_id and move_ids.partner_id.name) or '']] :</para>
+                <para style="P11">[[ (move_ids.partner_id and move_ids.partner_id.name) or 'Account']] :</para>
                 <para style="P28">[[ move_ids.account_id.name ]] </para>
                 <para style="P31">[[ get_ref(voucher.id,move_ids) ]]</para>
               </td>
diff --git a/addons/account_voucher/voucher.py b/addons/account_voucher/voucher.py
index 873d6c19668..10b3862f3c8 100755
--- a/addons/account_voucher/voucher.py
+++ b/addons/account_voucher/voucher.py
@@ -29,6 +29,16 @@ from mx.DateTime import RelativeDateTime
 
 from tools import config
 
+type2journal = {
+    'rec_voucher':'cash', 
+    'bank_rec_voucher':'cash',
+    'pay_voucher': 'cash',
+    'bank_pay_voucher':'cash',
+    'cont_voucher':'cash',
+    'journal_sale_voucher':'sale',
+    'journal_pur_voucher':'purchase'
+}
+
 class account_voucher(osv.osv):
     def _get_period(self, cr, uid, context):
         periods = self.pool.get('account.period').find(cr, uid)
@@ -45,9 +55,9 @@ class account_voucher(osv.osv):
         return [('none', 'Free Reference')]
     
     def _get_journal(self, cr, uid, context):
-        type_inv = context #.get('type', 'rec_voucher')
-        type2journal = {'rec_voucher': 'cash', 'bank_rec_voucher': 'cash','pay_voucher': 'cash','bank_pay_voucher': 'cash', 'cont_voucher': 'cash','journal_sale_voucher': 'sale','journal_pur_voucher': 'purchase' }
+        type_inv = context.get('type', 'rec_voucher')
         journal_obj = self.pool.get('account.journal')
+        res = False
         res = journal_obj.search(cr, uid, [('type', '=', type2journal.get(type_inv, 'cash'))], limit=1)
         if res:
             return res[0]
@@ -99,18 +109,6 @@ class account_voucher(osv.osv):
         'move_ids':fields.many2many('account.move.line', 'voucher_id', 'account_id', 'rel_account_move', 'Real Entry'),
     }
     
-#    def get_bank(self, cr, uid, context={}):
-#        type = context.get('type', 'bank_payment')
-#        journal = self.pool.get('account.journal')
-#        if type == 'bank_payment':
-#            id = journal.search(cr, uid, [('name','ilike','Bank')])
-#            return id
-#        elif type == 'cash_payment':
-#            id = journal.search(cr, uid, [('name','ilike','Cash')])
-#            return id
-#
-#        return 3
-    
     _defaults = {
         #'journal_id':get_bank,
         'state': lambda *a: 'draft',
@@ -123,8 +121,6 @@ class account_voucher(osv.osv):
                 self.pool.get('res.users').browse(cr, uid, uid,
                     context=context).company_id.id,
         'currency_id': _get_currency,
-
-
     }
     
     def _get_analytic_lines(self, cr, uid, id):
diff --git a/addons/account_voucher/voucher_view.xml b/addons/account_voucher/voucher_view.xml
index a1f6907c701..872d831fa79 100755
--- a/addons/account_voucher/voucher_view.xml
+++ b/addons/account_voucher/voucher_view.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<terp>
+<openerp>
 	<data>
 		<record model="ir.ui.view" id="view_voucher_tree">
 			<field name="name">account.voucher.tree</field>
@@ -293,4 +293,4 @@
 		<menuitem name="Financial Management/Voucher Entries/Other Vouchers/Journal Purchase Voucher" id="menu_action_view_jour_pur_voucher_form" action="action_view_jour_pur_voucher_form"/>
 		
 		</data>
-</terp>
\ No newline at end of file
+</openerp>
\ No newline at end of file

From d87d56b4ba2a4c579a099be961420e9b1ab1f982 Mon Sep 17 00:00:00 2001
From: Fabien Pinckaers <fp@tinyerp.com>
Date: Sun, 7 Dec 2008 03:15:41 +0100
Subject: [PATCH 15/24] improvement

bzr revid: fp@tinyerp.com-20081207021541-hoxme31i15s1aiog
---
 addons/account/account.py                     | 155 +++++++-----------
 addons/account/account_view.xml               |   2 +
 addons/account/invoice.py                     |  59 ++++---
 .../account_tax_include/invoice_tax_incl.py   | 136 +++++++--------
 4 files changed, 158 insertions(+), 194 deletions(-)

diff --git a/addons/account/account.py b/addons/account/account.py
index 1b618d24cc4..1b7727e9737 100644
--- a/addons/account/account.py
+++ b/addons/account/account.py
@@ -1232,6 +1232,7 @@ class account_tax(osv.osv):
         'include_base_amount': fields.boolean('Include in base amount', help="Indicate if the amount of tax must be included in the base amount for the computation of the next taxes"),
         'company_id': fields.many2one('res.company', 'Company', required=True),
         'description': fields.char('Internal Name',size=32),
+        'price_include': fields.boolean('Tax Included in Price', help="Check this is the price you use on the product and invoices is including this tax.")
     }
 
     def name_get(self, cr, uid, ids, context={}):
@@ -1254,6 +1255,7 @@ class account_tax(osv.osv):
         'applicable_type': lambda *a: 'true',
         'type': lambda *a: 'percent',
         'amount': lambda *a: 0,
+        'price_include': lambda *a: 0,
         'active': lambda *a: 1,
         'sequence': lambda *a: 1,
         'tax_group': lambda *a: 'vat',
@@ -1286,11 +1288,8 @@ class account_tax(osv.osv):
         for tax in taxes:
             # we compute the amount for the current tax object and append it to the result
 
-            if tax.type=='percent':
-                amount = cur_price_unit * tax.amount
-                res.append({'id':tax.id,
+            data = {'id':tax.id,
                             'name':tax.name,
-                            'amount':amount,
                             'account_collected_id':tax.account_collected_id.id,
                             'account_paid_id':tax.account_paid_id.id,
                             'base_code_id': tax.base_code_id.id,
@@ -1303,47 +1302,21 @@ class account_tax(osv.osv):
                             'price_unit': cur_price_unit,
                             'tax_code_id': tax.tax_code_id.id,
                             'ref_tax_code_id': tax.ref_tax_code_id.id,
-                            })
+            }
+            res.append(data)
+            if tax.type=='percent':
+                amount = cur_price_unit * tax.amount
+                data['amount'] = amount
 
             elif tax.type=='fixed':
-                res.append({'id':tax.id,
-                            'name':tax.name,
-                            'amount':tax.amount,
-                            'account_collected_id':tax.account_collected_id.id,
-                            'account_paid_id':tax.account_paid_id.id,
-                            'base_code_id': tax.base_code_id.id,
-                            'ref_base_code_id': tax.ref_base_code_id.id,
-                            'sequence': tax.sequence,
-                            'base_sign': tax.base_sign,
-                            'tax_sign': tax.tax_sign,
-                            'ref_base_sign': tax.ref_base_sign,
-                            'ref_tax_sign': tax.ref_tax_sign,
-                            'price_unit': 1,
-                            'tax_code_id': tax.tax_code_id.id,
-                            'ref_tax_code_id': tax.ref_tax_code_id.id,})
+                data['amount'] = tax.amount
             elif tax.type=='code':
                 address = address_id and self.pool.get('res.partner.address').browse(cr, uid, address_id) or None
                 localdict = {'price_unit':cur_price_unit, 'address':address, 'product':product, 'partner':partner}
                 exec tax.python_compute in localdict
                 amount = localdict['result']
-                res.append({
-                    'id': tax.id,
-                    'name': tax.name,
-                    'amount': amount,
-                    'account_collected_id': tax.account_collected_id.id,
-                    'account_paid_id': tax.account_paid_id.id,
-                    'base_code_id': tax.base_code_id.id,
-                    'ref_base_code_id': tax.ref_base_code_id.id,
-                    'sequence': tax.sequence,
-                    'base_sign': tax.base_sign,
-                    'tax_sign': tax.tax_sign,
-                    'ref_base_sign': tax.ref_base_sign,
-                    'ref_tax_sign': tax.ref_tax_sign,
-                    'price_unit': cur_price_unit,
-                    'tax_code_id': tax.tax_code_id.id,
-                    'ref_tax_code_id': tax.ref_tax_code_id.id,
-                })
-            amount2 = res[-1]['amount']
+                data['amount'] = amount
+            amount2 = data['amount']
             if len(tax.child_ids):
                 if tax.child_depend:
                     del res[-1]
@@ -1369,86 +1342,72 @@ class account_tax(osv.osv):
             r['amount'] *= quantity
         return res
 
-    def _unit_compute_inv(self, cr, uid, taxes, price_unit, address_id=None, product=None, partner=None,tax_parent_tot=0.0):
+    def _unit_compute_inv(self, cr, uid, taxes, price_unit, address_id=None, product=None, partner=None):
         taxes = self._applicable(cr, uid, taxes, price_unit, address_id, product, partner)
 
         res = []
         taxes.reverse()
         cur_price_unit=price_unit
-        for tax in taxes:
-            # we compute the amount for the current tax object and append it to the result
 
+        tax_parent_tot = 0.0
+        for tax in taxes:
+            if (tax.type=='percent') and not tax.include_base_amount:
+                tax_parent_tot+=tax.amount
+
+        for tax in taxes:
             if tax.type=='percent':
-                amount = cur_price_unit - (cur_price_unit / (1 + tax.amount))
-                res.append({'id':tax.id,
-                            'name':tax.name,
-                            'amount':amount,
-                            'account_collected_id':tax.account_collected_id.id,
-                            'account_paid_id':tax.account_paid_id.id,
-                            'base_code_id': tax.base_code_id.id,
-                            'ref_base_code_id': tax.ref_base_code_id.id,
-                            'sequence': tax.sequence,
-                            'base_sign': tax.base_sign,
-                            'tax_sign': tax.tax_sign,
-                            'ref_base_sign': tax.ref_base_sign,
-                            'ref_tax_sign': tax.ref_tax_sign,
-                            'price_unit': cur_price_unit - amount,
-                            'tax_code_id': tax.tax_code_id.id,
-                            'ref_tax_code_id': tax.ref_tax_code_id.id,})
+                if tax.include_base_amount:
+                    amount = cur_price_unit - (cur_price_unit / (1 + tax.amount))
+                else:
+                    amount = (cur_price_unit / (1 + tax_parent_tot)) * tax.amount
 
             elif tax.type=='fixed':
-                res.append({'id':tax.id,
-                            'name':tax.name,
-                            'amount':tax.amount,
-                            'account_collected_id':tax.account_collected_id.id,
-                            'account_paid_id':tax.account_paid_id.id,
-                            'base_code_id': tax.base_code_id.id,
-                            'ref_base_code_id': tax.ref_base_code_id.id,
-                            'sequence': tax.sequence,
-                            'base_sign': tax.base_sign,
-                            'tax_sign': tax.tax_sign,
-                            'ref_base_sign': tax.ref_base_sign,
-                            'ref_tax_sign': tax.ref_tax_sign,
-                            'price_unit': 1,
-                            'tax_code_id': tax.tax_code_id.id,
-                            'ref_tax_code_id': tax.ref_tax_code_id.id,})
+                amount = tax.amount
 
             elif tax.type=='code':
                 address = address_id and self.pool.get('res.partner.address').browse(cr, uid, address_id) or None
                 localdict = {'price_unit':cur_price_unit, 'address':address, 'product':product, 'partner':partner}
                 exec tax.python_compute_inv in localdict
                 amount = localdict['result']
-                res.append({
-                    'id': tax.id,
-                    'name': tax.name,
-                    'amount': amount,
-                    'account_collected_id': tax.account_collected_id.id,
-                    'account_paid_id': tax.account_paid_id.id,
-                    'base_code_id': tax.base_code_id.id,
-                    'ref_base_code_id': tax.ref_base_code_id.id,
-                    'sequence': tax.sequence,
-                    'base_sign': tax.base_sign,
-                    'tax_sign': tax.tax_sign,
-                    'ref_base_sign': tax.ref_base_sign,
-                    'ref_tax_sign': tax.ref_tax_sign,
-                    'price_unit': cur_price_unit - amount,
-                    'tax_code_id': tax.tax_code_id.id,
-                    'ref_tax_code_id': tax.ref_tax_code_id.id,
-                })
 
-            amount2 = res[-1]['amount']
+            if tax.include_base_amount:
+                cur_price_unit -= amount
+                todo = 0
+            else:
+                todo = 1
+            res.append({
+                'id': tax.id,
+                'todo': todo,
+                'name': tax.name,
+                'amount': amount,
+                'account_collected_id': tax.account_collected_id.id,
+                'account_paid_id': tax.account_paid_id.id,
+                'base_code_id': tax.base_code_id.id,
+                'ref_base_code_id': tax.ref_base_code_id.id,
+                'sequence': tax.sequence,
+                'base_sign': tax.base_sign,
+                'tax_sign': tax.tax_sign,
+                'ref_base_sign': tax.ref_base_sign,
+                'ref_tax_sign': tax.ref_tax_sign,
+                'price_unit': cur_price_unit,
+                'tax_code_id': tax.tax_code_id.id,
+                'ref_tax_code_id': tax.ref_tax_code_id.id,
+            })
             if len(tax.child_ids):
                 if tax.child_depend:
                     del res[-1]
                     amount = price_unit
-                else:
-                    amount = amount2
-            for t in tax.child_ids:
-                parent_tax = self._unit_compute_inv(cr, uid, [t], amount, address_id, product, partner)
-                res.extend(parent_tax)
-            if tax.include_base_amount:
-                cur_price_unit-=amount
-        taxes.reverse()
+
+            parent_tax = self._unit_compute_inv(cr, uid, tax.child_ids, amount, address_id, product, partner)
+            res.extend(parent_tax)
+
+        total = 0.0
+        for r in res:
+            if r['todo']:
+                total += r['amount']
+        for r in res:
+            r['price_unit'] -= total
+            r['todo'] = 0
         return res
 
     def compute_inv(self, cr, uid, taxes, price_unit, quantity, address_id=None, product=None, partner=None):
diff --git a/addons/account/account_view.xml b/addons/account/account_view.xml
index c3053513fde..c73b829f14b 100644
--- a/addons/account/account_view.xml
+++ b/addons/account/account_view.xml
@@ -557,6 +557,7 @@
             <field name="arch" type="xml">
                 <tree string="Account Tax">
                     <field name="name"/>
+                    <field name="price_include"/>
                     <field name="description"/>
                 </tree>
             </field>
@@ -588,6 +589,7 @@
                             <label colspan="2" nolabel="1" string="Keep empty to use the expense account"/>
                             <field groups="base.group_extended" name="child_depend"/>
                             <field groups="base.group_extended" name="sequence"/>
+                            <field groups="base.group_extended" name="price_include"/>
                             <newline/>
                             <field colspan="4" groups="base.group_extended" name="child_ids"/>
                         </page>
diff --git a/addons/account/invoice.py b/addons/account/invoice.py
index a511d79bf2a..a67653b8d55 100644
--- a/addons/account/invoice.py
+++ b/addons/account/invoice.py
@@ -31,24 +31,19 @@ from tools import config
 from tools.translate import _
 
 class account_invoice(osv.osv):
-    def _amount_untaxed(self, cr, uid, ids, name, args, context={}):
-        id_set=",".join(map(str,ids))
-        cr.execute("SELECT s.id,COALESCE(SUM(l.price_subtotal),0)::decimal(16,2) AS amount FROM account_invoice s LEFT OUTER JOIN account_invoice_line l ON (s.id=l.invoice_id) WHERE s.id IN ("+id_set+") GROUP BY s.id ")
-        res=dict(cr.fetchall())
-        return res
-
-    def _amount_tax(self, cr, uid, ids, name, args, context={}):
-        id_set=",".join(map(str,ids))
-        cr.execute("SELECT s.id,COALESCE(SUM(l.amount),0)::decimal(16,2) AS amount FROM account_invoice s LEFT OUTER JOIN account_invoice_tax l ON (s.id=l.invoice_id) WHERE s.id IN ("+id_set+") GROUP BY s.id ")
-        res=dict(cr.fetchall())
-        return res
-
-    def _amount_total(self, cr, uid, ids, name, args, context={}):
-        untax = self._amount_untaxed(cr, uid, ids, name, args, context)
-        tax = self._amount_tax(cr, uid, ids, name, args, context)
+    def _amount_all(self, cr, uid, ids, name, args, context={}):
         res = {}
-        for id in ids:
-            res[id] = untax.get(id,0.0) + tax.get(id,0.0)
+        for invoice in self.browse(cr,uid,ids):
+            res[invoice.id] = {
+                'amount_untaxed': 0.0,
+                'amount_tax': 0.0,
+                'amount_total': 0.0
+            }
+            for line in invoice.invoice_line:
+                res[invoice.id]['amount_untaxed'] += line.price_subtotal
+            for line in invoice.tax_line:
+                res[invoice.id]['amount_tax'] += line.amount
+            res[invoice.id]['amount_total'] = res[invoice.id]['amount_tax'] + res[invoice.id]['amount_untaxed']
         return res
 
     def _get_journal(self, cr, uid, context):
@@ -118,6 +113,12 @@ class account_invoice(osv.osv):
                 res[id]=[x for x in l if x <> line.id]
         return res
 
+    def _get_invoice_tax(self, cr, uid, ids, context={}):
+        result = {}
+        for tax in self.pool.get('account.invoice.tax').browse(cr, uid, ids, context=context):
+            result[tax.invoice_id.id] = True
+        return result.keys()
+
     def _compute_lines(self, cr, uid, ids, name, args, context={}):
         result = {}
         for invoice in self.browse(cr, uid, ids, context):
@@ -178,14 +179,30 @@ class account_invoice(osv.osv):
         'tax_line': fields.one2many('account.invoice.tax', 'invoice_id', 'Tax Lines', readonly=True, states={'draft':[('readonly',False)]}),
 
         'move_id': fields.many2one('account.move', 'Invoice Movement', readonly=True, help="Link to the automatically generated account moves."),
-        'amount_untaxed': fields.function(_amount_untaxed, method=True, digits=(16,2),string='Untaxed', store=True),
-        'amount_tax': fields.function(_amount_tax, method=True, digits=(16,2), string='Tax', store=True),
-        'amount_total': fields.function(_amount_total, method=True, digits=(16,2), string='Total', store=True),
+        'amount_untaxed': fields.function(_amount_all, method=True, digits=(16,2),string='Untaxed',
+            store={
+                'account.invoice': (lambda self, cr, uid, ids, c={}: ids, None, 10),
+                'account.invoice.tax': (_get_invoice_tax, None, 10),
+            },
+            multi='all'),
+        'amount_tax': fields.function(_amount_all, method=True, digits=(16,2), string='Tax',
+            store={
+                'account.invoice': (lambda self, cr, uid, ids, c={}: ids, None, 10),
+                'account.invoice.tax': (_get_invoice_tax, None, 10),
+            },
+            multi='all'),
+        'amount_total': fields.function(_amount_all, method=True, digits=(16,2), string='Total',
+            store={
+                'account.invoice': (lambda self, cr, uid, ids, c={}: ids, None, 10),
+                'account.invoice.tax': (_get_invoice_tax, None, 10),
+            },
+            multi='all'),
         'currency_id': fields.many2one('res.currency', 'Currency', required=True, readonly=True, states={'draft':[('readonly',False)]}),
         'journal_id': fields.many2one('account.journal', 'Journal', required=True,readonly=True, states={'draft':[('readonly',False)]}),
         'company_id': fields.many2one('res.company', 'Company', required=True),
         'check_total': fields.float('Total', digits=(16,2), states={'open':[('readonly',True)],'close':[('readonly',True)]}),
-        'reconciled': fields.function(_reconciled, method=True, string='Paid/Reconciled', type='boolean', store=True, help="The account moves of the invoice have been reconciled with account moves of the payment(s)."),
+        'reconciled': fields.function(_reconciled, method=True, string='Paid/Reconciled', type='boolean',
+            store=True, help="The account moves of the invoice have been reconciled with account moves of the payment(s)."),
         'partner_bank': fields.many2one('res.partner.bank', 'Bank Account',
             help='The bank account to pay to or to be paid from'),
         'move_lines':fields.function(_get_lines , method=True,type='many2many' , relation='account.move.line',string='Move Lines'),
diff --git a/addons/account_tax_include/invoice_tax_incl.py b/addons/account_tax_include/invoice_tax_incl.py
index 66ec0ecf0a5..be2c1e37a27 100644
--- a/addons/account_tax_include/invoice_tax_incl.py
+++ b/addons/account_tax_include/invoice_tax_incl.py
@@ -26,42 +26,12 @@ from osv import fields, osv
 import ir
 
 class account_invoice(osv.osv):
-    def _amount_untaxed(self, cr, uid, ids, name, args, context={}):
-        res = {}
-        for invoice in self.browse(cr,uid,ids):
-            if invoice.price_type == 'tax_included':
-                res[invoice.id] = reduce( lambda x, y: x+y.price_subtotal, invoice.invoice_line,0)
-            else:
-                res[invoice.id] = super(account_invoice, self)._amount_untaxed(cr, uid, [invoice.id], name, args, context)[invoice.id]
-        return res
-
-    def _amount_tax(self, cr, uid, ids, name, args, context={}):
-        res = {}
-        for invoice in self.browse(cr,uid,ids):
-            if invoice.price_type == 'tax_included':
-                res[invoice.id] = reduce( lambda x, y: x+y.amount, invoice.tax_line,0)
-            else:
-                res[invoice.id] = super(account_invoice, self)._amount_tax(cr, uid, [invoice.id], name, args, context)[invoice.id]
-        return res
-
-    def _amount_total(self, cr, uid, ids, name, args, context={}):
-        res = {}
-        for invoice in self.browse(cr,uid,ids):
-            if invoice.price_type == 'tax_included':
-                res[invoice.id]= invoice.amount_untaxed + invoice.amount_tax
-            else:
-                res[invoice.id] = super(account_invoice, self)._amount_total(cr, uid, [invoice.id], name, args, context)[invoice.id]
-        return res
-
     _inherit = "account.invoice"
     _columns = {
         'price_type': fields.selection([('tax_included','Tax included'),
                                         ('tax_excluded','Tax excluded')],
                                         'Price method', required=True, readonly=True,
                                         states={'draft':[('readonly',False)]}),
-        'amount_untaxed': fields.function(_amount_untaxed, digits=(16,2), method=True,string='Untaxed Amount'),
-        'amount_tax': fields.function(_amount_tax, method=True, string='Tax', store=True),
-        'amount_total': fields.function(_amount_total, method=True, string='Total', store=True),
     }
     _defaults = {
         'price_type': lambda *a: 'tax_excluded',
@@ -70,47 +40,51 @@ account_invoice()
 
 class account_invoice_line(osv.osv):
     _inherit = "account.invoice.line"
-    def _amount_line(self, cr, uid, ids, name, args, context={}):
+    def _amount_line2(self, cr, uid, ids, name, args, context={}):
         """
         Return the subtotal excluding taxes with respect to price_type.
         """
         res = {}
         tax_obj = self.pool.get('account.tax')
-        res = super(account_invoice_line, self)._amount_line(cr, uid, ids, name, args, context)
-        res2 = res.copy()
+        res_init = super(account_invoice_line, self)._amount_line(cr, uid, ids, name, args, context)
         for line in self.browse(cr, uid, ids):
+            res[line.id] = {
+                'price_subtotal': 0.0,
+                'price_subtotal_incl': 0.0,
+                'data': []
+            }
             if not line.quantity:
-                res[line.id] = 0.0
                 continue
             if line.invoice_id and line.invoice_id.price_type == 'tax_included':
-                product_taxes = None
+                product_taxes = []
                 if line.product_id:
                     if line.invoice_id.type in ('out_invoice', 'out_refund'):
-                        product_taxes = line.product_id.taxes_id
+                        product_taxes = filter(lambda x: x.price_include, line.product_id.taxes_id)
                     else:
-                        product_taxes = line.product_id.supplier_taxes_id
-                if product_taxes:
-                    for tax in tax_obj.compute_inv(cr, uid, product_taxes, res[line.id]/line.quantity, line.quantity):
-                        res[line.id] = res[line.id] - round(tax['amount'], 2)
+                        product_taxes = filter(lambda x: x.price_include, line.product_id.supplier_taxes_id)
+
+                if (set(product_taxes) == set(line.invoice_line_tax_id)) or not product_taxes:
+                    res[line.id]['price_subtotal_incl'] = res_init[line.id]
                 else:
-                    for tax in tax_obj.compute_inv(cr, uid,line.invoice_line_tax_id, res[line.id]/line.quantity, line.quantity):
-                        res[line.id] = res[line.id] - round(tax['amount'], 2)
-            if name == 'price_subtotal_incl' and line.invoice_id and line.invoice_id.price_type == 'tax_included':
-                prod_taxe_ids = None
-                line_taxe_ids = None
-                if product_taxes:
-                    prod_taxe_ids = [ t.id for t in product_taxes ]
-                    prod_taxe_ids.sort()
-                    line_taxe_ids = [ t.id for t in line.invoice_line_tax_id ]
-                    line_taxe_ids.sort()
-                if product_taxes and prod_taxe_ids == line_taxe_ids:
-                    res[line.id] = res2[line.id]
-                elif not line.product_id:
-                    res[line.id] = res2[line.id]
-                else:
-                    for tax in tax_obj.compute(cr, uid, line.invoice_line_tax_id, res[line.id]/line.quantity, line.quantity):
-                        res[line.id] = res[line.id] + tax['amount']
-            res[line.id]= round(res[line.id], 2)
+                    res[line.id]['price_subtotal'] = res_init[line.id]
+                    for tax in tax_obj.compute_inv(cr, uid, product_taxes, res_init[line.id]/line.quantity, line.quantity):
+                        res[line.id]['price_subtotal'] = res[line.id]['price_subtotal'] - round(tax['amount'], 2)
+            else:
+                res[line.id]['price_subtotal'] = res_init[line.id]
+
+            if res[line.id]['price_subtotal']:
+                res[line.id]['price_subtotal_incl'] = res[line.id]['price_subtotal']
+                for tax in tax_obj.compute(cr, uid, line.invoice_line_tax_id, res[line.id]['price_subtotal']/line.quantity, line.quantity):
+                    res[line.id]['price_subtotal_incl'] = res[line.id]['price_subtotal_incl'] + tax['amount']
+                    res[line.id]['data'].append( tax)
+            else:
+                res[line.id]['price_subtotal'] = res[line.id]['price_subtotal_incl']
+                for tax in tax_obj.compute_inv(cr, uid, line.invoice_line_tax_id, res[line.id]['price_subtotal_incl']/line.quantity, line.quantity):
+                    res[line.id]['price_subtotal'] = res[line.id]['price_subtotal'] - tax['amount']
+                    res[line.id]['data'].append( tax)
+
+        res[line.id]['price_subtotal']= round(res[line.id]['price_subtotal'], 2)
+        res[line.id]['price_subtotal_incl']= round(res[line.id]['price_subtotal_incl'], 2)
         return res
 
     def _price_unit_default(self, cr, uid, context={}):
@@ -125,9 +99,17 @@ class account_invoice_line(osv.osv):
             return super(account_invoice_line, self)._price_unit_default(cr, uid, context)
         return 0
 
+    def _get_invoice(self, cr, uid, ids, context):
+        result = {}
+        for inv in self.pool.get('account.invoice').browse(cr, uid, ids, context=context):
+            for line in inv.invoice_line:
+                result[line.id] = True
+        return result.keys()
     _columns = {
-        'price_subtotal': fields.function(_amount_line, method=True, string='Subtotal w/o tax', store=True),
-        'price_subtotal_incl': fields.function(_amount_line, method=True, string='Subtotal'),
+        'price_subtotal': fields.function(_amount_line2, method=True, string='Subtotal w/o tax', multi='amount',
+            store={'account.invoice':(_get_invoice,None), 'account.invoice.line': (lambda self,cr,uid,ids,c={}: ids, None)}),
+        'price_subtotal_incl': fields.function(_amount_line2, method=True, string='Subtotal', multi='amount',
+            store={'account.invoice':(_get_invoice,None), 'account.invoice.line': (lambda self,cr,uid,ids,c={}: ids, None)}),
     }
 
     _defaults = {
@@ -147,32 +129,36 @@ class account_invoice_line(osv.osv):
                 'account_analytic_id':line.account_analytic_id.id,
             }
 
-    def product_id_change_unit_price_inv(self, cr, uid, tax_id, price_unit, qty, address_invoice_id, product, partner_id, context={}):
-        if context.get('price_type', False) == 'tax_included':
-            return {'price_unit': price_unit,'invoice_line_tax_id': tax_id}
-        else:
-            return super(account_invoice_line, self).product_id_change_unit_price_inv(cr, uid, tax_id, price_unit, qty, address_invoice_id, product, partner_id, context=context)
-
-    def product_id_change(self, cr, uid, ids, product, uom, qty=0, name='', type='out_invoice', partner_id=False, price_unit=False, address_invoice_id=False, price_type='tax_excluded', context={}):
-        context.update({'price_type': price_type})
-        return super(account_invoice_line, self).product_id_change(cr, uid, ids, product, uom, qty, name, type, partner_id, price_unit, address_invoice_id, context=context)
+# TODO: check why ?
+#
+#    def product_id_change_unit_price_inv(self, cr, uid, tax_id, price_unit, qty, address_invoice_id, product, partner_id, context={}):
+#        if context.get('price_type', False) == 'tax_included':
+#            return {'price_unit': price_unit,'invoice_line_tax_id': tax_id}
+#        else:
+#            return super(account_invoice_line, self).product_id_change_unit_price_inv(cr, uid, tax_id, price_unit, qty, address_invoice_id, product, partner_id, context=context)
+#
+#    def product_id_change(self, cr, uid, ids, product, uom, qty=0, name='', type='out_invoice', partner_id=False, price_unit=False, address_invoice_id=False, price_type='tax_excluded', context={}):
+#        context.update({'price_type': price_type})
+#        return super(account_invoice_line, self).product_id_change(cr, uid, ids, product, uom, qty, name, type, partner_id, price_unit, address_invoice_id, context=context)
 account_invoice_line()
 
 class account_invoice_tax(osv.osv):
     _inherit = "account.invoice.tax"
 
-    def compute(self, cr, uid, invoice_id):
+    def compute(self, cr, uid, invoice_id, context={}):
+        inv = self.pool.get('account.invoice').browse(cr, uid, invoice_id)
+        line_ids = map(lambda x: x.id, inv.invoice_line)
+
+
+
         tax_grouped = {}
         tax_obj = self.pool.get('account.tax')
         cur_obj = self.pool.get('res.currency')
-        inv = self.pool.get('account.invoice').browse(cr, uid, invoice_id)
         cur = inv.currency_id
 
-        if inv.price_type=='tax_excluded':
-            return super(account_invoice_tax,self).compute(cr, uid, invoice_id)
-
         for line in inv.invoice_line:
-            for tax in tax_obj.compute_inv(cr, uid, line.invoice_line_tax_id, (line.price_unit * (1-(line.discount or 0.0)/100.0)), line.quantity, inv.address_invoice_id.id, line.product_id, inv.partner_id):
+            data = self.pool.get('account.invoice.line')._amount_line2(cr, uid, [line.id], [], [], context)[line.id]
+            for tax in data['data']:
                 val={}
                 val['invoice_id'] = inv.id
                 val['name'] = tax['name']

From e9ee8121655e88e00639ce760d2b4b39e2ef9709 Mon Sep 17 00:00:00 2001
From: Fabien Pinckaers <fp@tinyerp.com>
Date: Sun, 7 Dec 2008 03:24:43 +0100
Subject: [PATCH 16/24] improve

bzr revid: fp@tinyerp.com-20081207022443-wb8b31izgky1elpa
---
 addons/account_tax_include/invoice_tax_incl.py | 4 ++--
 addons/membership/membership.py                | 2 +-
 addons/mrp_operations/mrp_operations.py        | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/addons/account_tax_include/invoice_tax_incl.py b/addons/account_tax_include/invoice_tax_incl.py
index be2c1e37a27..eee35f75676 100644
--- a/addons/account_tax_include/invoice_tax_incl.py
+++ b/addons/account_tax_include/invoice_tax_incl.py
@@ -107,9 +107,9 @@ class account_invoice_line(osv.osv):
         return result.keys()
     _columns = {
         'price_subtotal': fields.function(_amount_line2, method=True, string='Subtotal w/o tax', multi='amount',
-            store={'account.invoice':(_get_invoice,None), 'account.invoice.line': (lambda self,cr,uid,ids,c={}: ids, None)}),
+            store={'account.invoice':(_get_invoice,['price_type']), 'account.invoice.line': (lambda self,cr,uid,ids,c={}: ids, None)}),
         'price_subtotal_incl': fields.function(_amount_line2, method=True, string='Subtotal', multi='amount',
-            store={'account.invoice':(_get_invoice,None), 'account.invoice.line': (lambda self,cr,uid,ids,c={}: ids, None)}),
+            store={'account.invoice':(_get_invoice,['price_type']), 'account.invoice.line': (lambda self,cr,uid,ids,c={}: ids, None)}),
     }
 
     _defaults = {
diff --git a/addons/membership/membership.py b/addons/membership/membership.py
index ca096a0045f..4c47a5f9187 100644
--- a/addons/membership/membership.py
+++ b/addons/membership/membership.py
@@ -437,7 +437,7 @@ class Partner(osv.osv):
 #       'membership_state': fields.function(_membership_state, method=True, string='Current membership state',
 #           type='selection', selection=STATE, fnct_search=_membership_state_search),
         'membership_state': fields.function(_membership_state, method=True, string='Current membership state',
-            type='selection',selection=STATE,store={'account.invoice':(['state'],_membership_state_search_inv)}),
+            type='selection',selection=STATE,store={'account.invoice':(_membership_state_search_inv,['state'])}),
 #       'associate_member': fields.many2one('res.partner', 'Associate member'),
         'free_member': fields.boolean('Free member'),
         'membership_start': fields.function(_membership_start, method=True,
diff --git a/addons/mrp_operations/mrp_operations.py b/addons/mrp_operations/mrp_operations.py
index 789236def0b..26c96f32d43 100755
--- a/addons/mrp_operations/mrp_operations.py
+++ b/addons/mrp_operations/mrp_operations.py
@@ -294,7 +294,7 @@ class mrp_operations_operation(osv.osv):
         'code_id':fields.many2one('mrp_operations.operation.code','Code',required=True),
         'date_start': fields.datetime('Start Date'),
         'date_finished': fields.datetime('End Date'),
-        'order_date': fields.function(_get_order_date,method=True,string='Order Date',type='date',store={'mrp.production':(['date_planned'],_order_date_search_production)}),
+        'order_date': fields.function(_get_order_date,method=True,string='Order Date',type='date',store={'mrp.production':(_order_date_search_production,['date_planned'])}),
         }
     _defaults={
               'date_start': lambda *a:DateTime.now().strftime('%Y-%m-%d %H:%M:%S')

From 429afac3cc72ef82bf6a51a13059259a8c6b005b Mon Sep 17 00:00:00 2001
From: Fabien Pinckaers <fp@tinyerp.com>
Date: Sun, 7 Dec 2008 03:45:43 +0100
Subject: [PATCH 17/24] improve

bzr revid: fp@tinyerp.com-20081207024543-o6qegm8gzs8s0l63
---
 addons/account/invoice.py                      | 7 ++++++-
 addons/account_tax_include/invoice_tax_incl.py | 4 ++--
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/addons/account/invoice.py b/addons/account/invoice.py
index a67653b8d55..fa4cde66bdf 100644
--- a/addons/account/invoice.py
+++ b/addons/account/invoice.py
@@ -206,7 +206,12 @@ class account_invoice(osv.osv):
         'partner_bank': fields.many2one('res.partner.bank', 'Bank Account',
             help='The bank account to pay to or to be paid from'),
         'move_lines':fields.function(_get_lines , method=True,type='many2many' , relation='account.move.line',string='Move Lines'),
-        'residual': fields.function(_amount_residual, method=True, digits=(16,2),string='Residual', store=True, help="Remaining amount due."),
+        'residual': fields.function(_amount_residual, method=True, digits=(16,2),string='Residual',
+            store={
+                'account.invoice': (lambda self, cr, uid, ids, c={}: ids, None, 12),
+                'account.invoice.tax': (_get_invoice_tax, None, 12),
+            },
+            help="Remaining amount due."),
         'payment_ids': fields.function(_compute_lines, method=True, relation='account.move.line', type="many2many", string='Payments'),
         'move_name': fields.char('Account Move', size=64),
     }
diff --git a/addons/account_tax_include/invoice_tax_incl.py b/addons/account_tax_include/invoice_tax_incl.py
index eee35f75676..68b4a944966 100644
--- a/addons/account_tax_include/invoice_tax_incl.py
+++ b/addons/account_tax_include/invoice_tax_incl.py
@@ -55,7 +55,7 @@ class account_invoice_line(osv.osv):
             }
             if not line.quantity:
                 continue
-            if line.invoice_id and line.invoice_id.price_type == 'tax_included':
+            if line.invoice_id:
                 product_taxes = []
                 if line.product_id:
                     if line.invoice_id.type in ('out_invoice', 'out_refund'):
@@ -63,7 +63,7 @@ class account_invoice_line(osv.osv):
                     else:
                         product_taxes = filter(lambda x: x.price_include, line.product_id.supplier_taxes_id)
 
-                if (set(product_taxes) == set(line.invoice_line_tax_id)) or not product_taxes:
+                if ((set(product_taxes) == set(line.invoice_line_tax_id)) or not product_taxes) and (line.invoice_id.price_type == 'tax_included'):
                     res[line.id]['price_subtotal_incl'] = res_init[line.id]
                 else:
                     res[line.id]['price_subtotal'] = res_init[line.id]

From f8842554a8b069f9e2feca52029d8c2500dd1a7b Mon Sep 17 00:00:00 2001
From: Fabien Pinckaers <fp@tinyerp.com>
Date: Sun, 7 Dec 2008 04:06:16 +0100
Subject: [PATCH 18/24] improve

bzr revid: fp@tinyerp.com-20081207030616-48t5jpfe3kn606r2
---
 addons/account_followup/report/rappel.rml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/addons/account_followup/report/rappel.rml b/addons/account_followup/report/rappel.rml
index 328e9645e5b..5f05a2b9628 100644
--- a/addons/account_followup/report/rappel.rml
+++ b/addons/account_followup/report/rappel.rml
@@ -106,11 +106,11 @@
     <para style="P18">
       <font color="white"> </font>
     </para>
-    <para style="P18">Exception made if there was a mistake of ours, it seems that the following bills staid unpaid. Please, take appropriate measures in order to carry out this payment in the next 8 days.</para>
+    <para style="P18">According to our accounting, the following Invoices are unpaid. Could you please verify on your side, and take appropriate measures to pay the balance due in the next 8 days.</para>
     <para style="P18">
       <font color="white"> </font>
     </para>
-    <para style="P18">Would your payment have been carried out after this mail was sent, please consider the present one as void. Do not hesitate to contact our accounting departement at (+32).10.68.94.39.</para>
+    <para style="P18">If the payment has been very recently made i.e. as this reminder was issued, consider this reminder as void. Do not hesitate to contact our accounting department for further queries.</para>
     <para style="P18">
       <font color="white"> </font>
     </para>

From 75019e2eabe8f989ad9dbf9a9881cdf17009675c Mon Sep 17 00:00:00 2001
From: Fabien Pinckaers <fp@tinyerp.com>
Date: Sun, 7 Dec 2008 13:45:27 +0100
Subject: [PATCH 20/24] bugfixes

bzr revid: fp@tinyerp.com-20081207124527-q60i5wo0ymhd3u4o
---
 addons/account/invoice.py |  9 +++++++
 addons/sale/sale.py       | 52 +++++++++++++++++----------------------
 2 files changed, 32 insertions(+), 29 deletions(-)

diff --git a/addons/account/invoice.py b/addons/account/invoice.py
index fa4cde66bdf..40191d48a91 100644
--- a/addons/account/invoice.py
+++ b/addons/account/invoice.py
@@ -113,6 +113,12 @@ class account_invoice(osv.osv):
                 res[id]=[x for x in l if x <> line.id]
         return res
 
+    def _get_invoice_line(self, cr, uid, ids, context={}):
+        result = {}
+        for tax in self.pool.get('account.invoice.line').browse(cr, uid, ids, context=context):
+            result[tax.invoice_id.id] = True
+        return result.keys()
+
     def _get_invoice_tax(self, cr, uid, ids, context={}):
         result = {}
         for tax in self.pool.get('account.invoice.tax').browse(cr, uid, ids, context=context):
@@ -183,18 +189,21 @@ class account_invoice(osv.osv):
             store={
                 'account.invoice': (lambda self, cr, uid, ids, c={}: ids, None, 10),
                 'account.invoice.tax': (_get_invoice_tax, None, 10),
+                'account.invoice.line': (_get_invoice_line, None, 10),
             },
             multi='all'),
         'amount_tax': fields.function(_amount_all, method=True, digits=(16,2), string='Tax',
             store={
                 'account.invoice': (lambda self, cr, uid, ids, c={}: ids, None, 10),
                 'account.invoice.tax': (_get_invoice_tax, None, 10),
+                'account.invoice.line': (_get_invoice_line, None, 10),
             },
             multi='all'),
         'amount_total': fields.function(_amount_all, method=True, digits=(16,2), string='Total',
             store={
                 'account.invoice': (lambda self, cr, uid, ids, c={}: ids, None, 10),
                 'account.invoice.tax': (_get_invoice_tax, None, 10),
+                'account.invoice.line': (_get_invoice_line, None, 10),
             },
             multi='all'),
         'currency_id': fields.many2one('res.currency', 'Currency', required=True, readonly=True, states={'draft':[('readonly',False)]}),
diff --git a/addons/sale/sale.py b/addons/sale/sale.py
index 598f22151d3..494891dd2cd 100644
--- a/addons/sale/sale.py
+++ b/addons/sale/sale.py
@@ -60,38 +60,29 @@ class sale_order(osv.osv):
         })
         return super(sale_order, self).copy(cr, uid, id, default, context)
 
-    def _amount_untaxed(self, cr, uid, ids, field_name, arg, context):
-        res = {}
-        cur_obj=self.pool.get('res.currency')
-        for sale in self.browse(cr, uid, ids):
-            res[sale.id] = 0.0
-            for line in sale.order_line:
-                res[sale.id] += line.price_subtotal
-            cur = sale.pricelist_id.currency_id
-            res[sale.id] = cur_obj.round(cr, uid, cur, res[sale.id])
-        return res
+    def _amount_line_tax(self, cr, uid, line, context={}):
+        val = 0.0
+        for c in self.pool.get('account.tax').compute(cr, uid, line.tax_id, line.price_unit * (1-(line.discount or 0.0)/100.0), line.product_uom_qty, line.order_id.partner_invoice_id.id, line.product_id, line.order_id.partner_id):
+            val+= c['amount']
+        return val
 
-    def _amount_tax(self, cr, uid, ids, field_name, arg, context):
+    def _amount_all(self, cr, uid, ids, field_name, arg, context):
         res = {}
         cur_obj=self.pool.get('res.currency')
         for order in self.browse(cr, uid, ids):
-            val = 0.0
+            res[order.id] = {
+                'amount_untaxed': 0.0,
+                'amount_tax': 0.0,
+                'amount_total': 0.0,
+            }
+            val = val1 = 0.0
             cur=order.pricelist_id.currency_id
             for line in order.order_line:
-                for c in self.pool.get('account.tax').compute(cr, uid, line.tax_id, line.price_unit * (1-(line.discount or 0.0)/100.0), line.product_uom_qty, order.partner_invoice_id.id, line.product_id, order.partner_id):
-                    val+= c['amount']
-            res[order.id]=cur_obj.round(cr, uid, cur, val)
-        return res
-
-    def _amount_total(self, cr, uid, ids, field_name, arg, context):
-        res = {}
-        untax = self._amount_untaxed(cr, uid, ids, field_name, arg, context)
-        tax = self._amount_tax(cr, uid, ids, field_name, arg, context)
-        cur_obj=self.pool.get('res.currency')
-        for id in ids:
-            order=self.browse(cr, uid, [id])[0]
-            cur=order.pricelist_id.currency_id
-            res[id] = cur_obj.round(cr, uid, cur, untax.get(id, 0.0) + tax.get(id, 0.0))
+                val1 += line.price_subtotal
+                val += self._amount_line_tax(cr, uid, line, context)
+            res[order.id]['amount_tax']=cur_obj.round(cr, uid, cur, val)
+            res[order.id]['amount_untaxed']=cur_obj.round(cr, uid, cur, val1)
+            res[order.id]['amount_total']=res[order.id]['amount_untaxed'] + res[order.id]['amount_tax']
         return res
 
     def _picked_rate(self, cr, uid, ids, name, arg, context=None):
@@ -231,9 +222,12 @@ class sale_order(osv.osv):
         'invoiced': fields.function(_invoiced, method=True, string='Paid',
             fnct_search=_invoiced_search, type='boolean'),
         'note': fields.text('Notes'),
-        'amount_untaxed': fields.function(_amount_untaxed, method=True, string='Untaxed Amount'),
-        'amount_tax': fields.function(_amount_tax, method=True, string='Taxes', store=True),
-        'amount_total': fields.function(_amount_total, method=True, string='Total', store=True),
+
+        'amount_untaxed': fields.function(_amount_all, method=True, string='Untaxed Amount',
+            store=True, multi='sums'),
+        'amount_tax': fields.function(_amount_all, method=True, string='Taxes', store=True, multi='sums'),
+        'amount_total': fields.function(_amount_all, method=True, string='Total', store=True, multi='sums'),
+
         'invoice_quantity': fields.selection([('order','Ordered Quantities'),('procurement','Shipped Quantities')], 'Invoice on', help="The sale order will automatically create the invoice proposition (draft invoice). Ordered and delivered quantities may not be the same. You have to choose if you invoice based on ordered or shipped quantities. If the product is a service, shipped quantities means hours spent on the associated tasks.",required=True),
         'payment_term' : fields.many2one('account.payment.term', 'Payment Term'),
     }

From dc3cb6c1a5d44f0db55c01e007d129dc9122ce63 Mon Sep 17 00:00:00 2001
From: Fabien Pinckaers <fp@tinyerp.com>
Date: Sun, 7 Dec 2008 14:06:32 +0100
Subject: [PATCH 21/24] bugfix_305746

bzr revid: fp@tinyerp.com-20081207130632-lhj85qmo7zgdfye0
---
 addons/account/account_bank_statement.py   |  2 +-
 addons/mrp/schedulers.py                   | 39 ++++++++++------------
 addons/mrp/wizard/wizard_schedulers_all.py |  2 +-
 3 files changed, 20 insertions(+), 23 deletions(-)

diff --git a/addons/account/account_bank_statement.py b/addons/account/account_bank_statement.py
index e28edc87f4a..a1d47dd027d 100644
--- a/addons/account/account_bank_statement.py
+++ b/addons/account/account_bank_statement.py
@@ -66,7 +66,7 @@ class account_bank_statement(osv.osv):
                 else:
                     if line.account_id.id == \
                             statement.journal_id.default_credit_account_id.id:
-                        res[statement.id] += res_currency_obj.compute(cursor,
+                        res[statement.id] -= res_currency_obj.compute(cursor,
                                 user, company_currency_id, currency_id,
                                 line.credit, context=context)
             if statement.state == 'draft':
diff --git a/addons/mrp/schedulers.py b/addons/mrp/schedulers.py
index cd1ddcd341e..a15cc9c42c7 100644
--- a/addons/mrp/schedulers.py
+++ b/addons/mrp/schedulers.py
@@ -132,40 +132,37 @@ class mrp_procurement(osv.osv):
         warehouse_obj = self.pool.get('stock.warehouse')
         wf_service = netsvc.LocalService("workflow")
 
-        cr.execute('select id from stock_warehouse')
-        warehouses = [x for x, in cr.fetchall()]
+        warehouse_ids = warehouse_obj.search(cr, uid, [], context=context)
+
         cr.execute('select id from product_product')
         products_id = [x for x, in cr.fetchall()]
-        products = dict(zip(products_id, product_obj.browse(cr, uid, products_id, context)))
-        for warehouse in warehouses:
-            v_stock = product_obj._product_virtual_available(cr, uid, products_id, None, {'warehouse': warehouse})
-            cr.execute("select lot_stock_id from stock_warehouse")
-            location_ids_str = ','.join([str(id) for id, in cr.fetchall()])
-            stock_locations = warehouse_obj.read(cr, uid, [warehouse], ['lot_input_id', 'lot_stock_id'])[0]
-            for prod_id, available in v_stock.items():
-                if available >= 0:
+
+        for warehouse in warehouse_obj.browse(cr, uid, warehouse_ids, context=context):
+            context['warehouse'] = warehouse
+            for product in self.pool.get('product.product').browse(cr, uid, products_id, context=context):
+                if product.virtual_available>=0.0:
                     continue
-                newdate = DateTime.now() + DateTime.RelativeDateTime(days=products[prod_id].seller_delay)
-                if products[prod_id].supply_method == 'buy':
-                    location_id = stock_locations['lot_input_id'][0]
-                elif products[prod_id].supply_method == 'produce':
-                    location_id = stock_locations['lot_stock_id'][0]
+
+                newdate = DateTime.now()
+                if product.supply_method == 'buy':
+                    location_id = warehouse.lot_input_id.id
+                elif product.supply_method == 'produce':
+                    location_id = warehouse.lot_stock_id.id
                 else:
                     continue
                 proc_id = proc_obj.create(cr, uid, {
-                    'name': 'PROC:Automatic OP for product:%s' % products[prod_id].name,
+                    'name': 'PROC:Automatic OP for product:%s' % product.name,
                     'origin': 'SCHEDULER',
-                    'date_planned': newdate.strftime('%Y-%m-%d'),
-                    'product_id': prod_id,
-                    'product_qty': -available,
-                    'product_uom': products[prod_id].uom_id.id,
+                    'date_planned': newdate.strftime('%Y-%m-%d %H:%M:%S'),
+                    'product_id': product.id,
+                    'product_qty': -product.virtual_available,
+                    'product_uom': product.uom_id.id,
                     'location_id': location_id,
                     'procure_method': 'make_to_order',
                     })
                 wf_service.trg_validate(uid, 'mrp.procurement', proc_id, 'button_confirm', cr)
                 wf_service.trg_validate(uid, 'mrp.procurement', proc_id, 'button_check', cr)
 
-
     def _procure_orderpoint_confirm(self, cr, uid, automatic=False,\
             use_new_cursor=False, context=None, user_id=False):
         '''
diff --git a/addons/mrp/wizard/wizard_schedulers_all.py b/addons/mrp/wizard/wizard_schedulers_all.py
index a21ac3e38fe..d2ca06c5e53 100644
--- a/addons/mrp/wizard/wizard_schedulers_all.py
+++ b/addons/mrp/wizard/wizard_schedulers_all.py
@@ -30,7 +30,7 @@ parameter_form = '''<?xml version="1.0"?>
 </form>'''
 
 parameter_fields = {
-    'automatic': {'string': 'Automatic orderpoint', 'type': 'boolean', 'help': 'Triggers an automatic procurement for all products that have a virtual stock under 0.', 'default': lambda *a: False},
+    'automatic': {'string': 'Automatic orderpoint', 'type': 'boolean', 'help': 'Triggers an automatic procurement for all products that have a virtual stock under 0. You should probably not use this option, we suggest using a MTO configuration on products.', 'default': lambda *a: False},
 }
 
 def _procure_calculation_all(self, db_name, uid, data, context):

From 3b415259d65801c3cd1bdb899ec622f447aaf973 Mon Sep 17 00:00:00 2001
From: Fabien Pinckaers <fp@tinyerp.com>
Date: Sun, 7 Dec 2008 14:13:06 +0100
Subject: [PATCH 22/24] modified_terp_voucher

bzr revid: fp@tinyerp.com-20081207131306-vb41zmoz2hsac3p5
---
 addons/account_voucher/__terp__.py | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/addons/account_voucher/__terp__.py b/addons/account_voucher/__terp__.py
index 8b63b59102a..9696cc5c65c 100755
--- a/addons/account_voucher/__terp__.py
+++ b/addons/account_voucher/__terp__.py
@@ -20,13 +20,12 @@
 #
 ##############################################################################
 {
-    "name" : "India Accounting",
+    "name" : "Accounting - Voucher Management",
     "version" : "1.0",
     "author" : "Tiny",
     "description": """
-    India Accounting module includes all the basic requirenment of 
-    Basic Accounting, plus new things which available are 
-    * Indian Account Chart
+India Accounting module includes all the basic requirenment of 
+Basic Accounting, plus new things which available are:
     * New Invoice - (Local, Retail)
     * Invoice Report
     * Tax structure
@@ -51,4 +50,4 @@
     ],
     "active": False,
     "installable": True
-}
\ No newline at end of file
+}

From aec0dafa1712a16c3208ebfec398b05224bbaaff Mon Sep 17 00:00:00 2001
From: Fabien Pinckaers <fp@tinyerp.com>
Date: Mon, 8 Dec 2008 08:56:41 +0100
Subject: [PATCH 23/24] modifs

bzr revid: fp@tinyerp.com-20081208075641-3i3clllhoa8u180n
---
 addons/account/invoice.py   | 9 ++++++---
 addons/document/document.py | 1 -
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/addons/account/invoice.py b/addons/account/invoice.py
index 40191d48a91..e60c04d9851 100644
--- a/addons/account/invoice.py
+++ b/addons/account/invoice.py
@@ -33,7 +33,8 @@ from tools.translate import _
 class account_invoice(osv.osv):
     def _amount_all(self, cr, uid, ids, name, args, context={}):
         res = {}
-        for invoice in self.browse(cr,uid,ids):
+        print ids
+        for invoice in self.browse(cr,uid,ids, context=context):
             res[invoice.id] = {
                 'amount_untaxed': 0.0,
                 'amount_tax': 0.0,
@@ -115,8 +116,10 @@ class account_invoice(osv.osv):
 
     def _get_invoice_line(self, cr, uid, ids, context={}):
         result = {}
-        for tax in self.pool.get('account.invoice.line').browse(cr, uid, ids, context=context):
-            result[tax.invoice_id.id] = True
+        for line in self.pool.get('account.invoice.line').browse(cr, uid, ids, context=context):
+            print '\t', line.invoice_id
+            result[line.invoice_id.id] = True
+        print result
         return result.keys()
 
     def _get_invoice_tax(self, cr, uid, ids, context={}):
diff --git a/addons/document/document.py b/addons/document/document.py
index 942eefb2682..84c70b56c30 100644
--- a/addons/document/document.py
+++ b/addons/document/document.py
@@ -94,7 +94,6 @@ class node_class(object):
                     if test_nodename.find('/'):
                         test_nodename=test_nodename.replace('/', '_')
                     path = self.path+'/'+test_nodename
-                    #path = self.path+'/'+self.object2.name + (content.suffix or '') + (content.extension or '')
                     if not nodename:
                         n = node_class(self.cr, self.uid,path, self.object2, False, content=content, type='content', root=False)
                         res2.append( n)

From 66b97cdc419da3125ea982c83c8eabfaec45c3b3 Mon Sep 17 00:00:00 2001
From: Fabien Pinckaers <fp@tinyerp.com>
Date: Mon, 8 Dec 2008 12:48:14 +0100
Subject: [PATCH 24/24] removed_unused_file

bzr revid: fp@tinyerp.com-20081208114814-rus1b6tfqfdj7xac
---
 addons/sale/__init__.py |  1 -
 addons/sale/partner.py  | 34 ----------------------------------
 2 files changed, 35 deletions(-)
 delete mode 100644 addons/sale/partner.py

diff --git a/addons/sale/__init__.py b/addons/sale/__init__.py
index fc825d7ac2a..83fd6ab23b1 100644
--- a/addons/sale/__init__.py
+++ b/addons/sale/__init__.py
@@ -26,7 +26,6 @@
 
 import sale
 import stock
-import partner
 import product
 
 import wizard
diff --git a/addons/sale/partner.py b/addons/sale/partner.py
deleted file mode 100644
index 000408cf40c..00000000000
--- a/addons/sale/partner.py
+++ /dev/null
@@ -1,34 +0,0 @@
-# -*- encoding: utf-8 -*-
-##############################################################################
-#
-#    OpenERP, Open Source Management Solution	
-#    Copyright (C) 2004-2008 Tiny SPRL (<http://tiny.be>). All Rights Reserved
-#    $Id$
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU General Public License as published by
-#    the Free Software Foundation, either version 3 of the License, or
-#    (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-##############################################################################
-
-from osv import fields, osv
-
-
-#class res_partner(osv.osv):
-#    _name = 'res.partner'
-#    _inherit = 'res.partner'
-#    _columns = {
-#        'sales': fields.one2many('sale.order', 'partner_id', 'Sales'),
-#    }
-#
-#res_partner()
-#