From 4c95e5f753d358fdcd418639d996b44a94e05a5a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexandre=20K=C3=BChn?= Date: Mon, 30 May 2022 09:09:07 +0000 Subject: [PATCH] [FIX] mail: no traceback on change checkbox of suggested recipient MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Follow-up of #91671 (Task-2817547) Changes above fixed an issue with composer suggested recipient feature not properly prompting a dialog to create new partners. The fix was correct before #90678 (Task-2831082/Task-2849934), but it needs to be slightly adapted for this small technical changes. By omiting them, any change of checkbox state results in a crash. This commit properly adapt code in `_onChangeCheckbox` to take into account both changes. closes odoo/odoo#92408 Signed-off-by: Sébastien Theys (seb) --- .../composer_suggested_recipient.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/addons/mail/static/src/components/composer_suggested_recipient/composer_suggested_recipient.js b/addons/mail/static/src/components/composer_suggested_recipient/composer_suggested_recipient.js index 22f5e9d91c5..b1144fd9b3b 100644 --- a/addons/mail/static/src/components/composer_suggested_recipient/composer_suggested_recipient.js +++ b/addons/mail/static/src/components/composer_suggested_recipient/composer_suggested_recipient.js @@ -70,11 +70,11 @@ export class ComposerSuggestedRecipient extends Component { const adapterParent = standaloneAdapter({ Component }); const selectCreateDialog = new FormViewDialog(adapterParent, { context: { - active_id: this.suggestedRecipientInfo.thread.id, + active_id: this.composerSuggestedRecipientView.suggestedRecipientInfo.thread.id, active_model: 'mail.compose.message', - default_email: this.suggestedRecipientInfo.email, - default_name: this.suggestedRecipientInfo.name, - default_lang: this.suggestedRecipientInfo.lang, + default_email: this.composerSuggestedRecipientView.suggestedRecipientInfo.email, + default_name: this.composerSuggestedRecipientView.suggestedRecipientInfo.name, + default_lang: this.composerSuggestedRecipientView.suggestedRecipientInfo.lang, force_email: true, ref: 'compound_context', }, @@ -82,7 +82,7 @@ export class ComposerSuggestedRecipient extends Component { on_saved: this._onDialogSaved.bind(this), res_id: false, res_model: 'res.partner', - title: this.suggestedRecipientInfo.dialogText, + title: this.composerSuggestedRecipientView.suggestedRecipientInfo.dialogText, }); selectCreateDialog.open(); }