From 0694c25836f54fde3f5fbf1f51f6ca3f028a5a14 Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@openerp.com>
Date: Wed, 18 Jan 2012 11:40:15 +0100
Subject: [PATCH 1/9] [FIX] convert XML documents to HTML in MSIE so jQuery
 does not bork its parsing

done via DOM traversal, slow as shit and currently drops half the attributes

bzr revid: xmo@openerp.com-20120118104015-ot102e8yniqjd4bf
---
 addons/web/static/lib/qweb/qweb2.js | 51 +++++++++++++++++++----------
 1 file changed, 34 insertions(+), 17 deletions(-)

diff --git a/addons/web/static/lib/qweb/qweb2.js b/addons/web/static/lib/qweb/qweb2.js
index 8657a8b20be..7dcac2e5909 100644
--- a/addons/web/static/lib/qweb/qweb2.js
+++ b/addons/web/static/lib/qweb/qweb2.js
@@ -93,10 +93,10 @@ var QWeb2 = {
                 }
                 return r.join('');
             } else {
-                if (node.xml !== undefined) {
-                    return node.xml;
-                } else {
+                if (typeof XMLSerializer !== 'undefined') {
                     return (new XMLSerializer()).serializeToString(node);
+                } else {
+                    return node.outerHTML;
                 }
             }
         },
@@ -265,11 +265,16 @@ QWeb2.Engine = (function() {
                     }
                     req.open('GET', s, false);
                     req.send(null);
-                    if (req.responseXML) {
-                        if (req.responseXML.documentElement.nodeName == "parsererror") {
-                            return this.tools.exception(req.responseXML.documentElement.childNodes[0].nodeValue);
+                    var xDoc = req.responseXML;
+                    if (xDoc) {
+                        if (xDoc.documentElement.nodeName == "parsererror") {
+                            return this.tools.exception(xDoc.documentElement.childNodes[0].nodeValue);
                         }
-                        return req.responseXML;
+                        if (xDoc.xml !== undefined) {
+                            // MSIE
+                            return this.convert_xml_to_html(xDoc.documentElement);
+                        }
+                        return xDoc;
                     } else {
                         return this.load_xml_string(req.responseText);
                     }
@@ -295,7 +300,27 @@ QWeb2.Engine = (function() {
             xDoc.async = false;
             xDoc.preserveWhiteSpace = true;
             xDoc.loadXML(s);
-            return xDoc;
+            return this.convert_xml_to_html(xDoc.documentElement);
+        },
+        convert_xml_to_html: function (node) {
+            var character_data = {
+                3: document.createTextNode,
+                4: document.createCDATASection,
+                8: document.createComment
+            };
+            if (node.nodeType in character_data) {
+                return character_data[node.nodeType](node.data);
+            }
+
+            var hnode = document.createElement(node.nodeName);
+            for(var i=0, alen=node.attributes.length; i < alen; ++i) {
+                var attr = node.attributes[i];
+                hnode.setAttribute(attr.name, attr.value);
+            }
+            for(var j=0, clen=node.childNodes.length; j < clen; ++j) {
+                hnode.appendChild(this.convert_xml_to_html(node.childNodes[j]));
+            }
+            return hnode;
         },
         has_template : function(template) {
             return !!this.templates[template];
@@ -373,12 +398,7 @@ QWeb2.Engine = (function() {
             if (!this.jQuery) {
                 return this.tools.exception("Can't extend template " + template + " without jQuery");
             }
-            var template_dest = this.templates[template],
-                msie_trololo = false;
-            if (template_dest.xml !== undefined) {
-                template_dest = this.jQuery(template_dest.xml);
-                msie_trololo = true;
-            }
+            var template_dest = this.templates[template];
             for (var i = 0, ilen = extend_node.childNodes.length; i < ilen; i++) {
                 var child = extend_node.childNodes[i];
                 if (child.nodeType === 1) {
@@ -421,9 +441,6 @@ QWeb2.Engine = (function() {
                     }
                 }
             }
-            if (msie_trololo) {
-                this.templates[template] = template_dest[0];
-            }
         }
     });
     return Engine;

From 44f4444807ffa6b7641e79a3965aef4628fa5d91 Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@openerp.com>
Date: Wed, 18 Jan 2012 11:46:46 +0100
Subject: [PATCH 2/9] [REM] incorrect link to local jQuery

bzr revid: xmo@openerp.com-20120118104646-2auwjwcr5lag2g5c
---
 addons/web/static/lib/qweb/qweb-test.js.html | 1 -
 1 file changed, 1 deletion(-)

diff --git a/addons/web/static/lib/qweb/qweb-test.js.html b/addons/web/static/lib/qweb/qweb-test.js.html
index fda837497c4..5c08d10d57c 100644
--- a/addons/web/static/lib/qweb/qweb-test.js.html
+++ b/addons/web/static/lib/qweb/qweb-test.js.html
@@ -5,7 +5,6 @@
     <link rel="stylesheet" href="http://code.jquery.com/qunit/git/qunit.css" type="text/css" media="screen"/>
     <script type="text/javascript" src="http://code.jquery.com/qunit/git/qunit.js"></script>
 
-    <script type="text/javascript" src="/base/static/lib/jquery/jquery-1.5.2.js"></script>
     <script type="text/javascript" src="qweb2.js"></script>
 
     <script>

From 45371d6e9c3218c72309b6d137e8fcb7d80750dc Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@openerp.com>
Date: Wed, 18 Jan 2012 11:57:20 +0100
Subject: [PATCH 3/9] [IMP] qweb: switch is shorter than inline object +
 dispatch

bzr revid: xmo@openerp.com-20120118105720-g0zntwfqnxh5j4gf
---
 addons/web/static/lib/qweb/qweb2.js | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/addons/web/static/lib/qweb/qweb2.js b/addons/web/static/lib/qweb/qweb2.js
index 7dcac2e5909..39904d0b33a 100644
--- a/addons/web/static/lib/qweb/qweb2.js
+++ b/addons/web/static/lib/qweb/qweb2.js
@@ -303,13 +303,10 @@ QWeb2.Engine = (function() {
             return this.convert_xml_to_html(xDoc.documentElement);
         },
         convert_xml_to_html: function (node) {
-            var character_data = {
-                3: document.createTextNode,
-                4: document.createCDATASection,
-                8: document.createComment
-            };
-            if (node.nodeType in character_data) {
-                return character_data[node.nodeType](node.data);
+            switch (node.nodeType) {
+            case 3: return document.createTextNode(node.data);
+            case 4: return document.createCDATASection(node.data);
+            case 8: return document.createComment(node.data);
             }
 
             var hnode = document.createElement(node.nodeName);

From 80cc9c990f0c36852cc8357a9b6f7cf1052e54c2 Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@openerp.com>
Date: Wed, 18 Jan 2012 11:57:51 +0100
Subject: [PATCH 4/9] [FIX] XML serialization for MSIE8 (not by much, but now
 it kinda works again)

bzr revid: xmo@openerp.com-20120118105751-2jnwcilwc5p6kgth
---
 addons/web/static/lib/qweb/qweb2.js | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/addons/web/static/lib/qweb/qweb2.js b/addons/web/static/lib/qweb/qweb2.js
index 39904d0b33a..c8234db77e5 100644
--- a/addons/web/static/lib/qweb/qweb2.js
+++ b/addons/web/static/lib/qweb/qweb2.js
@@ -96,7 +96,13 @@ var QWeb2 = {
                 if (typeof XMLSerializer !== 'undefined') {
                     return (new XMLSerializer()).serializeToString(node);
                 } else {
-                    return node.outerHTML;
+                    switch(node.nodeType) {
+                    case 1: return node.outerHTML;
+                    case 3: return node.data;
+                    case 4: return '<![CDATA[' + node.data + ']]>';
+                    case 8: return '<!-- ' + node.data + '-->';
+                    }
+                    throw new Error('Unknown node type ' + node.nodeType);
                 }
             }
         },

From d5a0079d09e2660289a1422d110763d9e1046625 Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@openerp.com>
Date: Wed, 18 Jan 2012 12:01:18 +0100
Subject: [PATCH 5/9] [IMP] LOWERCASE ALL THE THINGS

MSIE serializes nodes to UPPERCASE EVERYTHING (unless the known are generic/unknown), which breaks tests as JS doesn't really have case-insensitive comparisons

bzr revid: xmo@openerp.com-20120118110118-pfiy1n2g4yhfjtso
---
 addons/web/static/lib/qweb/qweb-test-extend.xml |  4 ++--
 addons/web/static/lib/qweb/qweb-test.js.html    | 10 +++++-----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/addons/web/static/lib/qweb/qweb-test-extend.xml b/addons/web/static/lib/qweb/qweb-test-extend.xml
index 44fda920e43..35181eb8ee9 100644
--- a/addons/web/static/lib/qweb/qweb-test-extend.xml
+++ b/addons/web/static/lib/qweb/qweb-test-extend.xml
@@ -22,11 +22,11 @@
     <t t-jquery="hr:eq(1)" t-operation="replace"><footer></footer></t>
 </t>
 <t t-extend="jquery-extend">
-    <t t-jquery="footer" t-operation="inner"><b>END</b></t>
+    <t t-jquery="footer" t-operation="inner"><b>[[end]]</b></t>
 </t>
 
 <t t-name="jquery-extend-clone" t-extend="jquery-extend">
-    <t t-jquery="ul" t-operation="append"><li>CLONED TEMPLATE</li></t>
+    <t t-jquery="ul" t-operation="append"><li>[[cloned template]]</li></t>
 </t>
 
 </templates>
diff --git a/addons/web/static/lib/qweb/qweb-test.js.html b/addons/web/static/lib/qweb/qweb-test.js.html
index 5c08d10d57c..02ec89c134c 100644
--- a/addons/web/static/lib/qweb/qweb-test.js.html
+++ b/addons/web/static/lib/qweb/qweb-test.js.html
@@ -13,7 +13,7 @@
             return s.replace(/(^\s+|\s+$)/g, '');
         }
         function render(template, context) {
-            return trim(QWeb.render(template, context));
+            return trim(QWeb.render(template, context)).toLowerCase();
         }
         $(document).ready(function() {
             module("Basic output tests", {
@@ -208,9 +208,9 @@
             test('Basic foreach repetition', function () {
                 equals(QWeb.render('repetition-text-content', {seq:seq}), '*****',
                     "Repetition of text content via foreach");
-                equals(QWeb.render('repetition-dom-content', {seq:seq}), '<b/><b/><b/><b/><b/>',
+                equals(QWeb.render('repetition-dom-content', {seq:seq}).toLowerCase(), '<b/><b/><b/><b/><b/>',
                     "Repetition of node content via foreach");
-                equals(QWeb.render('repetition-self', {seq:seq}), '<b/><b/><b/><b/><b/>',
+                equals(QWeb.render('repetition-self', {seq:seq}).toLowerCase(), '<b/><b/><b/><b/><b/>',
                     "A node with a foreach repeats itself");
             });
             test("Foreach scope content", function () {
@@ -248,9 +248,9 @@
             });
 
             test("jQuery extend", function () {
-                equals(render('jquery-extend', {}), '<hr/><ul class="main"><li>1</li><li>2</li><li>3</li></ul><footer><b>END</b></footer>',
+                equals(render('jquery-extend', {}), '<hr/><ul class="main"><li>1</li><li>2</li><li>3</li></ul><footer><b>[[end]]</b></footer>',
                         "Extend template with jQuery");
-                equals(render('jquery-extend-clone', {}), '<ul><li>one</li><li>CLONED TEMPLATE</li></ul>',
+                equals(render('jquery-extend-clone', {}), '<ul><li>one</li><li>[[cloned template]]</li></ul>',
                         "Clone template");
             });
         });

From 00af91057fca81015e44d94b0d8d298317b1300b Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@openerp.com>
Date: Wed, 18 Jan 2012 12:24:51 +0100
Subject: [PATCH 6/9] [FIX] Internet Explorer can't CDATA in HTML documents,
 convert XML CDATA sections into TEXT html sections

bzr revid: xmo@openerp.com-20120118112451-f7sbhzalhl2vapmc
---
 addons/web/static/lib/qweb/qweb2.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/addons/web/static/lib/qweb/qweb2.js b/addons/web/static/lib/qweb/qweb2.js
index c8234db77e5..089b1812aa5 100644
--- a/addons/web/static/lib/qweb/qweb2.js
+++ b/addons/web/static/lib/qweb/qweb2.js
@@ -310,8 +310,9 @@ QWeb2.Engine = (function() {
         },
         convert_xml_to_html: function (node) {
             switch (node.nodeType) {
-            case 3: return document.createTextNode(node.data);
-            case 4: return document.createCDATASection(node.data);
+            case 3:
+            case 4:
+                return document.createTextNode(node.data);
             case 8: return document.createComment(node.data);
             }
 

From 31e8d0f843efb668dde511092a8f684316588916 Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@openerp.com>
Date: Wed, 18 Jan 2012 12:25:38 +0100
Subject: [PATCH 7/9] [FIX] if a text node is composed only of whitespace,
 IE<=8 just throws the fucking thing out. Add @xml:space to "fix".

It does not just collapse the whitespace, it does not even insert the
node into its XML DOM unless said node is within the scope of an
@xml:space="preserve" (which mandates that the parser leaves all text
unmolested).

Added that in the foreach test case (which makes use of significant
whitespace), but we may have to add it to templates as well in some
cases (since whitespace is significant in HTML)..

bzr revid: xmo@openerp.com-20120118112538-ju4kxfz154qm8yny
---
 addons/web/static/lib/qweb/qweb-test-foreach.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/web/static/lib/qweb/qweb-test-foreach.xml b/addons/web/static/lib/qweb/qweb-test-foreach.xml
index 80749882aaf..8e335614c39 100644
--- a/addons/web/static/lib/qweb/qweb-test-foreach.xml
+++ b/addons/web/static/lib/qweb/qweb-test-foreach.xml
@@ -1,4 +1,4 @@
-<templates>
+<templates xml:space="preserve">
     <t t-name="repetition-text-content" t-foreach="seq">*</t>
     <t t-name="repetition-dom-content" t-foreach="seq"><b/></t>
     <b t-name="repetition-self" t-foreach="seq"/>

From 239a744948dc313f51510ad669194c48cc70b76f Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@openerp.com>
Date: Wed, 18 Jan 2012 12:45:18 +0100
Subject: [PATCH 8/9] [FIX] IE8 does not like it very much when we try to
 appendChild on an iframe, nosir

bzr revid: xmo@openerp.com-20120118114518-hrotf7hzkddx1hyr
---
 addons/web/static/src/xml/base.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/addons/web/static/src/xml/base.xml b/addons/web/static/src/xml/base.xml
index b119e5aae3c..04b91770943 100644
--- a/addons/web/static/src/xml/base.xml
+++ b/addons/web/static/src/xml/base.xml
@@ -747,7 +747,7 @@
                 <input type="file" class="oe-binary-file" name="ufile" title="Add attachment"
                     t-att-onclick="view.datarecord.id ? null : 'alert(\'No record selected ! You can only attach to existing record.\'); return false;'"/>
             </form>
-            <iframe t-attf-id="#{element_id}_iframe" t-attf-name="#{element_id}_iframe" style="display: none"> </iframe>
+            <iframe t-attf-id="#{element_id}_iframe" t-attf-name="#{element_id}_iframe" style="display: none"/>
         </div>
     </div>
     <br style="clear: both"/>
@@ -1084,7 +1084,7 @@
                 <img t-att-src='_s + "/web/static/src/img/throbber.gif"' width="16" height="16"/>
                 <b>Uploading ...</b>
             </div>
-            <iframe t-att-id="widget.iframe" t-att-name="widget.iframe" style="display: none"> </iframe>
+            <iframe t-att-id="widget.iframe" t-att-name="widget.iframe" style="display: none"/>
         </td>
     </tr>
     </table>
@@ -1134,7 +1134,7 @@
         <td class="oe-binary-progress" style="display: none" nowrap="true">
             <img t-att-src='_s + "/web/static/src/img/throbber.gif"' width="16" height="16"/>
             <b>Uploading ...</b>
-            <iframe t-att-id="widget.iframe" t-att-name="widget.iframe" style="display: none"> </iframe>
+            <iframe t-att-id="widget.iframe" t-att-name="widget.iframe" style="display: none"/>
         </td>
     </tr>
     </table>

From aff08256261e72a516a20fc86d62f9c7c3f4085d Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@openerp.com>
Date: Wed, 18 Jan 2012 13:05:54 +0100
Subject: [PATCH 9/9] [FIX] weird issue with dynamic input/@type which would
 not work at all (and yield a text field in the first cell of list views
 instead of a checkbox)

bzr revid: xmo@openerp.com-20120118120554-0neg9puvg2x3swhb
---
 addons/web/static/src/xml/base.xml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/addons/web/static/src/xml/base.xml b/addons/web/static/src/xml/base.xml
index 04b91770943..5013f6423a4 100644
--- a/addons/web/static/src/xml/base.xml
+++ b/addons/web/static/src/xml/base.xml
@@ -682,7 +682,9 @@
         </td>
     </t>
     <th t-if="options.selectable" class="oe-record-selector" width="1">
-        <input t-att-type="options.radio? 'radio': 'checkbox'" name ="radiogroup" t-att-checked="options.select_view_id == record.get('id')? true: null"/>
+        <t t-set="checked" t-value="options.select_view_id == record.get('id') ? 'checked' : null"/>
+        <input t-if="options.radio" type="radio" name="radiogroup" t-att-checked="checked"/>
+        <input t-if="!options.radio" type="checkbox" name="radiogroup" t-att-checked="checked"/>
     </th>
     <th t-if="options.isClarkGable" class="oe-record-edit-link" width="1">
         <img src="/web/static/src/img/pencil.gif" width="12" height="12" class="oe-record-edit-link-img"/>