From 4b5556cd33a573c29032aa3d993bca1cb3748516 Mon Sep 17 00:00:00 2001
From: Mitul Shah <mish@odoo.com>
Date: Mon, 3 Jan 2022 06:31:48 +0000
Subject: [PATCH] [IMP] mass_mailing_{sms}: group visibility for email
 marketing

Before this Commit,
While creating a new SMS mailing, There is an empty settings tab.

After this Commit,
- We have added a new 'Option' group and set the
'Include opt-out link' field in this group.
- We have moved the 'Responsible' from Email Content to Tracking group.
- Responsible(user_id) will be always visible.
- Email Content group will visible only while creating Email Marketing.

Task-2710557

closes odoo/odoo#86488

X-original-commit: 8d5ad3a2092da6188bcbf3ca2c12c20bc95eadb1
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
---
 addons/mass_mailing/views/mailing_mailing_views.xml     | 4 ++--
 addons/mass_mailing_sms/views/mailing_mailing_views.xml | 6 ++++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/addons/mass_mailing/views/mailing_mailing_views.xml b/addons/mass_mailing/views/mailing_mailing_views.xml
index c1bc34ab2f1..c3c74839d63 100644
--- a/addons/mass_mailing/views/mailing_mailing_views.xml
+++ b/addons/mass_mailing/views/mailing_mailing_views.xml
@@ -318,7 +318,7 @@
                             </page>
                             <page string="Settings" name="settings">
                                 <group>
-                                    <group string="Email Content">
+                                    <group string="Email Content" attrs="{'invisible': [('mailing_type', '!=', 'mail')]}">
                                         <field class="o_text_overflow" name="preview" string="Preview Text" attrs="{'readonly': [('state', 'in', ('sending', 'done'))]}" widget="char_emojis" placeholder="e.g. Check it out before it's too late!"/>
                                         <field name="email_from" attrs="{'readonly': [('state', 'in', ('sending', 'done'))]}"/>
                                         <label for="reply_to"/>
@@ -348,7 +348,7 @@
                                                 attrs="{'readonly': [('state', 'in', ('sending', 'done'))]}"/>
                                         </div>
                                     </group>
-                                    <group string="Tracking" groups="base.group_no_one,mass_mailing.group_mass_mailing_campaign">
+                                    <group string="Tracking">
                                         <field name="campaign_id"
                                             string="Campaign"
                                             groups="mass_mailing.group_mass_mailing_campaign"
diff --git a/addons/mass_mailing_sms/views/mailing_mailing_views.xml b/addons/mass_mailing_sms/views/mailing_mailing_views.xml
index f74b89f1412..46f616ff9a3 100644
--- a/addons/mass_mailing_sms/views/mailing_mailing_views.xml
+++ b/addons/mass_mailing_sms/views/mailing_mailing_views.xml
@@ -123,8 +123,10 @@
                         options='{"enable_emojis": True}'/>
                 </page>
             </xpath>
-            <xpath expr="//field[@name='user_id']" position="after">
-                <field name="sms_allow_unsubscribe" attrs="{'invisible': [('mailing_type', '!=', 'sms')], 'readonly': [('state', 'in', ('sending', 'done'))]}"/>
+            <xpath expr="//page[@name='settings']/group/group[1]" position="after">
+                <group string="Options" attrs="{'invisible': [('mailing_type', '!=', 'sms')]}">
+                    <field name="sms_allow_unsubscribe" attrs="{'invisible': [('mailing_type', '!=', 'sms')], 'readonly': [('state', 'in', ('sending', 'done'))]}"/>
+                </group>
             </xpath>
 
             <xpath expr="//field[@name='contact_list_ids']" position="attributes">