From 4b2106298d475aa80d2ec8f517cb591885e5c0cb Mon Sep 17 00:00:00 2001
From: Xavier ALT <xal@odoo.com>
Date: Fri, 7 Jul 2023 14:44:40 +0000
Subject: [PATCH] [FIX] sale, account_payment: fix saleman payment transactions
 access error

Since odoo/odoo@2b1e2abda3df user need at least 'Account / Billing'
access to read payment.transaction, that not the case for most salesman.

So for user that don't have 'Account / Billing', this commit do:

- compute the 'amount_paid' as superuser
  (fixing "Generate Payment Link" wizard access errors)

- hide "Payment Transaction" smart-button on invoice

closes odoo/odoo#127835

X-original-commit: ad2c3a873a926ac8c94d014af24ed400b493493e
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Signed-off-by: Xavier Alt (xal) <xal@odoo.com>
---
 addons/account_payment/views/account_move_views.xml | 1 +
 addons/sale/models/sale_order.py                    | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/addons/account_payment/views/account_move_views.xml b/addons/account_payment/views/account_move_views.xml
index 0be75f55b79..333209f98e1 100644
--- a/addons/account_payment/views/account_move_views.xml
+++ b/addons/account_payment/views/account_move_views.xml
@@ -27,6 +27,7 @@
             <xpath expr="//div[@name='button_box']" position="inside">
                 <field name="transaction_ids" invisible="1" />
                 <button name="action_view_payment_transactions" type="object"
+                        groups="account.group_account_invoice"
                         class="oe_stat_button" icon="fa-money"
                         attrs="{'invisible': [('transaction_ids', '=', [])]}">
                         <div class="o_stat_info">
diff --git a/addons/sale/models/sale_order.py b/addons/sale/models/sale_order.py
index 0b0b9425672..fa5a0c2cb48 100644
--- a/addons/sale/models/sale_order.py
+++ b/addons/sale/models/sale_order.py
@@ -238,7 +238,7 @@ class SaleOrder(models.Model):
         compute='_compute_authorized_transaction_ids',
         copy=False,
         compute_sudo=True)
-    amount_paid = fields.Float(compute='_compute_amount_paid')
+    amount_paid = fields.Float(compute='_compute_amount_paid', compute_sudo=True)
 
     # UTMs - enforcing the fact that we want to 'set null' when relation is unlinked
     campaign_id = fields.Many2one(ondelete='set null')