From 4b0b00dbd903a1ffc0a5802040cd1dd0dc6c7984 Mon Sep 17 00:00:00 2001 From: Yannick Tivisse Date: Wed, 24 Apr 2019 12:27:17 +0000 Subject: [PATCH] [FIX] hr_holidays: Avoid erasing values on onchange if set closes odoo/odoo#32790 Signed-off-by: Yannick Tivisse (yti) --- addons/hr_holidays/models/hr_leave.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/addons/hr_holidays/models/hr_leave.py b/addons/hr_holidays/models/hr_leave.py index 26351edf402..de9315ed637 100644 --- a/addons/hr_holidays/models/hr_leave.py +++ b/addons/hr_holidays/models/hr_leave.py @@ -327,13 +327,15 @@ class HolidaysRequest(models.Model): @api.onchange('holiday_type') def _onchange_type(self): - if self.holiday_type == 'employee' and not self.employee_id: - self.employee_id = self.env.user.employee_ids[:1].id + if self.holiday_type == 'employee': + if not self.employee_id: + self.employee_id = self.env.user.employee_ids[:1].id self.mode_company_id = False self.category_id = False - elif self.holiday_type == 'company' and not self.mode_company_id: + elif self.holiday_type == 'company': self.employee_id = False - self.mode_company_id = self.env.user.company_id.id + if not self.mode_company_id: + self.mode_company_id = self.env.user.company_id.id self.category_id = False elif self.holiday_type == 'department': self.employee_id = False