From 4a97700a38a64b7586ebbfad0940f43a0b3997ff Mon Sep 17 00:00:00 2001 From: Patrick Hoste Date: Wed, 22 Nov 2023 15:16:09 +0100 Subject: [PATCH] [FIX] website_slides: fix share copy link MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit With this commit 963842381e2449ee59e5cffd1bae8656f5477e7a ClipboardJS was removed to use the native clipboard api. But here the innerText was checked instead of the value so there was nothing to copy in the clipboard. This commit fix this. Task-3607299 closes odoo/odoo#143206 Signed-off-by: Stéphane Debauche (std) --- .../static/src/js/slides_course_fullscreen_player.js | 2 +- addons/website_slides/static/src/js/slides_share.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/addons/website_slides/static/src/js/slides_course_fullscreen_player.js b/addons/website_slides/static/src/js/slides_course_fullscreen_player.js index 865f18e7101..3b4ed513bea 100644 --- a/addons/website_slides/static/src/js/slides_course_fullscreen_player.js +++ b/addons/website_slides/static/src/js/slides_course_fullscreen_player.js @@ -444,7 +444,7 @@ ev.preventDefault(); var $clipboardBtn = this.$('.o_clipboard_button'); $clipboardBtn.tooltip({title: "Copied!", trigger: "manual", placement: "bottom"}); - await browser.navigator.clipboard.writeText(this.$('.o_wslides_js_share_link')[0].innerText); + await browser.navigator.clipboard.writeText(this.$('.o_wslides_js_share_link').val() || ''); $clipboardBtn.tooltip('show'); setTimeout(() => $clipboardBtn.tooltip("hide"), 800); }, diff --git a/addons/website_slides/static/src/js/slides_share.js b/addons/website_slides/static/src/js/slides_share.js index f206a5bf457..22d29100988 100644 --- a/addons/website_slides/static/src/js/slides_share.js +++ b/addons/website_slides/static/src/js/slides_share.js @@ -115,7 +115,7 @@ publicWidget.registry.websiteSlidesShare = publicWidget.Widget.extend({ var $clipboardBtn = $(ev.currentTarget); $clipboardBtn.tooltip({title: "Copied!", trigger: "manual", placement: "bottom"}); var share_link_el = this.$('#wslides_share_link_id_' + $clipboardBtn[0].id.split('id_')[1]); - await browser.navigator.clipboard.writeText(share_link_el[0].innerText); + await browser.navigator.clipboard.writeText(share_link_el.val() || ''); $clipboardBtn.tooltip('show'); setTimeout(() => $clipboardBtn.tooltip("hide"), 800); }, @@ -132,7 +132,7 @@ publicWidget.registry.websiteSlidesEmbedShare = publicWidget.Widget.extend({ const $clipboardBtn = $(ev.currentTarget); $clipboardBtn.tooltip({title: "Copied!", trigger: "manual", placement: "bottom"}); var share_embed_el = this.$('#wslides_share_embed_id_' + $clipboardBtn[0].id.split('id_')[1]); - await browser.navigator.clipboard.writeText(share_embed_el[0].innerText); + await browser.navigator.clipboard.writeText(share_embed_el.val() || ''); $clipboardBtn.tooltip('show'); setTimeout(function () { $clipboardBtn.tooltip("hide");