From 4a3bf1f8475579af53b6c043e3f5cb5e879d96cf Mon Sep 17 00:00:00 2001
From: Prakash Prajapati <ppr@odoo.com>
Date: Fri, 18 Aug 2023 14:05:52 +0000
Subject: [PATCH] [FIX] sale_product_configurator: fix alignment value and
 radio button

Issue:
   Currently there is no alignment between radio button and value,
   we fix this commit.

Fix:
   We move the input box inside the label.
step:
    - Install sale app
    - Create product(test) and add Attributes & Variants
    - Select Brand  (Display Type: radio) Attributes and add value
    - Create sale order and add product(test)
    - Check Configure

closes odoo/odoo#134734

X-original-commit: 9e32999d3eea96da6d0ab39642e3f2d612a8690a
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
---
 .../product_template_attribute_line.xml          | 16 ++++++++--------
 .../tours/product_configurator_edition_ui.js     |  6 +++---
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/addons/sale_product_configurator/static/src/js/product_template_attribute_line/product_template_attribute_line.xml b/addons/sale_product_configurator/static/src/js/product_template_attribute_line/product_template_attribute_line.xml
index e9199c2d881..2b5be6801b1 100644
--- a/addons/sale_product_configurator/static/src/js/product_template_attribute_line/product_template_attribute_line.xml
+++ b/addons/sale_product_configurator/static/src/js/product_template_attribute_line/product_template_attribute_line.xml
@@ -48,15 +48,15 @@
                             t-if="ptav.price_extra"
                             price="ptav.price_extra"
                             currencyId="this.env.currencyId"/>
+                        <input
+                            type="radio"
+                            class="form-check-input"
+                            t-att-id="ptav.id"
+                            t-att-value="ptav.id"
+                            t-att-checked="this.props.selected_attribute_value_ids.includes(ptav.id)"
+                            t-att-name="'ptal-' + this.props.id"
+                            t-on-change="updateSelectedPTAV"/>
                     </label>
-                    <input
-                        type="radio"
-                        class="form-check-input"
-                        t-att-id="ptav.id"
-                        t-att-value="ptav.id"
-                        t-att-checked="this.props.selected_attribute_value_ids.includes(ptav.id)"
-                        t-att-name="'ptal-' + this.props.id"
-                        t-on-change="updateSelectedPTAV"/>
                 </div>
             </li>
         </ul>
diff --git a/addons/test_sale_product_configurators/static/tests/tours/product_configurator_edition_ui.js b/addons/test_sale_product_configurators/static/tests/tours/product_configurator_edition_ui.js
index ce1a66cda7c..be41cee5492 100644
--- a/addons/test_sale_product_configurators/static/tests/tours/product_configurator_edition_ui.js
+++ b/addons/test_sale_product_configurators/static/tests/tours/product_configurator_edition_ui.js
@@ -40,13 +40,13 @@ registry.category("web_tour.tours").add('sale_product_configurator_edition_tour'
 }, {
     trigger: '.fa-pencil',
 }, {
-    trigger: 'tr:has(.o_sale_product_configurator_name:contains("Customizable Desk"))>td:nth-child(2)>ul:nth-child(3)>li:nth-child(2)>div label:contains("Aluminium") ~ input:checked',
+    trigger: 'tr:has(.o_sale_product_configurator_name:contains("Customizable Desk"))>td:nth-child(2)>ul:nth-child(3)>li:nth-child(2)>div label:contains("Aluminium") > input:checked',
     isCheck: true, // check updated legs
 }, {
     trigger: 'tr:has(.o_sale_product_configurator_name:contains("Customizable Desk"))>td:nth-child(4) span:contains("800.40")',
     isCheck: true, // check updated price
 }, {
-    trigger: 'tr:has(.o_sale_product_configurator_name:contains("Customizable Desk")) label:contains("Custom") ~ input',
+    trigger: 'tr:has(.o_sale_product_configurator_name:contains("Customizable Desk")) label:contains("Custom") > input',
 }, {
     trigger: 'tr:has(.o_sale_product_configurator_name:contains("Customizable Desk"))>td:nth-child(2)>input',
     run: 'text nice custom value'
@@ -83,7 +83,7 @@ registry.category("web_tour.tours").add('sale_product_configurator_edition_tour'
 }, {
     trigger: '.fa-pencil',
 }, {
-    trigger: 'tr:has(.o_sale_product_configurator_name:contains("Customizable Desk")) label:contains("Steel") ~ input',
+    trigger: 'tr:has(.o_sale_product_configurator_name:contains("Customizable Desk")) label:contains("Steel") > input',
 },  {
     trigger: 'tr:has(.o_sale_product_configurator_name:contains("Customizable Desk (TEST) (Steel, Black)"))',
     isCheck: true,