From 49ff78711e98889ddee9eb450825bce30c06cc2d Mon Sep 17 00:00:00 2001 From: Thanh Dodeur Date: Fri, 24 Mar 2023 12:00:09 +0000 Subject: [PATCH] [FIX] mail: prevents crash in some `channelMember` inserts MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Before this commit, we were trying to access `channelMember.thread.channelMembers` when inserting a member, but some inserts come without this key. A traceback could occur when inserts of `rtcSession` records came with a `channelMember` with little information on their thread. closes odoo/odoo#116656 Signed-off-by: Alexandre Kühn (aku) --- addons/mail/static/src/core/channel_member_service.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/mail/static/src/core/channel_member_service.js b/addons/mail/static/src/core/channel_member_service.js index b6d1637b4cd..2cfbfb7aa35 100644 --- a/addons/mail/static/src/core/channel_member_service.js +++ b/addons/mail/static/src/core/channel_member_service.js @@ -37,7 +37,7 @@ export class ChannelMemberService { switch (command) { case "insert": { - if (!member.thread.channelMembers.includes(member)) { + if (!member.thread?.channelMembers?.includes(member)) { member.thread.channelMembers.push(member); } }