From 49dfe5e329ccfb8f2f71dfcd4b7d709134613616 Mon Sep 17 00:00:00 2001 From: Romain Derie Date: Wed, 16 Sep 2020 12:01:31 +0000 Subject: [PATCH] [FIX] website: prevent /web/become route to crash MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Since 9f82605df111, any call to `_login_redirect()` without previously going through `web_login()` method would crash, as `login_success` is set there. In this case, it was: Dispatch -> web_login -> redirect (new dispatch) -> _login_redirect() task-2340941 closes odoo/odoo#57881 X-original-commit: 448fcb3c702c3346ca5af922bbf457231a7330f5 Signed-off-by: Jérémy Kersten (jke) --- addons/website/controllers/main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/website/controllers/main.py b/addons/website/controllers/main.py index 4b43eb34c29..f4fc6574ed3 100644 --- a/addons/website/controllers/main.py +++ b/addons/website/controllers/main.py @@ -99,7 +99,7 @@ class Website(Home): """ Redirect regular users (employees) to the backend) and others to the frontend """ - if not redirect and request.params['login_success']: + if not redirect and request.params.get('login_success'): if request.env['res.users'].browse(uid).has_group('base.group_user'): redirect = b'/web?' + request.httprequest.query_string else: