From 49de0f4640cf2bfceb3c4f6c6a333739ecd866f4 Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Tue, 4 Oct 2011 17:57:46 +0200 Subject: [PATCH] [FIX] stupidity: if insert a line in a list with more than 5 records (no padding), since the new line does not have a @data-id yet it's going to remove it immediately. select line to remove before inserting new one bzr revid: xmo@openerp.com-20111004155746-q13ieg0q6lsy1uf7 --- addons/web/static/src/js/view_list_editable.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/web/static/src/js/view_list_editable.js b/addons/web/static/src/js/view_list_editable.js index 41133c102d0..82365ee5942 100644 --- a/addons/web/static/src/js/view_list_editable.js +++ b/addons/web/static/src/js/view_list_editable.js @@ -148,7 +148,7 @@ openerp.web.list_editable = function (openerp) { var $new_row = $('', { id: _.uniqueId('oe-editable-row-'), 'data-id': record_id, - 'class': $(row).attr('class') + ' oe_forms', + 'class': row ? $(row).attr('class') : '' + ' oe_forms', click: function (e) {e.stopPropagation();} }) .delegate('button.oe-edit-row-save', 'click', function () { @@ -175,6 +175,7 @@ openerp.web.list_editable = function (openerp) { if (row) { $new_row.replaceAll(row); } else if (self.options.editable) { + var $last_child = self.$current.find('> tr:last'); if (self.records.length) { if (self.options.editable === 'top') { $new_row.insertBefore( @@ -186,7 +187,6 @@ openerp.web.list_editable = function (openerp) { } else { $new_row.prependTo(self.$current); } - var $last_child = self.$current.find('> tr:last'); if ($last_child.is(':not([data-id])')) { $last_child.remove(); }