From 49dc69cfea5f894e2870d887366eeb0f9b98b878 Mon Sep 17 00:00:00 2001 From: David Beguin Date: Fri, 16 Apr 2021 14:34:52 +0000 Subject: [PATCH] [IMP] base_import: fix field dropdown list return values When generating field completion, if there are no o2m or suggested fields, the method was returning the list of values without adding the regulars fields. This commit returns correctly the complete set of values. Task ID: 2508902 closes odoo/odoo#69423 X-original-commit: 134b0f28a43042b22bed1c5f657344544e0f8d22 Signed-off-by: Thibault Delavallee (tde) --- addons/base_import/static/src/js/import_action.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/addons/base_import/static/src/js/import_action.js b/addons/base_import/static/src/js/import_action.js index b80c28fc274..462720cbb7d 100644 --- a/addons/base_import/static/src/js/import_action.js +++ b/addons/base_import/static/src/js/import_action.js @@ -755,14 +755,13 @@ var DataImport = AbstractAction.extend({ if (!_.isEmpty(suggested)) { basic = basic.concat({ text: _t("Suggested Fields"), children: suggested }); } - basic = basic.concat([ + return basic.concat([ { text: !_.isEmpty(suggested) ? _t("Additional Fields") : _t("Standard Fields"), children: regulars }, { text: _t("Relation Fields"), children: o2m }, ]); } else { - basic.concat(suggested, regulars, o2m); + return basic.concat(suggested, regulars, o2m); } - return basic; }, render_fields_matches: function (result, $fields) { if (_(result.matches).isEmpty()) { return; }