From 49c3f91e04a674ea363bd0fe1e887686efd89189 Mon Sep 17 00:00:00 2001
From: Hiral Bhavsar <hbh@odoo.com>
Date: Wed, 16 May 2018 12:50:32 +0530
Subject: [PATCH] [REF] website_sale: hide settings to install
 account_invoicing

Purpose is to limit the uninstallation of modules without being clearly
notified of it. In website_sale we choose to hide the field allowing to
(un)install invoicing. Options linked to invoicing are now hidden if the
module is not installed.

This commit is related to task ID 1841221.
---
 .../views/res_config_settings_views.xml       | 46 +++++++++----------
 1 file changed, 23 insertions(+), 23 deletions(-)

diff --git a/addons/website_sale/views/res_config_settings_views.xml b/addons/website_sale/views/res_config_settings_views.xml
index 6127270874d..f98d1c2fc3f 100644
--- a/addons/website_sale/views/res_config_settings_views.xml
+++ b/addons/website_sale/views/res_config_settings_views.xml
@@ -304,32 +304,32 @@
                     </div>
                 </div>
 
-                <h2>Invoicing</h2>
-                <div class="row mt16 o_settings_container" id="sale_invoicing_settings">
-                   <div class="col-xs-12 col-md-6 o_setting_box" id="invoicing_policy_setting" title="The mode selected here applies as invoicing policy of any new product created but not of products already existing.">
-                        <div class="o_setting_left_pane">
-                            <field name="module_account_invoicing" nolabel="1"/>
-                        </div>
-                        <div class="o_setting_right_pane">
-                            <label for="module_account_invoicing"/>
-                            <div class="text-muted">
-                                Issue invoices to customers
-                            </div>
-                            <div class="content-group" attrs="{'invisible': [('module_account_invoicing', '=', False)]}">
-                                <div class="mt16">
-                                    <field name="default_invoice_policy" class="o_light_label" widget="radio"/>
+                <field name='module_account_invoicing' invisible="1"/>
+                <div attrs="{'invisible': [('module_account_invoicing', '=', False)]}">
+                    <h2>Invoicing</h2>
+                    <div class="row mt16 o_settings_container" id="sale_invoicing_settings">
+                       <div class="col-xs-12 col-md-6 o_setting_box" id="invoicing_policy_setting" title="The mode selected here applies as invoicing policy of any new product created but not of products already existing.">
+                            <div class="o_setting_right_pane">
+                                <label string="Invoicing Policy"/>
+                                <div class="text-muted">
+                                    Issue invoices to customers
+                                </div>
+                                <div class="content-group">
+                                    <div class="mt16">
+                                        <field name="default_invoice_policy" class="o_light_label" widget="radio"/>
+                                    </div>
                                 </div>
                             </div>
                         </div>
-                    </div>
-                    <div class="col-xs-12 col-md-6 o_setting_box" attrs="{'invisible': ['|', ('default_invoice_policy', '=', 'delivery'), ('module_account_invoicing', '=', False)]}">
-                        <div class="o_setting_left_pane">
-                            <field name="automatic_invoice" nolabel="1"/>
-                        </div>
-                        <div class="o_setting_right_pane">
-                            <label for="automatic_invoice"/>
-                            <div class="text-muted">
-                                Generate the invoice automatically when the order is confirmed
+                        <div class="col-xs-12 col-md-6 o_setting_box" attrs="{'invisible': [('default_invoice_policy', '=', 'delivery')]}">
+                            <div class="o_setting_left_pane">
+                                <field name="automatic_invoice" nolabel="1"/>
+                            </div>
+                            <div class="o_setting_right_pane">
+                                <label for="automatic_invoice"/>
+                                <div class="text-muted">
+                                    Generate the invoice automatically when the order is confirmed
+                                </div>
                             </div>
                         </div>
                     </div>