From 4957296f1d0113aa074015ccd14f7e96918ba3cb Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Fri, 2 Jun 2017 16:31:58 +0200 Subject: [PATCH] [FIX] P3: incorrect dependencies website_sale_digital overrides a method defined on website_portal_sale, but only depends on website_portal and extends the base controller from website_portal. Depending on the (relative) order in which the system decides to load website_sale_digital and website_portal_sale we can end up with the former's template but the latter's methods (without the proper context data). Which ends up commonly crashing in P35. Fix dependencies and controller inheritance. --- addons/website_sale_digital/__manifest__.py | 2 +- addons/website_sale_digital/controllers/main.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/website_sale_digital/__manifest__.py b/addons/website_sale_digital/__manifest__.py index 973a3bd1817..84018a35c61 100644 --- a/addons/website_sale_digital/__manifest__.py +++ b/addons/website_sale_digital/__manifest__.py @@ -8,7 +8,7 @@ Sell digital product using attachments to virtual products """, 'depends': [ 'document', - 'website_sale', + 'website_portal_sale', ], 'installable': True, 'data': [ diff --git a/addons/website_sale_digital/controllers/main.py b/addons/website_sale_digital/controllers/main.py index 162daa5c0c8..2df86980bc6 100644 --- a/addons/website_sale_digital/controllers/main.py +++ b/addons/website_sale_digital/controllers/main.py @@ -7,7 +7,7 @@ from werkzeug.utils import redirect from odoo import http from odoo.http import request -from odoo.addons.website_portal.controllers.main import website_account +from odoo.addons.website_portal_sale.controllers.main import website_account from odoo.addons.website_sale.controllers.main import WebsiteSale class WebsiteSaleDigitalConfirmation(WebsiteSale):