From 48a60fe268655fb066e4060d1a88a6fdc3fe52c4 Mon Sep 17 00:00:00 2001 From: Benoit Socias Date: Fri, 14 Jan 2022 14:19:11 +0000 Subject: [PATCH] [FIX] web_editor: discard background positioning when clicking outside Since [1] options could still be used while a background positioning overlay was opened. After this commit the overlay is deactivated whenever an element outside of it is clicked - as initially intended. [1] https://github.com/odoo/odoo/commit/dfd98f49e7f2ab5c94dcae3af2d14750d301fa0a task-2735690 closes odoo/odoo#82824 X-original-commit: 574ae49acb950d99ef4ab2b0504cfd7f39bca406 Signed-off-by: Romain Derie (rde) --- addons/web_editor/static/src/js/editor/snippets.options.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/web_editor/static/src/js/editor/snippets.options.js b/addons/web_editor/static/src/js/editor/snippets.options.js index 2e953c6d636..d6c5f6caf84 100644 --- a/addons/web_editor/static/src/js/editor/snippets.options.js +++ b/addons/web_editor/static/src/js/editor/snippets.options.js @@ -6773,7 +6773,7 @@ registry.BackgroundPosition = SnippetOptionWidget.extend({ * @private */ _onDocumentClicked: function (ev) { - if (!$(ev.target).closest('.o_we_background_position_overlay')) { + if (!$(ev.target).closest('.o_we_background_position_overlay').length) { this._toggleBgOverlay(false); } },