From 482ff59fa3fb8ee910f201511705201f877a4e2f Mon Sep 17 00:00:00 2001
From: "Andrea Grazioso (agr-odoo)" <agr@odoo.com>
Date: Thu, 4 Jun 2020 14:49:27 +0000
Subject: [PATCH] [FIX] account: display "Amount Matching" on "Same currency
 matching" false

- Activate multicurrency and use a 1.5 rate on USD to EUR (to ease
calculations)
- Create two customer invoices in EUR (company is in USD) for two
different partners (e.g. partner1 and partner2) with only one line and
an amount of 100 EUR (removed the tax as well so that payment term line
is 150 USD on receivable account)
- On the "Invoices Matching Rule" reconciliation model:
1. Set Amount Matching to 90%
2. Define any account for the counterpart
3. Remove "Same Currency Matching"
4. Ensure "Partner Is Set & Matches" is marked

- Then create a new bank statement with two lines as follows:

1. dummy label, partner1, 140 USD
2. dummy label, partner2, 100 USD

- When clicking on reconcile,

1. the line for partner1 is not matched (although it respects the 90%
param)

So 'Match amount' is still effective, while it is not shown in the view.
This should not occur. Removing the invisiblity conditions to avoid
the inconsistency.

opw-2261134
---
 addons/account/views/account_reconcile_model_views.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/addons/account/views/account_reconcile_model_views.xml b/addons/account/views/account_reconcile_model_views.xml
index 191f41e4fa9..5cd15f1ace0 100644
--- a/addons/account/views/account_reconcile_model_views.xml
+++ b/addons/account/views/account_reconcile_model_views.xml
@@ -124,8 +124,8 @@
                                 </div>
                                 <field name="match_same_currency" attrs="{'invisible': [('rule_type', '!=', 'invoice_matching')]}"/>
                                 <label for="match_total_amount"
-                                       attrs="{'invisible': ['|', ('rule_type', '!=', 'invoice_matching'), ('match_same_currency', '=', False)]}"/>
-                                <div attrs="{'invisible': ['|', ('rule_type', '!=', 'invoice_matching'), ('match_same_currency', '=', False)]}">
+                                       attrs="{'invisible': ['|', ('rule_type', '!=', 'invoice_matching'), ('match_partner', '=', False)]}"/>
+                                <div attrs="{'invisible': ['|', ('rule_type', '!=', 'invoice_matching'), ('match_partner', '=', False)]}">
                                     <field name="match_total_amount" class="oe_inline"/>
                                     <field name="match_total_amount_param" class="oe_inline"
                                            attrs="{'invisible': [('match_total_amount', '=', False)]}"/>