From 47ea5f32606bf7bc96c5815bc7de4a98c66bc62f Mon Sep 17 00:00:00 2001
From: William Henrotin <whe@odoo.com>
Date: Mon, 1 Oct 2018 16:25:06 +0200
Subject: [PATCH] [FIX] delivery: new error message

Making a delivery with an external carrier without setting any partner
will sometimes lead to a crash on the API respond from the carrier. This technical error is sent back to the user without any proper sentence human readable.

This commit set the field 'partner_id' required in case of delivery with external carrier to avoid any technical error

Task : 1886733
---
 addons/delivery/views/delivery_view.xml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/addons/delivery/views/delivery_view.xml b/addons/delivery/views/delivery_view.xml
index 3e50ec46b28..36c0b222064 100644
--- a/addons/delivery/views/delivery_view.xml
+++ b/addons/delivery/views/delivery_view.xml
@@ -236,6 +236,9 @@
                     <button name="action_send_confirmation_email" string="Send Confirmation Email" type="object" attrs="{'invisible':['|', ('state', '!=', 'done'), ('carrier_id', '=', False)]}"/>
                  </xpath>
               </data>
+              <xpath expr="//field[@name='partner_id']" position="attributes">
+                  <attribute name="attrs">{'required': ['&amp;', ('delivery_type', '!=', False), ('delivery_type', 'not in', ['fixed', 'base_on_rule'])]}</attribute>
+              </xpath>
             </field>
         </record>