From 47806eb87f85937737f22a9a6dfa137e69e74edb Mon Sep 17 00:00:00 2001 From: xO-Tx Date: Mon, 21 Sep 2020 13:36:26 +0000 Subject: [PATCH] [FIX] web_editor: fix empty media dialog save issue when media dialog launched for the first time (with no selected media attachment), "FileWidget.selectedAttachments" contains a default object {url:... , alt:...} (default attachment already on the target), and the click on "Add" button will cause a backtrace since the code on "_save" method tries to access "image_src" attribute on all selectedAttachments elements including default one. The simplest solution would be to check if the object already has an "image_src" attribute. task-2312878 closes odoo/odoo#59351 X-original-commit: ecffbe4060eea98d3444f308bcd28bfb9287e1c3 Signed-off-by: Samuel Degueldre Signed-off-by: Quentin Smetz (qsm) --- addons/web_editor/static/src/js/wysiwyg/widgets/media.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/web_editor/static/src/js/wysiwyg/widgets/media.js b/addons/web_editor/static/src/js/wysiwyg/widgets/media.js index 3134f55b373..65bceb1b053 100644 --- a/addons/web_editor/static/src/js/wysiwyg/widgets/media.js +++ b/addons/web_editor/static/src/js/wysiwyg/widgets/media.js @@ -396,7 +396,7 @@ var FileWidget = SearchableMediaWidget.extend({ } const selected = this.selectedAttachments.concat(mediaAttachments).map(attachment => { // Color-customize dynamic SVGs with the primary theme color - if (attachment.image_src.startsWith('/web_editor/shape/')) { + if (attachment.image_src && attachment.image_src.startsWith('/web_editor/shape/')) { const colorCustomizedURL = new URL(attachment.image_src, window.location.origin); colorCustomizedURL.searchParams.set('c1', getCSSVariableValue('o-color-1')); attachment.image_src = colorCustomizedURL.pathname + colorCustomizedURL.search;