diff --git a/addons/mass_mailing/static/src/js/mailing_mailing_view_form_full_width.js b/addons/mass_mailing/static/src/js/mailing_mailing_view_form_full_width.js index c9b5eba6fc2..0f9257f736c 100644 --- a/addons/mass_mailing/static/src/js/mailing_mailing_view_form_full_width.js +++ b/addons/mass_mailing/static/src/js/mailing_mailing_view_form_full_width.js @@ -40,7 +40,6 @@ const MassMailingFullWidthFormController = FormController.extend({ * template is picked. * * @private - * @param {JQuery} $iframe */ _resizeMailingEditorIframe() { const VERTICAL_OFFSET = 12; // Vertical offset picked for visual design purposes. @@ -105,7 +104,7 @@ const MassMailingFullWidthFormController = FormController.extend({ * @private */ _onDomUpdated() { - const data = { $iframe: this.$('iframe.wysiwyg_iframe, iframe.o_readonly') }; + const data = { $iframe: this.$('iframe.wysiwyg_iframe:visible, iframe.o_readonly:visible') }; this._onIframeUpdated({ data }); }, /** diff --git a/addons/mass_mailing/static/src/js/mass_mailing_widget.js b/addons/mass_mailing/static/src/js/mass_mailing_widget.js index ec1705ad73d..dc6df098917 100644 --- a/addons/mass_mailing/static/src/js/mass_mailing_widget.js +++ b/addons/mass_mailing/static/src/js/mass_mailing_widget.js @@ -170,13 +170,6 @@ var MassMailingFieldHtml = FieldHtml.extend({ } return this._super.apply(this, arguments); }, - /** - * @override - */ - _renderReadonly: function () { - this.value = this.recordData[this.nodeOptions['inline-field']]; - return this._super.apply(this, arguments); - }, /** * @override diff --git a/addons/mass_mailing/views/assets.xml b/addons/mass_mailing/views/assets.xml index c03f8a01f4b..2540cc69d34 100644 --- a/addons/mass_mailing/views/assets.xml +++ b/addons/mass_mailing/views/assets.xml @@ -4,6 +4,12 @@ + + + + diff --git a/addons/mass_mailing/views/mailing_mailing_views.xml b/addons/mass_mailing/views/mailing_mailing_views.xml index 7f7b591933b..7b714bec251 100644 --- a/addons/mass_mailing/views/mailing_mailing_views.xml +++ b/addons/mass_mailing/views/mailing_mailing_views.xml @@ -199,13 +199,12 @@ - - @@ -417,6 +416,27 @@ + + + + + + + + + + + No template picked yet. + + + Start editing your mailing to design something awesome. + + + + + + diff --git a/addons/web_editor/static/src/js/backend/field_html.js b/addons/web_editor/static/src/js/backend/field_html.js index c7f7c5e1394..65d4b6899ee 100644 --- a/addons/web_editor/static/src/js/backend/field_html.js +++ b/addons/web_editor/static/src/js/backend/field_html.js @@ -49,7 +49,6 @@ var FieldHtml = basic_fields.DebouncedField.extend(TranslatableFieldMixin, { * @override */ willStart: async function () { - console.log("this:", this); this.isRendered = false; this._onUpdateIframeId = 'onLoad_' + _.uniqueId('FieldHtml'); await this._super(); @@ -131,10 +130,10 @@ var FieldHtml = basic_fields.DebouncedField.extend(TranslatableFieldMixin, { } value = this._textToHtml(value); if (!event || event.target !== this) { - if (this.cssReadonly) { - return Promise.resolve(); - } else if (this.mode === 'edit') { + if (this.mode === 'edit' && this.wysiwyg) { this.wysiwyg.setValue(value); + } else if (this.cssReadonly) { + return Promise.resolve(); } else { this.$content.html(value); } @@ -169,9 +168,6 @@ var FieldHtml = basic_fields.DebouncedField.extend(TranslatableFieldMixin, { * @returns {$.Promise} */ _createWysiwygIntance: async function () { - if (this.cssReadonly) { - return; - } this.wysiwyg = await wysiwygLoader.createWysiwyg(this, this._getWysiwygOptions()); this.wysiwyg.__extraAssetsForIframe = this.__extraAssetsForIframe || []; return this.wysiwyg.appendTo(this.$el).then(() => { @@ -272,6 +268,9 @@ var FieldHtml = basic_fields.DebouncedField.extend(TranslatableFieldMixin, { * @override */ _renderEdit: function () { + if (this.nodeOptions.notEditable) { + return this._renderReadonly(); + } var value = this._textToHtml(this.value); if (this.nodeOptions.wrapper) { value = this._wrap(value); @@ -350,7 +349,7 @@ var FieldHtml = basic_fields.DebouncedField.extend(TranslatableFieldMixin, { return ''; }).join('\n') + '\n' + '\n' + - '\n' + + '\n' + '' + value + '\n' + '
+ No template picked yet. +
+ Start editing your mailing to design something awesome. +