From 46f9f0de87f0388b662e91d055c0394b0c6ee2bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A0n=20Todorovich?= Date: Mon, 1 Nov 2021 17:10:18 +0000 Subject: [PATCH] [IMP] website_sale_delivery: Cleanup useless code around `_remove_delivery_line`. No need to set carrier_id to False. This is already taken care by `delivery` module since 448312173. closes odoo/odoo#79231 Signed-off-by: William Braeckman (wbr) --- addons/website_sale_delivery/models/sale_order.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/addons/website_sale_delivery/models/sale_order.py b/addons/website_sale_delivery/models/sale_order.py index ef94c54b061..362c6259f38 100644 --- a/addons/website_sale_delivery/models/sale_order.py +++ b/addons/website_sale_delivery/models/sale_order.py @@ -25,7 +25,6 @@ class SaleOrder(models.Model): DeliveryCarrier = self.env['delivery.carrier'] if self.only_services: - self.write({'carrier_id': None}) self._remove_delivery_line() return True else: @@ -72,12 +71,4 @@ class SaleOrder(models.Model): def _cart_update(self, *args, **kwargs): """ Override to update carrier quotation if quantity changed """ self._remove_delivery_line() - - # When you update a cart, it is not enough to remove the "delivery cost" line - # The carrier might also be invalid, eg: if you bought things that are too heavy - # -> this may cause a bug if you go to the checkout screen, choose a carrier, - # then update your cart (the cart becomes uneditable) - if self.carrier_id: - self.carrier_id = False - return super()._cart_update(*args, **kwargs)