From 46482932efc267748583dc3aab97238504b984d2 Mon Sep 17 00:00:00 2001 From: "Sanjay Gohel (Open ERP)" Date: Wed, 27 Jun 2012 16:32:19 +0530 Subject: [PATCH] [IMP]add validation if no repair line it throws warning bzr revid: sgo@tinyerp.com-20120627110219-u7jpzqb4k034kqlh --- addons/mrp_repair/mrp_repair.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/addons/mrp_repair/mrp_repair.py b/addons/mrp_repair/mrp_repair.py index a95eaa919e5..248fc8809a0 100644 --- a/addons/mrp_repair/mrp_repair.py +++ b/addons/mrp_repair/mrp_repair.py @@ -327,17 +327,17 @@ class mrp_repair(osv.osv): """ mrp_line_obj = self.pool.get('mrp.repair.line') for o in self.browse(cr, uid, ids): + if not o.operations: + raise osv.except_osv(_('Error !'),_('You cannot confirm a repair order which has no line.')) if (o.invoice_method == 'b4repair'): self.write(cr, uid, [o.id], {'state': '2binvoiced'}) else: self.write(cr, uid, [o.id], {'state': 'confirmed'}) - if not o.operations: - raise osv.except_osv(_('Error !'),_('You cannot confirm a repair order which has no line.')) for line in o.operations: if line.product_id.track_production and not line.prodlot_id: raise osv.except_osv(_('Warning'), _("Serial number is required for operation line with product '%s'") % (line.product_id.name)) mrp_line_obj.write(cr, uid, [l.id for l in o.operations], {'state': 'confirmed'}) - self.set_confirm_send_note(cr, uid, ids,context) + self.set_confirm_send_note(cr, uid, ids) return True def action_cancel(self, cr, uid, ids, context=None):