From 43f0cbcc86008cedc6c184a994159d03795c233e Mon Sep 17 00:00:00 2001 From: Denis Ledoux Date: Wed, 7 Mar 2018 15:50:15 +0100 Subject: [PATCH] [FIX] hr_holidays: employee onchange when no employee set When changing the employee to None in an allocation, this onchange raised an error because it attempted to set an employee browser record (empty but still) in a department many2one. - Create a new leave allocation - Try to change the field Mode (holiday_type) from "By Employee" to "By Employee Tag" Fixes #23345 opw-1820069 --- addons/hr_holidays/models/hr_holidays.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/hr_holidays/models/hr_holidays.py b/addons/hr_holidays/models/hr_holidays.py index 505db8a2ea2..c7b0609efe0 100644 --- a/addons/hr_holidays/models/hr_holidays.py +++ b/addons/hr_holidays/models/hr_holidays.py @@ -216,7 +216,7 @@ class Holidays(models.Model): @api.onchange('employee_id') def _onchange_employee_id(self): self.manager_id = self.employee_id and self.employee_id.parent_id - self.department_id = self.employee_id and self.employee_id.department_id + self.department_id = self.employee_id.department_id @api.multi @api.depends('number_of_days_temp', 'type')