From 43d355c208461c02b9aa37168432827ddfe5c66c Mon Sep 17 00:00:00 2001
From: Martin Trigaux <mat@odoo.com>
Date: Tue, 13 Aug 2019 09:59:16 +0000
Subject: [PATCH] [IMP] base: better default for translation overwrite

FP request: hide the field from the view as too technical
MAT analysis: it should be true by default as most expected behaviour
(it was the reason why it was displayed in the first place)

closes odoo/odoo#35679

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
---
 odoo/addons/base/wizard/base_import_language.py              | 1 +
 odoo/addons/base/wizard/base_import_language_views.xml       | 2 +-
 odoo/addons/test_translation_import/tests/test_term_count.py | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/odoo/addons/base/wizard/base_import_language.py b/odoo/addons/base/wizard/base_import_language.py
index 6abce13916c..c0d78c46299 100644
--- a/odoo/addons/base/wizard/base_import_language.py
+++ b/odoo/addons/base/wizard/base_import_language.py
@@ -22,6 +22,7 @@ class BaseLanguageImport(models.TransientModel):
     data = fields.Binary('File', required=True, attachment=False)
     filename = fields.Char('File Name', required=True)
     overwrite = fields.Boolean('Overwrite Existing Terms',
+                               default=True,
                                help="If you enable this option, existing translations (including custom ones) "
                                     "will be overwritten and replaced by those in this file")
 
diff --git a/odoo/addons/base/wizard/base_import_language_views.xml b/odoo/addons/base/wizard/base_import_language_views.xml
index 02b3c970743..56495ead0ca 100644
--- a/odoo/addons/base/wizard/base_import_language_views.xml
+++ b/odoo/addons/base/wizard/base_import_language_views.xml
@@ -12,7 +12,7 @@
                         <field name="code" string="Code" placeholder="e.g. en_US"/>
                         <field name="data" filename="filename"/>
                         <field name="filename" invisible="1"/>
-                        <field name="overwrite"/>
+                        <field name="overwrite" groups="base.group_no_one"/>
                     </group>
                     <footer>
                         <button name="import_lang" string="_Import" type="object" class="btn-primary"/>
diff --git a/odoo/addons/test_translation_import/tests/test_term_count.py b/odoo/addons/test_translation_import/tests/test_term_count.py
index 6f7b8b1525b..b2e84b67678 100644
--- a/odoo/addons/test_translation_import/tests/test_term_count.py
+++ b/odoo/addons/test_translation_import/tests/test_term_count.py
@@ -266,6 +266,7 @@ class TestTranslationFlow(common.TransactionCase):
             'code': 'fr_FR',
             'data': export.data,
             'filename': export.name,
+            'overwrite': False,
         })
         with mute_logger('odoo.addons.base.models.res_lang'):
             import_fr.with_context(create_empty_translation=True).import_lang()