From 43644341a61add4edf7183646fc932a7499ccdb0 Mon Sep 17 00:00:00 2001
From: Kartik Chavda <kcv@odoo.com>
Date: Thu, 31 Mar 2022 08:53:54 +0000
Subject: [PATCH] [FIX] project,sale_project: fix action of milestone stat
 button

This commit fix button action of milestone stat button.

task-2784776

closes odoo/odoo#89326

X-original-commit: 70f67d8ca012ccc7980a2cc8da1c2fea1fd15678
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
---
 addons/project/models/project.py              | 22 +++++++++++++++++++
 addons/project/models/project_milestone.py    | 18 ---------------
 addons/project/views/project_views.xml        |  2 +-
 addons/sale_project/models/project.py         |  6 +++++
 .../sale_project/models/project_milestone.py  |  7 ------
 5 files changed, 29 insertions(+), 26 deletions(-)

diff --git a/addons/project/models/project.py b/addons/project/models/project.py
index e1d3fc987a7..b31ac287e7d 100644
--- a/addons/project/models/project.py
+++ b/addons/project/models/project.py
@@ -706,6 +706,28 @@ class Project(models.Model):
             'context': {'search_default_group_date': 1, 'default_account_id': self.analytic_account_id.id}
         }
 
+    def action_get_list_view(self):
+        self.ensure_one()
+        return {
+            'type': 'ir.actions.act_window',
+            'name': _('Milestones'),
+            'domain': [('project_id', '=', self.id)],
+            'res_model': 'project.milestone',
+            'views': [(self.env.ref('project.project_milestone_view_tree').id, 'tree')],
+            'view_mode': 'tree',
+            'help': _("""
+                <p class="o_view_nocontent_smiling_face">
+                    No milestones found. Let's create one!
+                </p><p>
+                    Track major progress points that must be reached to achieve success.
+                </p>
+            """),
+            'context': {
+                'default_project_id': self.id,
+                **self.env.context
+            }
+        }
+
     # ---------------------------------------------
     #  PROJECT UPDATES
     # ---------------------------------------------
diff --git a/addons/project/models/project_milestone.py b/addons/project/models/project_milestone.py
index 4d8a7c9c73a..a055236210e 100644
--- a/addons/project/models/project_milestone.py
+++ b/addons/project/models/project_milestone.py
@@ -53,21 +53,3 @@ class ProjectMilestone(models.Model):
 
     def _get_data_list(self):
         return [ms._get_data() for ms in self]
-
-    def action_get_list_view(self):
-        return {
-            'name': _('Milestones'),
-            'view_mode': 'tree',
-            'res_model': 'project.milestone',
-            'views': [(self.env.ref('project.project_milestone_view_tree').id, 'tree'), (False, 'form')],
-            'type': 'ir.actions.act_window',
-            'domain': "[('project_id', '=', active_id)]",
-            'context': {**self.env.context, 'default_project_id': self.env.context.get('active_id')},
-            'help': """
-                <p class="o_view_nocontent_smiling_face">
-                No milestones found. Let's create one!
-                </p><p>
-                Track major progress points that must be reached to achieve success.
-                </p>
-            """,
-        }
diff --git a/addons/project/views/project_views.xml b/addons/project/views/project_views.xml
index 95ab116e320..3b2d8054e64 100644
--- a/addons/project/views/project_views.xml
+++ b/addons/project/views/project_views.xml
@@ -316,7 +316,7 @@
                             name="%(act_project_project_2_project_task_all)d" icon="fa-tasks">
                             <field string="Tasks In Progress" name="task_count" widget="statinfo" options="{'label_field': 'label_tasks'}"/>
                         </button>
-                        <button class="oe_stat_button" name="action_get_list_view" type="model" icon="fa-check-square-o">
+                        <button class="oe_stat_button" name="action_get_list_view" type="object" icon="fa-check-square-o">
                             <div class="o_field_widget o_stat_info">
                                 <span class="o_stat_value">
                                     <field name="milestone_count" nolabel="1"/>
diff --git a/addons/sale_project/models/project.py b/addons/sale_project/models/project.py
index 4758b3e68f8..a5557e38cc0 100644
--- a/addons/sale_project/models/project.py
+++ b/addons/sale_project/models/project.py
@@ -104,6 +104,12 @@ class Project(models.Model):
             })
         return action_window
 
+    def action_get_list_view(self):
+        action = super().action_get_list_view()
+        if self.allow_billable:
+            action['views'] = [(self.env.ref('sale_project.project_milestone_view_tree').id, 'tree'), (False, 'form')]
+        return action
+
     def action_profitability_items(self, section_name, domain=None, res_id=False):
         if section_name in ['service_revenues', 'other_revenues']:
             view_types = ['list', 'kanban', 'form']
diff --git a/addons/sale_project/models/project_milestone.py b/addons/sale_project/models/project_milestone.py
index ed3d340d52f..9e0afc0324a 100644
--- a/addons/sale_project/models/project_milestone.py
+++ b/addons/sale_project/models/project_milestone.py
@@ -19,10 +19,3 @@ class ProjectMilestone(models.Model):
     @api.model
     def _get_fields_to_export(self):
         return super()._get_fields_to_export() + ['allow_billable', 'quantity_percentage', 'sale_line_name']
-
-    def action_get_list_view(self):
-        view = super().action_get_list_view()
-        project = self.env['project.project'].browse(self.env.context.get('active_id'))
-        if project.allow_billable:
-            view['views'] = [(self.env.ref('sale_project.project_milestone_view_tree').id, 'tree'), (False, 'form')]
-        return view