From 431d40be34e0bc1bfa7e4d4440d15891604506c0 Mon Sep 17 00:00:00 2001
From: yhu-odoo <yhu@odoo.com>
Date: Fri, 27 Oct 2023 15:58:45 +0200
Subject: [PATCH] [IMP] mrp,stock: UI changes

1. Rename 'Reserved' on MO components to 'Quantity'
2. Hide `picked` field on MO compoents by default
3. Add tooltip for `picked` field on sm.

closes odoo/odoo#140150

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
---
 addons/mrp/views/mrp_production_views.xml | 4 ++--
 addons/stock/i18n/stock.pot               | 7 +++++++
 addons/stock/models/stock_move.py         | 3 ++-
 3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/addons/mrp/views/mrp_production_views.xml b/addons/mrp/views/mrp_production_views.xml
index 58ac1cf4f95..41a49c8e858 100644
--- a/addons/mrp/views/mrp_production_views.xml
+++ b/addons/mrp/views/mrp_production_views.xml
@@ -403,14 +403,14 @@
                                     <button type="object" name="action_product_forecast_report" title="Forecast Report" icon="fa-area-chart text-danger" column_invisible="parent.state != 'draft'" invisible="forecast_availability &gt;= 0"/>
                                     <!-- TODO put forecast back -->
                                     <field name="forecast_availability" string="Forecast" widget="forecast_widget"/>
-                                    <field name="quantity" string="Reserved"
+                                    <field name="quantity" string="Quantity"
                                         decoration-success="product_uom_qty - quantity &gt; 0.0001"
                                         decoration-warning="quantity - product_uom_qty &gt; 0.0001"
                                         column_invisible="parent.state == 'draft'"
                                         readonly="has_tracking != 'none'"
                                         force_save="1" widget="mrp_consumed"/>
                                     <field name="product_uom" readonly="state != 'draft' and id" options="{'no_open': True, 'no_create': True}" groups="uom.group_uom"/>
-                                    <field name="picked" string="Consumed" column_invisible="parent.state == 'draft'" optional="show"/>
+                                    <field name="picked" string="Consumed" column_invisible="parent.state == 'draft'" optional="hide"/>
                                     <field name="manual_consumption" column_invisible="True" force_save="1"/>
                                     <field name="show_details_visible" column_invisible="True"/>
                                     <field name="lot_ids" widget="many2many_tags"
diff --git a/addons/stock/i18n/stock.pot b/addons/stock/i18n/stock.pot
index d33fcda91bd..54f037f13b7 100644
--- a/addons/stock/i18n/stock.pot
+++ b/addons/stock/i18n/stock.pot
@@ -8517,6 +8517,13 @@ msgid ""
 "products."
 msgstr ""
 
+#. module: stock
+#: model:ir.model.fields,help:stock.field_stock_move__picked
+msgid ""
+"This checkbox is just indicative, it doesn't validate or generate any "
+"product moves."
+msgstr ""
+
 #. module: stock
 #: model:ir.model.fields,help:stock.field_stock_rule__name
 msgid "This field will fill the packing origin and the name of its moves"
diff --git a/addons/stock/models/stock_move.py b/addons/stock/models/stock_move.py
index ba3d9ce1bc5..89ca2751915 100644
--- a/addons/stock/models/stock_move.py
+++ b/addons/stock/models/stock_move.py
@@ -108,7 +108,8 @@ class StockMove(models.Model):
              "* Done: The product has been transferred and the transfer has been confirmed.")
     picked = fields.Boolean(
         'Picked', compute='_compute_picked', inverse='_inverse_picked',
-        store=True, readonly=False, copy=False, default=False)
+        store=True, readonly=False, copy=False, default=False,
+        help="This checkbox is just indicative, it doesn't validate or generate any product moves.")
 
     # used to record the product cost set by the user during a picking confirmation (when costing
     # method used is 'average price' or 'real'). Value given in company currency and in product uom.