From 42df7f84a432b3dcff45ea7ae0a6d4abf0aef90a Mon Sep 17 00:00:00 2001 From: Gorash Date: Wed, 18 Sep 2019 12:15:05 +0000 Subject: [PATCH] [FIX] web_editor: checkbox without text change can now be checked --- addons/web_editor/controllers/main.py | 2 +- addons/web_editor/static/src/js/editor/summernote.js | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/addons/web_editor/controllers/main.py b/addons/web_editor/controllers/main.py index cad5291d875..5a7ca5483f7 100644 --- a/addons/web_editor/controllers/main.py +++ b/addons/web_editor/controllers/main.py @@ -97,7 +97,7 @@ class Web_Editor(http.Controller): li = htmlelem.find(".//li[@id='checklist-id-" + str(checklistId) + "']") - if not self._update_checklist_recursive(li, checked, children=True, ancestors=True): + if not li or not self._update_checklist_recursive(li, checked, children=True, ancestors=True): return value value = etree.tostring(htmlelem[0][0], encoding='utf-8', method='html')[5:-6] diff --git a/addons/web_editor/static/src/js/editor/summernote.js b/addons/web_editor/static/src/js/editor/summernote.js index 03642ff177f..c2cf0d68d6c 100644 --- a/addons/web_editor/static/src/js/editor/summernote.js +++ b/addons/web_editor/static/src/js/editor/summernote.js @@ -1790,6 +1790,7 @@ $.summernote.pluginEvents.insertUnorderedList = function (event, editor, layoutI } r.clean().select(); event.preventDefault(); + return false; }; $.summernote.pluginEvents.insertOrderedList = function (event, editor, layoutInfo) { @@ -1797,6 +1798,7 @@ $.summernote.pluginEvents.insertOrderedList = function (event, editor, layoutInf }; $.summernote.pluginEvents.insertCheckList = function (event, editor, layoutInfo) { $.summernote.pluginEvents.insertUnorderedList(event, editor, layoutInfo, "checklist"); + $(range.create().sc.parentNode).trigger('input'); // to update checklist-id }; $.summernote.pluginEvents.indent = function (event, editor, layoutInfo, outdent) { var $editable = layoutInfo.editable();