From 411603f4e307fdfdd61940b14c3fe085da8ebc3d Mon Sep 17 00:00:00 2001 From: Nans Lefebvre Date: Fri, 15 Mar 2019 09:49:01 +0000 Subject: [PATCH] [FIX] fields: safe check on ondelete cascade In the case of attachment_ids, comodel._fields[inverse] can be res_id, an integer field. Such fields do not have a default ondelete attribute. opw 1945926 closes odoo/odoo#31864 Signed-off-by: Nans Lefebvre (len) --- odoo/fields.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/odoo/fields.py b/odoo/fields.py index b02564dd908..03ecd1429b2 100644 --- a/odoo/fields.py +++ b/odoo/fields.py @@ -2438,7 +2438,7 @@ class One2many(_RelationalMulti): vals_list.clear() def drop(lines): - if comodel._fields[inverse].ondelete == 'cascade': + if getattr(comodel._fields[inverse], 'ondelete', False) == 'cascade': lines.unlink() else: lines.write({inverse: False}) @@ -2484,7 +2484,7 @@ class One2many(_RelationalMulti): vals_list.clear() def drop(lines): - if comodel._fields[inverse].ondelete == 'cascade': + if getattr(comodel._fields[inverse], 'ondelete', False) == 'cascade': lines.unlink() else: lines.write({inverse: False})