From 40fb9ca18b5e67be04133f7a90a2e11e33cd1adc Mon Sep 17 00:00:00 2001
From: Djamel Touati <otd@odoo.com>
Date: Thu, 28 Dec 2023 10:45:31 +0100
Subject: [PATCH] [FIX] stock_account: update optional show fields for
 valuation report

Steps to reproduce the bug:
Go to inventory > reporting > valuation
The total value is hidden and the remaining is shown

Solution:
displaying total value as optional show and remaining_value as optional
hidden

opw-3644799

closes odoo/odoo#147661

Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
---
 .../views/stock_valuation_layer_views.xml         | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/addons/stock_account/views/stock_valuation_layer_views.xml b/addons/stock_account/views/stock_valuation_layer_views.xml
index 3036a50d7d4..aba1c97c95a 100644
--- a/addons/stock_account/views/stock_valuation_layer_views.xml
+++ b/addons/stock_account/views/stock_valuation_layer_views.xml
@@ -56,14 +56,14 @@
                 <button name="action_open_journal_entry" groups="account.group_account_user" type="object" title="Journal Entry" icon="fa-book" invisible="not account_move_id"/>
                 <field name="product_id" />
                 <field name="company_id" groups="base.group_multi_company"/>
-                <field name="quantity" string="Moved Quantity" optional="hide" sum="Total Moved Quantity"/>
+                <field name="quantity" string="Moved Quantity" optional="show" sum="Total Moved Quantity"/>
                 <field name="remaining_qty" type="measure" optional="hide" sum="Total Remaining Quantity"/>
                 <field name="unit_cost" optional="hide"/>
                 <field name="uom_id" groups="uom.group_uom" />
                 <field name="currency_id" column_invisible="True" />
-                <field name="value" sum="Total Value" optional="hide"/>
+                <field name="value" sum="Total Value" optional="show"/>
                 <field name="description" optional="hide"/>
-                <field name="remaining_value" type="measure" optional="show" sum="Total Remaining Value"/>
+                <field name="remaining_value" type="measure" optional="hide" sum="Total Remaining Value"/>
                 <groupby name="product_id">
                     <field name="cost_method" invisible="1"/>
                     <field name="quantity_svl" invisible="1"/>
@@ -82,15 +82,6 @@
             <xpath expr="//field[@name='remaining_qty']" position="attributes">
                 <attribute name="optional">show</attribute>
             </xpath>
-            <xpath expr="//field[@name='remaining_value']" position="attributes">
-                <attribute name="optional">hide</attribute>
-            </xpath>
-            <xpath expr="//field[@name='quantity']" position="attributes">
-                <attribute name="optional">show</attribute>
-            </xpath>
-            <xpath expr="//field[@name='value']" position="attributes">
-                <attribute name="optional">show</attribute>
-            </xpath>
         </field>
     </record>