From 4072e336a296a8da873b2b69cfb00d379a41c67c Mon Sep 17 00:00:00 2001
From: Aaron Bohy <aab@odoo.com>
Date: Fri, 15 May 2015 11:14:46 +0200
Subject: [PATCH] [FIX] Cross-addons: Kanban templates: records
 editable/deletable

for the sake of compatibility with the communication logic in the
new Kanban implementation.
---
 .../account/views/account_journal_dashboard_view.xml   |  2 +-
 addons/crm/crm_lead_view.xml                           |  4 ++--
 addons/event/event_view.xml                            |  2 +-
 addons/hr/hr_dashboard.xml                             |  2 +-
 addons/hr_equipment/views/hr_equipment_views.xml       |  8 ++++----
 addons/hr_recruitment/hr_recruitment_dashboard.xml     |  2 +-
 addons/hr_recruitment/hr_recruitment_view.xml          |  2 +-
 addons/mass_mailing/views/email_template.xml           |  6 +++---
 addons/mass_mailing/views/mass_mailing.xml             |  6 +++---
 addons/project/project_dashboard.xml                   |  2 +-
 addons/project/project_view.xml                        |  4 ++--
 addons/project_issue/project_issue_view.xml            |  4 ++--
 addons/sale_crm/sale_crm_view.xml                      |  8 ++++----
 addons/sales_team/sales_team_dashboard.xml             |  2 +-
 addons/stock/stock_dashboard.xml                       |  2 +-
 addons/survey/views/survey_views.xml                   |  4 ++--
 addons/website/static/src/css/website.backend.css      |  6 +++---
 addons/website/static/src/js/website.backend.js        |  9 ++++++---
 addons/website/static/src/xml/website.backend.xml      | 10 ++++------
 addons/website_event_track/views/event_backend.xml     |  4 ++--
 addons/website_forum_doc/views/doc.xml                 |  4 ++--
 21 files changed, 47 insertions(+), 46 deletions(-)

diff --git a/addons/account/views/account_journal_dashboard_view.xml b/addons/account/views/account_journal_dashboard_view.xml
index 78ccd40bcb7..5ebe9e36659 100644
--- a/addons/account/views/account_journal_dashboard_view.xml
+++ b/addons/account/views/account_journal_dashboard_view.xml
@@ -194,7 +194,7 @@
                                 <a type="object" name="toggle_favorite"><i t-att-class="(record.show_on_dashboard.raw_value ? 'oe_star_on' : 'oe_star_off') + ' fa fa-star o_dashboard_star'" title="Click to add/remove from favorite"></i></a>
                             </div>
                             <div class="col-xs-6 text-right">
-                                <a t-if="widget.view.is_action_enabled('edit')" type="edit">Settings</a>
+                                <a t-if="widget.editable" type="edit">Settings</a>
                             </div>
                         </div>
                     </t>
diff --git a/addons/crm/crm_lead_view.xml b/addons/crm/crm_lead_view.xml
index 42b20752a91..e1a17a245d0 100644
--- a/addons/crm/crm_lead_view.xml
+++ b/addons/crm/crm_lead_view.xml
@@ -307,8 +307,8 @@
                                 <div class="oe_dropdown_toggle oe_dropdown_kanban">
                                     <i class="fa fa-bars fa-lg"/>
                                     <ul class="oe_dropdown_menu">
-                                        <t t-if="widget.view.is_action_enabled('edit')"><li><a type="edit">Edit Opportunity</a></li></t>
-                                        <t t-if="widget.view.is_action_enabled('delete')"><li><a type="delete">Delete</a></li></t>
+                                        <t t-if="widget.editable"><li><a type="edit">Edit Opportunity</a></li></t>
+                                        <t t-if="widget.deletable"><li><a type="delete">Delete</a></li></t>
                                         <li><a name="%(mail.action_email_compose_message_wizard)d" type="action" >Send Email</a></li>
                                         <li><a type="action" name="%(crm.crm_phonecall_category_phone_incoming0)d">Calls</a></li>
                                         <li><a name="action_schedule_meeting" type="object">Schedule Meeting</a></li>
diff --git a/addons/event/event_view.xml b/addons/event/event_view.xml
index ea53ba9f9b0..43091209ed0 100644
--- a/addons/event/event_view.xml
+++ b/addons/event/event_view.xml
@@ -165,7 +165,7 @@
                                 <div class="oe_dropdown_toggle oe_dropdown_kanban">
                                     <i class="fa fa-bars fa-lg"/>
                                     <ul class="oe_dropdown_menu">
-                                        <t t-if="widget.view.is_action_enabled('delete')">
+                                        <t t-if="widget.deletable">
                                             <li><a type="delete">Delete</a></li>
                                         </t>
                                         <li><ul class="oe_kanban_colorpicker" data-field="color"/></li>
diff --git a/addons/hr/hr_dashboard.xml b/addons/hr/hr_dashboard.xml
index 884e0cbc68c..9567eda3ed7 100644
--- a/addons/hr/hr_dashboard.xml
+++ b/addons/hr/hr_dashboard.xml
@@ -47,7 +47,7 @@
                                     </div>
                                 </div>
 
-                                <div t-if="widget.view.is_action_enabled('edit')" class="o_kanban_card_manage_settings row">
+                                <div t-if="widget.editable" class="o_kanban_card_manage_settings row">
                                     <div class="col-xs-8">
                                         <li><ul class="oe_kanban_colorpicker" data-field="color"/></li>
                                     </div>
diff --git a/addons/hr_equipment/views/hr_equipment_views.xml b/addons/hr_equipment/views/hr_equipment_views.xml
index ef61997f586..9797223194d 100644
--- a/addons/hr_equipment/views/hr_equipment_views.xml
+++ b/addons/hr_equipment/views/hr_equipment_views.xml
@@ -92,8 +92,8 @@
                             <div class="oe_dropdown_toggle oe_dropdown_kanban">
                                 <i class="fa fa-bars fa-lg" />
                                 <ul class="oe_dropdown_menu">
-                                    <t t-if="widget.view.is_action_enabled('edit')"><li><a type="edit">Edit...</a></li></t>
-                                    <t t-if="widget.view.is_action_enabled('delete')"><li><a type="delete">Delete</a></li></t>
+                                    <t t-if="widget.editable"><li><a type="edit">Edit...</a></li></t>
+                                    <t t-if="widget.deletable"><li><a type="delete">Delete</a></li></t>
                                     <li><ul class="oe_kanban_colorpicker" data-field="color"/></li>
                                 </ul>
                             </div>
@@ -265,8 +265,8 @@
                             <div class="oe_dropdown_toggle oe_dropdown_kanban">
                                 <i class="fa fa-bars fa-lg" />
                                 <ul class="oe_dropdown_menu">
-                                    <t t-if="widget.view.is_action_enabled('edit')"><li><a type="edit">Edit...</a></li></t>
-                                    <t t-if="widget.view.is_action_enabled('delete')"><li><a type="delete">Delete</a></li></t>
+                                    <t t-if="widget.editable"><li><a type="edit">Edit...</a></li></t>
+                                    <t t-if="widget.deletable"><li><a type="delete">Delete</a></li></t>
                                     <li><ul class="oe_kanban_colorpicker" data-field="color"/></li>
                                 </ul>
                             </div>
diff --git a/addons/hr_recruitment/hr_recruitment_dashboard.xml b/addons/hr_recruitment/hr_recruitment_dashboard.xml
index 75d4a4564a1..e0965de2039 100644
--- a/addons/hr_recruitment/hr_recruitment_dashboard.xml
+++ b/addons/hr_recruitment/hr_recruitment_dashboard.xml
@@ -123,7 +123,7 @@
                                     </div>
                                 </div>
 
-                                <div t-if="widget.view.is_action_enabled('edit')" class="o_kanban_card_manage_settings row">
+                                <div t-if="widget.editable" class="o_kanban_card_manage_settings row">
                                     <div class="col-xs-8">
                                         <li><ul class="oe_kanban_colorpicker" data-field="color"/></li>
                                     </div>
diff --git a/addons/hr_recruitment/hr_recruitment_view.xml b/addons/hr_recruitment/hr_recruitment_view.xml
index c3685c5f880..e0b9bcbbba4 100644
--- a/addons/hr_recruitment/hr_recruitment_view.xml
+++ b/addons/hr_recruitment/hr_recruitment_view.xml
@@ -268,7 +268,7 @@
                             <div class="oe_dropdown_toggle oe_dropdown_kanban">
                                 <i class="fa fa-bars fa-lg"/>
                                 <ul class="oe_dropdown_menu">
-                                    <t t-if="widget.view.is_action_enabled('delete')"><li><a type="delete">Delete</a></li></t>
+                                    <t t-if="widget.deletable"><li><a type="delete">Delete</a></li></t>
                                     <li><a name="action_makeMeeting" type="object">Schedule Interview</a></li>
                                     <li><ul class="oe_kanban_colorpicker" data-field="color"/></li>
                                 </ul>
diff --git a/addons/mass_mailing/views/email_template.xml b/addons/mass_mailing/views/email_template.xml
index 73fb508b44b..5367e043383 100644
--- a/addons/mass_mailing/views/email_template.xml
+++ b/addons/mass_mailing/views/email_template.xml
@@ -50,11 +50,11 @@
                             <div t-attf-class="oe_kanban_card oe_kanban_global_click oe_kanban_email_template">
                                 <div class="oe_dropdown_toggle oe_dropdown_kanban">
                                     <i class="fa fa-bars fa-lg"/>
-                                    <ul class="oe_dropdown_menu" t-if="widget.view.is_action_enabled('edit') or widget.view.is_action_enabled('delete')">
-                                        <t t-if="widget.view.is_action_enabled('edit')">
+                                    <ul class="oe_dropdown_menu" t-if="widget.editable or widget.deletable">
+                                        <t t-if="widget.editable">
                                             <li><a type="edit">Edit</a></li>
                                         </t>
-                                        <t t-if="widget.view.is_action_enabled('delete')">
+                                        <t t-if="widget.deletable">
                                             <li><a type="delete">Delete</a></li>
                                         </t>
                                     </ul>
diff --git a/addons/mass_mailing/views/mass_mailing.xml b/addons/mass_mailing/views/mass_mailing.xml
index 6b73230ca18..ce357f7a2f5 100644
--- a/addons/mass_mailing/views/mass_mailing.xml
+++ b/addons/mass_mailing/views/mass_mailing.xml
@@ -499,7 +499,7 @@
                                 <div class="oe_dropdown_toggle oe_dropdown_kanban">
                                     <i class="fa fa-bars fa-lg"/>
                                     <ul class="oe_dropdown_menu">
-                                        <t t-if="widget.view.is_action_enabled('delete')">
+                                        <t t-if="widget.deletable">
                                             <li><a type="delete">Delete</a></li>
                                         </t>
                                     </ul>
@@ -787,10 +787,10 @@
                                 <div class="oe_dropdown_toggle oe_dropdown_kanban">
                                     <i class="fa fa-bars fa-lg"/>
                                     <ul class="oe_dropdown_menu">
-                                        <t t-if="widget.view.is_action_enabled('edit')">
+                                        <t t-if="widget.editable">
                                             <li><a type="edit">Settings</a></li>
                                         </t>
-                                        <t t-if="widget.view.is_action_enabled('delete')">
+                                        <t t-if="widget.deletable">
                                             <li><a type="delete">Delete</a></li>
                                         </t>
                                         <li><ul class="oe_kanban_colorpicker" data-field="color"/></li>
diff --git a/addons/project/project_dashboard.xml b/addons/project/project_dashboard.xml
index 1e5ccbd13bc..b97e9721187 100644
--- a/addons/project/project_dashboard.xml
+++ b/addons/project/project_dashboard.xml
@@ -42,7 +42,7 @@
                                             <a name="%(action_view_task_history_cumulative_filter)d" type="action">Cumulative Flow</a>
                                         </div>
                                     </div>
-                                    <div t-if="widget.view.is_action_enabled('edit')" class="o_project_kanban_colorpicker">
+                                    <div t-if="widget.editable" class="o_project_kanban_colorpicker">
                                         <div class="col-xs-12">
                                             <li><ul class="oe_kanban_colorpicker" data-field="color"/></li>
                                         </div>
diff --git a/addons/project/project_view.xml b/addons/project/project_view.xml
index 5861df6869a..e4e9a752fc6 100644
--- a/addons/project/project_view.xml
+++ b/addons/project/project_view.xml
@@ -363,8 +363,8 @@
                             <div class="oe_dropdown_toggle oe_dropdown_kanban" groups="base.group_user">
                                 <i class="fa fa-bars fa-lg"/>
                                 <ul class="oe_dropdown_menu">
-                                    <t t-if="widget.view.is_action_enabled('edit')"><li><a type="edit">Edit Task</a></li></t>
-                                    <t t-if="widget.view.is_action_enabled('delete')"><li><a type="delete">Delete</a></li></t>
+                                    <t t-if="widget.editable"><li><a type="edit">Edit Task</a></li></t>
+                                    <t t-if="widget.deletable"><li><a type="delete">Delete</a></li></t>
                                     <li><ul class="oe_kanban_colorpicker" data-field="color"/></li>
                                 </ul>
                             </div>
diff --git a/addons/project_issue/project_issue_view.xml b/addons/project_issue/project_issue_view.xml
index cd4675a1ae3..5b56a2568ff 100644
--- a/addons/project_issue/project_issue_view.xml
+++ b/addons/project_issue/project_issue_view.xml
@@ -168,8 +168,8 @@
                                 <div class="oe_dropdown_toggle oe_dropdown_kanban" groups="base.group_user">
                                     <i class="fa fa-bars fa-lg"/>
                                     <ul class="oe_dropdown_menu">
-                                        <t t-if="widget.view.is_action_enabled('edit')"><li><a type="edit">Edit Issue</a></li></t>
-                                        <t t-if="widget.view.is_action_enabled('delete')"><li><a type="delete">Delete</a></li></t>
+                                        <t t-if="widget.editable"><li><a type="edit">Edit Issue</a></li></t>
+                                        <t t-if="widget.deletable"><li><a type="delete">Delete</a></li></t>
                                         <li><ul class="oe_kanban_colorpicker" data-field="color"/></li>
                                     </ul>
                                 </div>
diff --git a/addons/sale_crm/sale_crm_view.xml b/addons/sale_crm/sale_crm_view.xml
index 3f63289c592..bd2f5e748d1 100644
--- a/addons/sale_crm/sale_crm_view.xml
+++ b/addons/sale_crm/sale_crm_view.xml
@@ -35,12 +35,12 @@
                                 context="{'search_default_partner_id': partner_id, 'default_partner_id': partner_id}">
                             <field name="sale_number" widget="statinfo" string="Quotes"/>
                         </button>
-                        <button class="oe_inline oe_stat_button" type="action" attrs="{'invisible': [('sale_amount_total', '=', 0)]}"
+                        <button class="oe_stat_button" type="action" attrs="{'invisible': [('sale_amount_total', '=', 0)]}"
                                 name="%(sale_action_quotations)d" icon="stat_button_icon fa fa-usd"
                                 context="{'search_default_partner_id': partner_id, 'default_partner_id': partner_id}">
-                            <div>
-                                <strong><field name="sale_amount_total" class="oe_inline" widget="monetary" options="{'currency_field': 'company_currency'}"/></strong>
-                                <div><field name="sale_number" class="oe_inline"/> Orders</div>
+                            <div class="o_form_field o_stat_info">
+                                <span class="o_stat_value"><field name="sale_amount_total" widget="monetary" options="{'currency_field': 'company_currency'}"/></span>
+                                <span class="o_stat_text"> Orders</span>
                             </div>
                         </button>
                     </xpath>
diff --git a/addons/sales_team/sales_team_dashboard.xml b/addons/sales_team/sales_team_dashboard.xml
index fa14cd91284..33e5a7062c5 100644
--- a/addons/sales_team/sales_team_dashboard.xml
+++ b/addons/sales_team/sales_team_dashboard.xml
@@ -47,7 +47,7 @@
                                     </div>
                                 </div>
 
-                                <div t-if="widget.view.is_action_enabled('edit')" class="o_kanban_card_manage_settings row">
+                                <div t-if="widget.editable" class="o_kanban_card_manage_settings row">
                                     <div class="col-xs-8">
                                         <li><ul class="oe_kanban_colorpicker" data-field="color"/></li>
                                     </div>
diff --git a/addons/stock/stock_dashboard.xml b/addons/stock/stock_dashboard.xml
index ddf35c7beb9..002a7fa3f87 100644
--- a/addons/stock/stock_dashboard.xml
+++ b/addons/stock/stock_dashboard.xml
@@ -100,7 +100,7 @@
                                     </div>
                                 </div>
 
-                                <div t-if="widget.view.is_action_enabled('edit')" class="o_kanban_card_manage_settings row">
+                                <div t-if="widget.editable" class="o_kanban_card_manage_settings row">
                                     <div class="col-xs-8">
                                         <li><ul class="oe_kanban_colorpicker" data-field="color"/></li>
                                     </div>
diff --git a/addons/survey/views/survey_views.xml b/addons/survey/views/survey_views.xml
index 284de9fc4a9..df70a6b658e 100644
--- a/addons/survey/views/survey_views.xml
+++ b/addons/survey/views/survey_views.xml
@@ -184,11 +184,11 @@
                     <field name="public_url" />
                     <templates>
                         <div t-name="kanban-box" t-attf-class="oe_kanban_color_#{kanban_getcolor(record.color.raw_value)} oe_kanban_card oe_kanban_global_click">
-                            <div class="oe_dropdown_toggle oe_dropdown_kanban" t-if="widget.view.is_action_enabled('edit')">
+                            <div class="oe_dropdown_toggle oe_dropdown_kanban" t-if="widget.editable">
                                 <i class="fa fa-bars fa-lg"/>
                                 <ul class="oe_dropdown_menu">
                                     <li><a type="edit">Edit Survey</a></li>
-                                    <li t-if="widget.view.is_action_enabled('delete')"><a type="delete">Delete</a></li>
+                                    <li t-if="widget.deletable"><a type="delete">Delete</a></li>
                                     <li><ul class="oe_kanban_colorpicker" data-field="color"/></li>
                                 </ul>
                             </div>
diff --git a/addons/website/static/src/css/website.backend.css b/addons/website/static/src/css/website.backend.css
index 24879793303..91b3e7c01ea 100644
--- a/addons/website/static/src/css/website.backend.css
+++ b/addons/website/static/src/css/website.backend.css
@@ -1,7 +1,7 @@
-.oe_WidgetWebsiteButton.danger .oe_publish {
-    display: none;
+.oe_stat_button .o_stat_info:not(.published) > .o_stat_text.oe_publish {
+	display: none;
 }
-.oe_WidgetWebsiteButton.success .oe_unpublish {
+.oe_stat_button .o_stat_info.published > .o_stat_text.oe_unpublish {
     display: none;
 }
 .oe_form_field_html_frame iframe {
diff --git a/addons/website/static/src/js/website.backend.js b/addons/website/static/src/js/website.backend.js
index b1920dc4cab..d1bb6c2f5b0 100644
--- a/addons/website/static/src/js/website.backend.js
+++ b/addons/website/static/src/js/website.backend.js
@@ -9,10 +9,13 @@ var form_widgets = require('web.form_widgets'); // required to guarantee that
 var WidgetWebsiteButton = form_common.AbstractField.extend({
     template: 'WidgetWebsiteButton',
     render_value: function() {
+        // Hack to replace false value by unpublished because falsy form fields
+        // have classname o_form_field_empty and are hidden
+        if (!this.get_value()) {
+            this.set_value('unpublished');
+        }
         this._super();
-        this.$()
-            .toggleClass("success", this.get_value())
-            .toggleClass("danger", !this.get_value());
+        this.$el.toggleClass("published", this.get_value() === true);
         if (this.node.attrs.class) {
             this.$el.addClass(this.node.attrs.class);
         }
diff --git a/addons/website/static/src/xml/website.backend.xml b/addons/website/static/src/xml/website.backend.xml
index 24f8c825816..826e29e261c 100644
--- a/addons/website/static/src/xml/website.backend.xml
+++ b/addons/website/static/src/xml/website.backend.xml
@@ -1,12 +1,10 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <templates id="template" xml:space="preserve">
 
-    <t t-name="WidgetWebsiteButton">
-        <div class="oe_WidgetWebsiteButton success">
-            <strong class="oe_unpublish text-danger">Not<br/>Published</strong>
-            <strong class="oe_publish text-success">Published</strong>
-        </div>
-    </t>
+    <div t-name="WidgetWebsiteButton" class="o_stat_info published">
+        <span class="o_stat_text oe_unpublish text-danger">Not Published</span>
+        <span class="o_stat_text oe_publish text-success">Published</span>
+    </div>
 
     <t t-name="FieldTextHtmlFrame">
         <div class="oe_form_field oe_form_field_html_frame oe_form_embedded_html" t-att-style="widget.node.attrs.style">
diff --git a/addons/website_event_track/views/event_backend.xml b/addons/website_event_track/views/event_backend.xml
index 7eb6a103d7d..09757cab38b 100644
--- a/addons/website_event_track/views/event_backend.xml
+++ b/addons/website_event_track/views/event_backend.xml
@@ -18,8 +18,8 @@
                                     <i class="fa fa-bars fa-lg"/>
                                     <ul class="oe_dropdown_menu">
                                         <li><a t-att-href="record.website_url.value" type="url">View Track</a></li>
-                                        <t t-if="widget.view.is_action_enabled('edit')"><li><a type="edit">Edit Track</a></li></t>
-                                        <t t-if="widget.view.is_action_enabled('delete')"><li><a type="delete">Delete</a></li></t>
+                                        <t t-if="widget.editable"><li><a type="edit">Edit Track</a></li></t>
+                                        <t t-if="widget.deletable"><li><a type="delete">Delete</a></li></t>
                                         <li><ul class="oe_kanban_colorpicker" data-field="color"/></li>
                                     </ul>
                                 </div>
diff --git a/addons/website_forum_doc/views/doc.xml b/addons/website_forum_doc/views/doc.xml
index 9a32603fcab..f45243445b8 100644
--- a/addons/website_forum_doc/views/doc.xml
+++ b/addons/website_forum_doc/views/doc.xml
@@ -41,8 +41,8 @@
                             <div class="oe_dropdown_toggle oe_dropdown_kanban" groups="base.group_user">
                                 <i class="fa fa-bars fa-lg"/>
                                 <ul class="oe_dropdown_menu">
-                                    <li t-if="widget.view.is_action_enabled('edit')"><a type="edit">Edit Post</a></li>
-                                    <li t-if="widget.view.is_action_enabled('delete')"><a type="delete">Delete</a></li>
+                                    <li t-if="widget.editable"><a type="edit">Edit Post</a></li>
+                                    <li t-if="widget.deletable"><a type="delete">Delete</a></li>
                                     <li><ul class="oe_kanban_colorpicker" data-field="color"/></li>
                                 </ul>
                             </div>