From 405b97cf38087666e38b2909ae38096f4d8e4ebc Mon Sep 17 00:00:00 2001 From: Victor Feyens Date: Mon, 7 Aug 2023 15:43:19 +0000 Subject: [PATCH] [FIX] website_sale_picking: correctly filter out invalid providers The 'onsite' payment provider shouldn't be shown to the user if the cart/order only contains services (or if there are no onsite carriers). The logic was there but the filtering didn't correctly update the values. opw-3437107 closes odoo/odoo#131177 X-original-commit: 78cd9a7ab5fb860021a906400a1907b1d8b45be2 Signed-off-by: Victor Feyens (vfe) --- addons/website_sale_picking/models/payment_provider.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/website_sale_picking/models/payment_provider.py b/addons/website_sale_picking/models/payment_provider.py index 27f823b8ed4..8458c12725e 100644 --- a/addons/website_sale_picking/models/payment_provider.py +++ b/addons/website_sale_picking/models/payment_provider.py @@ -37,7 +37,7 @@ class PaymentProvider(models.Model): product.type in ('consu', 'product') for product in order.order_line.product_id ): - compatible_providers.filtered( + compatible_providers = compatible_providers.filtered( lambda p: p.code != 'custom' or p.custom_mode != 'onsite' )