From 3f38d903e9f4b39c6d4638cc4e745a9bb35ac390 Mon Sep 17 00:00:00 2001
From: "Dylan Kiss (dyki)" <dyki@odoo.com>
Date: Tue, 22 Nov 2022 14:57:15 +0000
Subject: [PATCH] [FIX] account,l10n_{au,in,gcc_invoice}: distinguish credit
 note titles

Currently we distinguish customer invoice titles based on the state they are in: draft, posted or cancelled.
For the customer credit notes we did not have this dinstinction.

This fix makes sure that the title of a credit note is also adapted based on its state.

[task-3067251](https://www.odoo.com/web#id=3067251&cids=1&menu_id=4720&action=4043&model=project.task&view_type=form)

closes odoo/odoo#106692

Related: odoo/enterprise#34464
Signed-off-by: John Laterre (jol) <jol@odoo.com>
---
 addons/account/views/report_invoice.xml       | 12 ++++---
 addons/l10n_au/views/report_invoice.xml       |  4 ++-
 .../l10n_gcc_invoice/views/report_invoice.xml | 32 +++++++++++++------
 addons/l10n_in/views/report_invoice.xml       | 14 ++++----
 4 files changed, 40 insertions(+), 22 deletions(-)

diff --git a/addons/account/views/report_invoice.xml b/addons/account/views/report_invoice.xml
index 3bf2f8b6577..75592005ec6 100644
--- a/addons/account/views/report_invoice.xml
+++ b/addons/account/views/report_invoice.xml
@@ -52,11 +52,13 @@
                     <div class="page">
                         <h2>
                             <span t-if="o.move_type == 'out_invoice' and o.state == 'posted'">Invoice</span>
-                            <span t-if="o.move_type == 'out_invoice' and o.state == 'draft'">Draft Invoice</span>
-                            <span t-if="o.move_type == 'out_invoice' and o.state == 'cancel'">Cancelled Invoice</span>
-                            <span t-if="o.move_type == 'out_refund'">Credit Note</span>
-                            <span t-if="o.move_type == 'in_refund'">Vendor Credit Note</span>
-                            <span t-if="o.move_type == 'in_invoice'">Vendor Bill</span>
+                            <span t-elif="o.move_type == 'out_invoice' and o.state == 'draft'">Draft Invoice</span>
+                            <span t-elif="o.move_type == 'out_invoice' and o.state == 'cancel'">Cancelled Invoice</span>
+                            <span t-elif="o.move_type == 'out_refund' and o.state == 'posted'">Credit Note</span>
+                            <span t-elif="o.move_type == 'out_refund' and o.state == 'draft'">Draft Credit Note</span>
+                            <span t-elif="o.move_type == 'out_refund' and o.state == 'cancel'">Cancelled Credit Note</span>
+                            <span t-elif="o.move_type == 'in_refund'">Vendor Credit Note</span>
+                            <span t-elif="o.move_type == 'in_invoice'">Vendor Bill</span>
                             <span t-if="o.name != '/'" t-field="o.name"/>
                         </h2>
 
diff --git a/addons/l10n_au/views/report_invoice.xml b/addons/l10n_au/views/report_invoice.xml
index ff957318803..93d38a3cbd4 100644
--- a/addons/l10n_au/views/report_invoice.xml
+++ b/addons/l10n_au/views/report_invoice.xml
@@ -6,7 +6,9 @@
                 <span t-if="o.move_type == 'out_invoice' and o.state == 'posted'">Tax Invoice</span>
                 <span t-elif="o.move_type == 'out_invoice' and o.state == 'draft'">Draft Tax Invoice</span>
                 <span t-elif="o.move_type == 'out_invoice' and o.state == 'cancel'">Cancelled Tax Invoice</span>
-                <span t-elif="o.move_type == 'out_refund'">Tax Credit Note</span>
+                <span t-elif="o.move_type == 'out_refund' and o.state == 'posted'">Tax Credit Note</span>
+                <span t-elif="o.move_type == 'out_refund' and o.state == 'draft'">Draft Tax Credit Note</span>
+                <span t-elif="o.move_type == 'out_refund' and o.state == 'cancel'">Cancelled Tax Credit Note</span>
                 <span t-elif="o.move_type == 'in_refund'">Tax Vendor Credit Note</span>
                 <span t-elif="o.move_type == 'in_invoice'">Tax Vendor Bill</span>
                 <span t-if="o.name != '/'" t-field="o.name"/>
diff --git a/addons/l10n_gcc_invoice/views/report_invoice.xml b/addons/l10n_gcc_invoice/views/report_invoice.xml
index 6b84f906202..eb958b59398 100644
--- a/addons/l10n_gcc_invoice/views/report_invoice.xml
+++ b/addons/l10n_gcc_invoice/views/report_invoice.xml
@@ -36,19 +36,25 @@
                             <span t-if="o.move_type == 'out_invoice' and o.state == 'posted'">
                                 Tax Invoice
                             </span>
-                            <span t-if="o.move_type == 'out_invoice' and o.state == 'draft'">
+                            <span t-elif="o.move_type == 'out_invoice' and o.state == 'draft'">
                                 Draft Invoice
                             </span>
-                            <span t-if="o.move_type == 'out_invoice' and o.state == 'cancel'">
+                            <span t-elif="o.move_type == 'out_invoice' and o.state == 'cancel'">
                                 Cancelled Invoice
                             </span>
-                            <span t-if="o.move_type == 'out_refund'">
+                            <span t-elif="o.move_type == 'out_refund' and o.state == 'posted'">
                                 Credit Note
                             </span>
-                            <span t-if="o.move_type == 'in_refund'">
+                            <span t-elif="o.move_type == 'out_refund' and o.state == 'draft'">
+                                Draft Credit Note
+                            </span>
+                            <span t-elif="o.move_type == 'out_refund' and o.state == 'cancel'">
+                                Cancelled Credit Note
+                            </span>
+                            <span t-elif="o.move_type == 'in_refund'">
                                 Vendor Credit Note
                             </span>
-                            <span t-if="o.move_type == 'in_invoice'">
+                            <span t-elif="o.move_type == 'in_invoice'">
                                 Vendor Bill
                             </span>
                         </div>
@@ -59,19 +65,25 @@
                             <span t-if="o.move_type == 'out_invoice' and o.state == 'posted'">
                                 فاتورة ضريبية
                             </span>
-                            <span t-if="o.move_type == 'out_invoice' and o.state == 'draft'">
+                            <span t-elif="o.move_type == 'out_invoice' and o.state == 'draft'">
                                 مسودة فاتورة
                             </span>
-                            <span t-if="o.move_type == 'out_invoice' and o.state == 'cancel'">
+                            <span t-elif="o.move_type == 'out_invoice' and o.state == 'cancel'">
                                 فاتورة ملغاة
                             </span>
-                            <span t-if="o.move_type == 'out_refund'">
+                            <span t-elif="o.move_type == 'out_refund' and o.state == 'posted'">
                                 إشعار خصم
                             </span>
-                            <span t-if="o.move_type == 'in_refund'">
+                            <span t-elif="o.move_type == 'out_refund' and o.state == 'draft'">
+                                إشعار خصم المسودة
+                            </span>
+                            <span t-elif="o.move_type == 'out_refund' and o.state == 'cancel'">
+                                إشعار خصم ملغاة
+                            </span>
+                            <span t-elif="o.move_type == 'in_refund'">
                                 إشعار خصم المورد
                             </span>
-                            <span t-if="o.move_type == 'in_invoice'">
+                            <span t-elif="o.move_type == 'in_invoice'">
                                 فاتورة المورد
                             </span>
                         </div>
diff --git a/addons/l10n_in/views/report_invoice.xml b/addons/l10n_in/views/report_invoice.xml
index 55337b262a7..f873596eaf1 100644
--- a/addons/l10n_in/views/report_invoice.xml
+++ b/addons/l10n_in/views/report_invoice.xml
@@ -42,12 +42,14 @@
         <xpath expr="//h2" position="replace">
             <h2>
                 <span t-if="o.move_type == 'out_invoice' and o.state == 'posted'" t-field="o.journal_id.name"/>
-                <span t-if="o.move_type == 'out_invoice' and o.state == 'draft'">Draft <span t-field="o.journal_id.name"/></span>
-                <span t-if="o.move_type == 'out_invoice' and o.state == 'cancel'">Cancelled <span t-field="o.journal_id.name"/></span>
-                <span t-if="o.move_type == 'out_refund'">Credit Note</span>
-                <span t-if="o.move_type == 'in_refund'">Vendor Credit Note</span>
-                <span t-if="o.move_type == 'in_invoice'">Vendor Bill</span>
-                <span t-field="o.name"/>
+                <span t-elif="o.move_type == 'out_invoice' and o.state == 'draft'">Draft <span t-field="o.journal_id.name"/></span>
+                <span t-elif="o.move_type == 'out_invoice' and o.state == 'cancel'">Cancelled <span t-field="o.journal_id.name"/></span>
+                <span t-elif="o.move_type == 'out_refund' and o.state == 'posted'">Credit Note</span>
+                <span t-elif="o.move_type == 'out_refund' and o.state == 'draft'">Draft Credit Note</span>
+                <span t-elif="o.move_type == 'out_refund' and o.state == 'cancel'">Cancelled Credit Note</span>
+                <span t-elif="o.move_type == 'in_refund'">Vendor Credit Note</span>
+                <span t-elif="o.move_type == 'in_invoice'">Vendor Bill</span>
+                <span t-if="o.name != '/'" t-field="o.name"/>
             </h2>
         </xpath>