From 3ecb5c5651f90ed82141ba205463d157c8e3d4fd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= <tde@odoo.com>
Date: Wed, 17 Jun 2020 08:38:02 +0000
Subject: [PATCH] [FIX] event_sale, mass_mailing_event: add groups on
 app-specific fields

Currently if you configure an user without sales and mass mailing
rights you run into issues with links modules as

  * sales data is computed on form view and requires sales access
    rights;
  * invite and contact buttons lead to tracebacks as their action
    require mailing access rights;

In this commit we fix those issues by correctly setting groups
on fields.

Task ID 2184037
PR #53119

X-original-commit: af1a5d294b235e33a48b87c89886b24ea145450d
---
 addons/event_sale/models/event_event.py         |  5 ++++-
 addons/event_sale/views/event_views.xml         |  1 +
 addons/mass_mailing_event/views/event_views.xml | 12 +++++++++---
 3 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/addons/event_sale/models/event_event.py b/addons/event_sale/models/event_event.py
index b4e45656a2d..b246a033109 100644
--- a/addons/event_sale/models/event_event.py
+++ b/addons/event_sale/models/event_event.py
@@ -9,8 +9,11 @@ class Event(models.Model):
 
     sale_order_lines_ids = fields.One2many(
         'sale.order.line', 'event_id',
+        groups='sales_team.group_sale_salesman',
         string='All sale order lines pointing to this event')
-    sale_price_subtotal = fields.Monetary(string='Sales (Tax Excluded)', compute='_compute_sale_price_subtotal')
+    sale_price_subtotal = fields.Monetary(
+        string='Sales (Tax Excluded)', compute='_compute_sale_price_subtotal',
+        groups='sales_team.group_sale_salesman')
     currency_id = fields.Many2one(
         'res.currency', string='Currency',
         related='company_id.currency_id', readonly=True)
diff --git a/addons/event_sale/views/event_views.xml b/addons/event_sale/views/event_views.xml
index 5d846504792..1f8b4037d35 100644
--- a/addons/event_sale/views/event_views.xml
+++ b/addons/event_sale/views/event_views.xml
@@ -10,6 +10,7 @@
                 <field name="currency_id" invisible="1"/>
                 <button name="action_view_linked_orders"
                         type="object" class="oe_stat_button" icon="fa-dollar"
+                        groups="sales_team.group_sale_salesman"
                         help="Total sales for this event"
                         attrs="{'invisible': ['|', ('sale_price_subtotal', '=', 0), ('sale_price_subtotal', '=', False)]}">
                     <div class="o_field_widget o_stat_info">
diff --git a/addons/mass_mailing_event/views/event_views.xml b/addons/mass_mailing_event/views/event_views.xml
index 0a24375fe1f..15127418832 100644
--- a/addons/mass_mailing_event/views/event_views.xml
+++ b/addons/mass_mailing_event/views/event_views.xml
@@ -9,10 +9,16 @@
             <xpath expr="//field[@name='stage_id']" position="before">
                 <field name="event_registrations_open" invisible="1"/>
                 <button name="action_invite_contacts" type="object" string="Invite"
-                        class="btn btn-primary" attrs="{'invisible': [('event_registrations_open', '=', False)]}"/>
+                    class="btn btn-primary"
+                    groups="mass_mailing.group_mass_mailing_user"
+                    attrs="{'invisible': [('event_registrations_open', '=', False)]}"/>
                 <button name="action_invite_contacts" type="object" string="Invite"
-                        class="btn btn-secondary" attrs="{'invisible': [('event_registrations_open', '=', True)]}"/>
-                <button name="action_mass_mailing_attendees" string="Contact Attendees" type="object" attrs="{'invisible': [('seats_expected', '=', 0)]}"/>
+                    class="btn btn-secondary"
+                    groups="mass_mailing.group_mass_mailing_user"
+                    attrs="{'invisible': [('event_registrations_open', '=', True)]}"/>
+                <button name="action_mass_mailing_attendees" type="object" string="Contact Attendees"
+                    groups="mass_mailing.group_mass_mailing_user"
+                    attrs="{'invisible': [('seats_expected', '=', 0)]}"/>
             </xpath>
         </field>
     </record>