From 3de5fce87c9c539fa97d29f199a7575432117c6a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lucas=20Lef=C3=A8vre?= <lul@odoo.com>
Date: Tue, 4 Jun 2019 07:54:54 +0000
Subject: [PATCH] [IMP] hr_recruitment: Improve usability

Purpose
========

Modernize recruitment app, clean of menu, remove resume and letters feature
to integrate it with documents.

Specification
=============

1) Menus

- Applications
-> By Job Positions (current job position menu
-> All Applications
- Reporting
-> Recruitment Analysis
- Configuration
-> ... does not change

2) Remove resumes and letters menus

3) Add a quick search on `hr.job` to "My Jobs Positions" based
on recruitment responsible = user.

Task id: 1965870

closes odoo/odoo#33862

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
---
 addons/hr_recruitment/views/hr_job_views.xml  | 14 ++++++++--
 .../views/hr_recruitment_views.xml            | 26 +++----------------
 2 files changed, 16 insertions(+), 24 deletions(-)

diff --git a/addons/hr_recruitment/views/hr_job_views.xml b/addons/hr_recruitment/views/hr_job_views.xml
index d4667221c4b..00e281816e2 100644
--- a/addons/hr_recruitment/views/hr_job_views.xml
+++ b/addons/hr_recruitment/views/hr_job_views.xml
@@ -82,6 +82,17 @@
         </field>
     </record>
 
+    <record id="hr_job_search_view" model="ir.ui.view">
+        <field name="name">hr.job.search</field>
+        <field name="model">hr.job</field>
+        <field name="inherit_id" ref="hr.view_job_filter" />
+        <field name="arch" type="xml">
+            <xpath expr="//field[@name='name']" position="after">
+                <filter string="My Job Positions" name="my_positions" domain="[('user_id', '=', uid)]"/>
+            </xpath>
+        </field>
+    </record>
+
     <!-- hr related job position menu action -->
     <record model="ir.actions.act_window" id="action_hr_job">
         <field name="name">Job Positions</field>
@@ -97,6 +108,5 @@
           </p>
         </field>
     </record>
-
-    <menuitem parent="menu_hr_recruitment_root" id="menu_hr_job_position" action="action_hr_job" sequence="1"/>
+    <menuitem name="By Job Positions" parent="menu_crm_case_categ0_act_job" id="menu_hr_job_position" action="action_hr_job" sequence="1"/>
 </odoo>
diff --git a/addons/hr_recruitment/views/hr_recruitment_views.xml b/addons/hr_recruitment/views/hr_recruitment_views.xml
index 4738c74f842..c9a4817b1c3 100644
--- a/addons/hr_recruitment/views/hr_recruitment_views.xml
+++ b/addons/hr_recruitment/views/hr_recruitment_views.xml
@@ -646,26 +646,6 @@
             </xpath>
         </field>
     </record>
-    <record model="ir.actions.act_window" id="hr_applicant_resumes">
-        <field name="name">Resumes and Letters</field>
-        <field name="res_model">ir.attachment</field>
-        <field name="view_mode">kanban,tree,form</field>
-        <field name="view_id" ref="mail.view_document_file_kanban"/>
-        <field name="search_view_id" ref="ir_attachment_view_search_inherit_hr_recruitment"/>
-        <field name="domain">[('res_model','=','hr.applicant')]</field>
-        <field name="context">{'create': False}</field>
-        <field name="help" type="html">
-            <p class="o_view_nocontent_empty_folder">
-                No document yet
-            </p><p>
-                This menu helps you search through resumes and motivation
-                letters. Odoo automatically indexes .PDF, .DOC, DOCX, .TXT
-                files so that you can search keywords from the content of these
-                files.
-            </p>
-        </field>
-    </record>
-    <menuitem name="Resumes and Letters" parent="hr_recruitment.menu_hr_recruitment_root" id="menu_crm_case_categ0_act_job02" action="hr_applicant_resumes" sequence="3"/>
 
     <!-- Stage Tree View -->
     <record model="ir.ui.view" id="hr_recruitment_stage_tree">
@@ -971,8 +951,10 @@
             (0, 0, {'view_mode': 'graph', 'view_id': ref('hr_applicant_view_graph')})]"/>
         <field name="context">{}</field>  <!-- force empty -->
     </record>
-    <menuitem name="Reports" id="report_hr_recruitment" parent="menu_hr_recruitment_root"
-    sequence="99" action="hr_applicant_action_analysis"/>
+    <menuitem name="Reporting" id="report_hr_recruitment" parent="menu_hr_recruitment_root"
+    sequence="99"/>
+    <menuitem name="Recruitment Analysis" id="hr_applicant_report_menu" parent="report_hr_recruitment"
+    sequence="50" action="hr_applicant_action_analysis"/>
     <record id="action_hr_recruitment_report_filtered_department" model="ir.actions.act_window">
         <field name="name">Recruitment Analysis</field>
         <field name="res_model">hr.applicant</field>