From 3dd031bab03f6a5aeb111cc1532e8877a1b3d17c Mon Sep 17 00:00:00 2001 From: stcc-odoo Date: Thu, 25 May 2023 14:00:37 +0000 Subject: [PATCH] [FIX] base, website: prevent assetsbundle commit in savepoint Steps to reproduce: - Install industry_fsm_report, website - Create Project P, add column/stage PC. - Edit stage, Email Template = Task: Intervention Schduled. - Edit the template > Advanced Settings > Optional report to print and attach = Worksheet Report (PDF). Save everything. - Go to website, "contact us" page > Edit the form, Action = Create a task, Project = P > Save Issue: When you first submit the form, it will fail, but the task will be created and visible in project P. By instinct, the user will submit the form again, so the task will be duplicated. The second form submit will return a success message. When submitting a form, we first generate a savepoint (added in commit [1]). Since this is the first interaction with the report system, during the handling of the form, the assetsbundle will be generated (see keyword 'commit_assetsbundle'), which will cause a commit. Finally, assuming no other error is raised, we try to delete the savepoint. However, since a commit was executed, then the savepoint will no longer exist, which will cause an error status to be returned. Solution: When submitting a form, pass `commit_assetsbundle=False` to the record creation, which prevents the commit from happening. This solution has a downside; creating the record also sends an email and the report attached to that email will have broken styling. This is still an improvement to the current behaviour, which doesn't send the first email at all. [1]: https://github.com/odoo-dev/odoo/commit/5a499ecf113f08c11d2b33b47680dd00ec1b297b opw-3183912 closes odoo/odoo#123198 X-original-commit: 26031c452a7d92f35270cb04a4f37b26ff6bcc99 Signed-off-by: Romain Derie (rde) Signed-off-by: Stefan-Calin Crainiciuc (stcc) --- addons/website/controllers/form.py | 5 ++++- odoo/addons/base/models/ir_actions_report.py | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/addons/website/controllers/form.py b/addons/website/controllers/form.py index d08f19bd1ff..acdaf41d02d 100644 --- a/addons/website/controllers/form.py +++ b/addons/website/controllers/form.py @@ -217,7 +217,10 @@ class WebsiteForm(http.Controller): model_name = model.sudo().model if model_name == 'mail.mail': values.update({'reply_to': values.get('email_from')}) - record = request.env[model_name].with_user(SUPERUSER_ID).with_context(mail_create_nosubscribe=True).create(values) + record = request.env[model_name].with_user(SUPERUSER_ID).with_context( + mail_create_nosubscribe=True, + commit_assetsbundle=False, + ).create(values) if custom or meta: _custom_label = "%s\n___________\n\n" % _("Other Information:") # Title for custom fields diff --git a/odoo/addons/base/models/ir_actions_report.py b/odoo/addons/base/models/ir_actions_report.py index 28522eac152..b656cd0090f 100644 --- a/odoo/addons/base/models/ir_actions_report.py +++ b/odoo/addons/base/models/ir_actions_report.py @@ -687,7 +687,7 @@ class IrActionsReport(models.Model): # This scenario happens when you want to print a PDF report for the first time, as the # assets are not in cache and must be generated. To workaround this issue, we manually # commit the writes in the `ir.attachment` table. It is done thanks to a key in the context. - if not config['test_enable']: + if not config['test_enable'] and 'commit_assetsbundle' not in self.env.context: additional_context['commit_assetsbundle'] = True html = self.with_context(**additional_context)._render_qweb_html(report_ref, res_ids_wo_stream, data=data)[0]