From 3cb95d222769097fcd42e7c64b18d9f00c53bd7e Mon Sep 17 00:00:00 2001
From: "Darshan Kalola (OpenERP)" <dka@tinyerp.com>
Date: Fri, 11 Oct 2013 16:36:41 +0530
Subject: [PATCH] [IMP] add menu Product Template and improve the form view of
 product template.

bzr revid: dka@tinyerp.com-20131011110641-q3dcnsfqihbjnfs1
---
 addons/account/product_view.xml             |  16 +--
 addons/account_anglo_saxon/product_view.xml |   2 +-
 addons/procurement/procurement_view.xml     |  25 ++++-
 addons/product/product_view.xml             | 107 ++++++++++----------
 addons/purchase/purchase_view.xml           |   5 +-
 addons/stock/product_view.xml               |  43 ++++----
 6 files changed, 116 insertions(+), 82 deletions(-)

diff --git a/addons/account/product_view.xml b/addons/account/product_view.xml
index 2c540cb6ee6..d5fb3fe3911 100644
--- a/addons/account/product_view.xml
+++ b/addons/account/product_view.xml
@@ -31,12 +31,16 @@
             <field name="arch" type="xml">
                 <notebook position="inside">
                     <page string="Accounting">
-                        <separator string="Sales Properties" colspan="2"/>
-                        <separator string="Purchase Properties" colspan="2"/>
-                        <field name="property_account_income" domain="[('type','&lt;&gt;','view'),('type','&lt;&gt;','consolidation')]"/>
-                        <field name="property_account_expense" domain="[('type','&lt;&gt;','view'),('type','&lt;&gt;','consolidation')]"/>
-                        <field name="taxes_id"/>
-                        <field name="supplier_taxes_id"/>
+                        <group name="properties">
+                            <group>
+                                <field name="property_account_income" domain="[('type','&lt;&gt;','view'),('type','&lt;&gt;','consolidation')]"/>
+                                <field name="taxes_id" colspan="2" widget="many2many_tags"/>
+                            </group>
+                            <group>
+                                <field name="property_account_expense" domain="[('type','&lt;&gt;','view'),('type','&lt;&gt;','consolidation')]"/>
+                                <field name="supplier_taxes_id" colspan="2" widget="many2many_tags"/>
+                            </group>
+                        </group>
                     </page>
                 </notebook>
              </field>
diff --git a/addons/account_anglo_saxon/product_view.xml b/addons/account_anglo_saxon/product_view.xml
index 43029616c5b..b4b16675b8a 100644
--- a/addons/account_anglo_saxon/product_view.xml
+++ b/addons/account_anglo_saxon/product_view.xml
@@ -19,7 +19,7 @@
             <field name="model">product.template</field>
             <field name="inherit_id" ref="account.product_template_form_view"/>
             <field name="arch" type="xml">
-                <xpath expr="/form/notebook/page/field[@name='property_account_expense']" position="after">
+                <xpath expr="//field[@name='property_account_expense']" position="after">
                     <field name="property_account_creditor_price_difference" domain="[('type','&lt;&gt;','view'),('type','&lt;&gt;','consolidation')]" attrs="{'readonly':[('purchase_ok','=',0)]}" />
                     <newline/>
                 </xpath>
diff --git a/addons/procurement/procurement_view.xml b/addons/procurement/procurement_view.xml
index 4cb070bd92f..1b8e6b62d93 100644
--- a/addons/procurement/procurement_view.xml
+++ b/addons/procurement/procurement_view.xml
@@ -296,10 +296,33 @@
             <field name="model">product.template</field>
             <field name="inherit_id" ref="product.product_template_form_view"/>
             <field name="arch" type="xml">
-                <xpath expr="//field[@name='type']" position="after">
+                <xpath expr="//field[@name='cost_method']" position="before">
                     <field name="procure_method"/>
                     <field name="supply_method"/>
                 </xpath>
+                <xpath expr="//group[@name='general']" position="after" >
+                    <group name="procurement_help" class="oe_grey" col="1" groups="base.group_user">
+                        <p attrs="{'invisible': ['|','|',('type','&lt;&gt;','service'),('procure_method','&lt;&gt;','make_to_stock')]}">
+                            When you sell this service, nothing special will be triggered
+                            to deliver the customer, as you set the procurement method as
+                            'Make to Stock'.
+                        </p>
+                        <p attrs="{'invisible': ['|','|',('type','&lt;&gt;','product'),('procure_method','&lt;&gt;','make_to_stock')]}">
+                            When you sell this product, OpenERP will <b>use the available
+                            inventory</b> for the delivery order.
+                            <br/><br/>
+                            If there are not enough quantities available, the delivery order
+                            will wait for new products. To fulfill the inventory, you should
+                            create others rules like orderpoints.
+                        </p>
+                        <p attrs="{'invisible': ['|','|',('type','&lt;&gt;','consu'),('procure_method','&lt;&gt;','make_to_stock')]}">
+                            When you sell this product, a delivery order will be created.
+                            OpenERP will consider that the <b>required quantities are always
+                            available</b> as it's a consumable (as a result of this, the quantity
+                            on hand may become negative).
+                        </p>
+                    </group>
+                </xpath>
             </field>
         </record>
 
diff --git a/addons/product/product_view.xml b/addons/product/product_view.xml
index 2d57ddedb00..bda96dba48e 100644
--- a/addons/product/product_view.xml
+++ b/addons/product/product_view.xml
@@ -673,7 +673,7 @@
             <field name="view_id" ref="product_variant_form_view"/>
             <field name="act_window_id" ref="product_variant_action"/>
         </record>
-        <menuitem action="product.product_variant_action" id="product.menu_variant_product" parent="base.menu_product" sequence="100" groups="product.group_product_variant"/>
+        <menuitem action="product.product_variant_action" id="product.menu_variant_product" parent="prod_config_main" sequence="100" groups="product.group_product_variant"/>
 
         <!-- templates -->
         <record id="product_template_tree_view" model="ir.ui.view">
@@ -705,46 +705,18 @@
                             </h1>
                             <label for="categ_id" class="oe_edit_only"/>
                             <h2><field name="categ_id"/></h2>
+                            <div name="options" groups="base.group_user">
+                                <field name="sale_ok"/>
+                                <label for="sale_ok"/>
+                            </div>
                         </div>
                         <notebook>
                             <page string="Information">
-                            <group>
-                                <group string="Product Type">
-                                    <field name="sale_ok"/>
-                                </group>
-                                <group string="Procurement">
-                                    <field name="type"/>
-                                </group>
-
-                                <group string="Base Prices">
+                                <group>
+                                    <field name="type" class="oe_inline"/>
+                                    <field name="uom_id" class="oe_inline" on_change="onchange_uom(uom_id,uom_po_id)" groups="product.group_uom"/>
                                     <field name="list_price"/>
-                                    <field name="standard_price" attrs="{'readonly':[('cost_method','=','average')]}"/>
-                                    <field name="cost_method"/>
                                 </group>
-
-                                <group string="Weights">
-                                    <field digits="(14, 3)" name="volume" attrs="{'readonly':[('type','=','service')]}"/>
-                                    <field digits="(14, 3)" name="weight" attrs="{'readonly':[('type','=','service')]}"/>
-                                    <field digits="(14, 3)" name="weight_net" attrs="{'readonly':[('type','=','service')]}"/>
-                                </group> 
-
-                                <group name="status" string="Status">
-                                    <field name="categ_id"/>
-                                    <field name="state"/>
-                                    <field name="product_manager" context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'base.group_sale_manager']}"/>
-                                </group>
-
-                                <group name="uom" string="Unit of Measure">
-                                    <field name="uom_id" on_change="onchange_uom(uom_id,uom_po_id)" groups="product.group_uom"/>
-                                    <field name="uom_po_id"/>
-                                </group>
-
-                                <group name="uos" groups="product.group_uom" string="Second Unit of Measure">
-                                    <field name="uos_id"/>
-                                    <field name="uos_coeff"/>
-                                    <field name="mes_type"/>
-                                </group>
-
                                 <group colspan="4" string="Product Variants">
                                     <field colspan="4" name="product_variant_ids" nolabel="1">
                                         <tree string="Product Variants" editable="bottom">
@@ -756,30 +728,58 @@
                                         </tree>
                                     </field>
                                 </group>
-                            </group>
+                                <field name="description" placeholder="describe the product characteristics..."/>
                             </page>
-                            <page string="Procurement &amp; Locations">
-                                <group>
+                            <page string="Procurements" groups="base.group_user">
+                                <group name="procurement">
+                                    <group name="general">
+                                        <field name="cost_method" groups="product.group_costing_method"/>
+                                        <field name="standard_price" attrs="{'readonly':[('cost_method','=','average')]}"/>
+                                    </group>
                                     <group name="delay" string="Delays">
                                         <label for="produce_delay"/>
                                         <div>
-                                            <field name="produce_delay" class="oe_inline"/> days
+                                            <field name="produce_delay" class="oe_inline" style="vertical-align:baseline"/> days
                                         </div>
-                                        <field name="warranty"/>
+                                    </group>
+                                    <group name="procurement_uom" groups="product.group_uom" string="Purchase">
+                                        <field name="uom_po_id"/>
                                     </group>
                                 </group>
-
-                            </page>
-                            <page string="Suppliers">
+                                <separator string="Suppliers"/>
                                 <field name="seller_ids"/>
+                                <separator string="Description for Suppliers"/>
+                                <field name="description_purchase" placeholder="This note will be displayed on requests for quotation..."/>
                             </page>
-                            <page string="Descriptions">
-                                <separator string="Internal Description"/>
-                                <field name="description"/>
-                                <separator string="Sale Description"/>
-                                <field name="description_sale"/>
-                                <separator string="Purchase Description"/>
-                                <field name="description_purchase"/>
+                            <page string="Inventory">
+                                <group name="inventory">
+                                     <group name="status" string="Status">
+                                        <field name="state"/>
+                                        <field name="product_manager"/>
+                                    </group>
+                                    <group string="Weights" groups="product.group_stock_packaging">
+                                        <field digits="(14, 3)" name="volume" attrs="{'readonly':[('type','=','service')]}"/>
+                                        <field digits="(14, 3)" name="weight" attrs="{'readonly':[('type','=','service')]}"/>
+                                        <field digits="(14, 3)" name="weight_net" attrs="{'readonly':[('type','=','service')]}"/>
+                                    </group>
+                                </group>
+                            </page>
+                            <page string="Sales" attrs="{'invisible':[('sale_ok','=',False)]}">   
+                                <group name="sale">
+                                    <group string="Sale Conditions">
+                                        <label for="warranty"/>
+                                        <div>
+                                            <field name="warranty" class="oe_inline" style="vertical-align:baseline"/> months
+                                        </div>
+                                    </group>
+                                    <group groups="product.group_uos" string="Unit of Measure">
+                                        <field name="uos_id"/>
+                                        <field name="uos_coeff"/>
+                                        <field name="mes_type"/>
+                                    </group>
+                                </group>
+                                <separator string="Description for Quotations"/>
+                                <field name="description_sale" placeholder="note to be displayed on quotations..."/>
                             </page>
                         </notebook>
                     </sheet>
@@ -795,5 +795,10 @@
             <field name="view_id" ref="product_template_tree_view"/>
         </record>
 
+        <menuitem action="product_template_action_tree"
+            groups="product.group_product_variant"
+            id="menu_product_template_action"
+            parent="prod_config_main" sequence="3"/>
+
     </data>
 </openerp>
diff --git a/addons/purchase/purchase_view.xml b/addons/purchase/purchase_view.xml
index 6bed8bcbf9c..6084aa5f09b 100644
--- a/addons/purchase/purchase_view.xml
+++ b/addons/purchase/purchase_view.xml
@@ -599,9 +599,10 @@
             <field name="model">product.template</field>
             <field name="inherit_id" ref="product.product_template_form_view"/>
             <field name="arch" type="xml">
-                <field name="sale_ok" position="after">
+                <div name="options" position="inside">
                     <field name="purchase_ok"/>
-                </field>
+                    <label for="purchase_ok"/>
+                </div>
             </field>
         </record>
         <record model="ir.actions.act_window" id="action_purchase_line_product_tree">
diff --git a/addons/stock/product_view.xml b/addons/stock/product_view.xml
index 16b25c6dbda..b8bd3039fcd 100644
--- a/addons/stock/product_view.xml
+++ b/addons/stock/product_view.xml
@@ -37,29 +37,30 @@
             <field name="model">product.template</field>
             <field name="inherit_id" ref="product.product_template_form_view"/>
             <field name="arch" type="xml">
-            	<group name="delay" position="inside">
-            		<field name="sale_delay" attrs="{'readonly':[('sale_ok','=',False)]}"/>
-            	</group>
-            	<group name="delay" position="after">
-            		<group name="store" string="Storage Location">
+                <xpath expr="//group[@string='Sale Conditions']" position="inside">
+                    <label for="sale_delay"/>
+                    <div>
+                        <field name="sale_delay" attrs="{'readonly':[('sale_ok','=',False)]}" class="oe_inline" style="vertical-align:baseline"/> days
+                    </div>
+                </xpath>
+                <xpath expr="//group[@name='status']" position="after">
+                    <group name="store" string="Storage Location">
                         <field name="loc_rack"/>
                         <field name="loc_row"/>
-                    	<field name="loc_case"/>
-                	</group>
-                </group>
-                <page position="after" string="Information">
-                    <page string="Properties">
-                        <group string="Counter-Part Locations Properties" groups="stock.group_locations">
-                            <field name="property_stock_procurement" domain="[('usage','=','procurement')]"/>
-                            <field name="property_stock_production" domain="[('usage','=','production')]"/>
-                            <field name="property_stock_inventory" domain="[('usage','=','inventory')]"/>
-                        </group>
-                        <group string="Accounting Entries">
-                            <field name="property_stock_account_input" domain="[('type','&lt;&gt;','view'),('type','&lt;&gt;','consolidation')]"/>
-                            <field name="property_stock_account_output" domain="[('type','&lt;&gt;','view'),('type','&lt;&gt;','consolidation')]"/>
-                        </group>
-                    </page>
-                </page>
+                        <field name="loc_case"/>
+                    </group>
+                </xpath>
+                <xpath expr="//group[@string='Weights']" position="after">
+                    <group string="Accounting Entries">
+                        <field name="property_stock_account_input" domain="[('type','&lt;&gt;','view'),('type','&lt;&gt;','consolidation')]"/>
+                        <field name="property_stock_account_output" domain="[('type','&lt;&gt;','view'),('type','&lt;&gt;','consolidation')]"/>
+                    </group>
+                    <group string="Counter-Part Locations Properties" groups="stock.group_locations">
+                        <field name="property_stock_procurement" domain="[('usage','=','procurement')]"/>
+                        <field name="property_stock_production" domain="[('usage','=','production')]"/>
+                        <field name="property_stock_inventory" domain="[('usage','=','inventory')]"/>
+                    </group>
+                </xpath>
                 <field name="product_manager" position="attributes" version="7.0">
                     <attribute name="context">{'default_groups_ref': ['base.group_user', 'base.group_sale_manager', 'stock.group_stock_manager']}</attribute>
                 </field>