From 3c8b57dc53f8e06c8985963d72eaffe5ded17039 Mon Sep 17 00:00:00 2001
From: Goffin Simon <sig@odoo.com>
Date: Thu, 29 Nov 2018 09:56:43 +0000
Subject: [PATCH] [FIX] sale_stock, stock: Wrong dependency

The field sale_id on model stock.picking is not defined in stock module.
So the rule was wrong when sale_stock was uninstalled.

opw:1912564

closes odoo/odoo#29145
---
 addons/sale_stock/security/sale_stock_security.xml | 8 ++++++++
 addons/stock/security/stock_security.xml           | 8 --------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/addons/sale_stock/security/sale_stock_security.xml b/addons/sale_stock/security/sale_stock_security.xml
index 630a6512b2d..c53b98a341d 100644
--- a/addons/sale_stock/security/sale_stock_security.xml
+++ b/addons/sale_stock/security/sale_stock_security.xml
@@ -10,5 +10,13 @@
             <field name="name">Display incoterms on Sales Order and related invoices</field>
             <field name="category_id" ref="base.module_category_hidden"/>
         </record>
+
+        <!-- Stock Portal Access Rules -->
+        <record id="stock_picking_rule_portal" model="ir.rule">
+            <field name="name">Portal Follower Pickings</field>
+            <field name="model_id" ref="stock.model_stock_picking"/>
+            <field name="domain_force">['|', '|', ('message_partner_ids', 'in', [user.partner_id.id]), ('partner_id', '=', user.partner_id.id), ('sale_id.partner_id', '=', user.partner_id.id)]</field>
+            <field name="groups" eval="[(4, ref('base.group_portal'))]"/>
+        </record>
     </data>
 </odoo>
diff --git a/addons/stock/security/stock_security.xml b/addons/stock/security/stock_security.xml
index 3301a5fbb8c..5a61d942114 100644
--- a/addons/stock/security/stock_security.xml
+++ b/addons/stock/security/stock_security.xml
@@ -134,14 +134,6 @@
         <field name="domain_force">['|',('company_id','=',False),('company_id','child_of',[user.company_id.id])]</field>
     </record>
 
-    <!-- Stock Portal Access Rules -->
-    <record id="stock_picking_rule_portal" model="ir.rule">
-        <field name="name">Portal Follower Pickings</field>
-        <field name="model_id" ref="stock.model_stock_picking"/>
-        <field name="domain_force">['|', '|', ('message_partner_ids', 'in', [user.partner_id.id]), ('partner_id.id', '=', user.partner_id.id), ('sale_id.partner_id.id', '=', user.partner_id.id)]</field>
-        <field name="groups" eval="[(4, ref('base.group_portal'))]"/>
-    </record>
-
     <record model="ir.rule" id="stock_location_route_comp_rule">
         <field name="name">stock_location_route multi-company</field>
         <field name="model_id" ref="model_stock_location_route"/>