From 3be272361eace448b45e74718da3fe49524571da Mon Sep 17 00:00:00 2001
From: Romeo Fragomeli <rfr@odoo.com>
Date: Thu, 11 Mar 2021 11:47:30 +0000
Subject: [PATCH] [IMP] account,sale: show product image in kanban SO
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Before this commit, in the kanban view of sale order lines, the
product's image was not visible.

This commit adds the image to be more consistent with the kanban view in
accounting.

Note: we have also tweaked the view in accounting for better clarity.

Task ID : 2200168 (6.b)

closes odoo/odoo#67691

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
---
 addons/account/views/account_move_views.xml | 32 +++++------
 addons/sale/views/sale_views.xml            | 61 +++++++++------------
 2 files changed, 42 insertions(+), 51 deletions(-)

diff --git a/addons/account/views/account_move_views.xml b/addons/account/views/account_move_views.xml
index abb62cd5e4e..524f58389d8 100644
--- a/addons/account/views/account_move_views.xml
+++ b/addons/account/views/account_move_views.xml
@@ -862,18 +862,24 @@
                                         <field name="price_unit"/>
                                         <templates>
                                             <t t-name="kanban-box">
-                                                <div t-attf-class="oe_kanban_card oe_kanban_global_click {{ record.display_type.raw_value ? 'o_is_' + record.display_type.raw_value : '' }}">
+                                                <div t-attf-class="oe_kanban_card oe_kanban_global_click pl-0 pr-0 {{ record.display_type.raw_value ? 'o_is_' + record.display_type.raw_value : '' }}">
                                                     <t t-if="!record.display_type.raw_value">
-                                                        <div class="row">
-                                                            <div class="col-2">
+                                                        <div class="row no-gutters">
+                                                            <div class="col-2 pr-3">
                                                                 <img t-att-src="kanban_image('product.product', 'image_128', record.product_id.raw_value)" t-att-title="record.product_id.value" t-att-alt="record.product_id.value" style="max-width: 100%;"/>
                                                             </div>
                                                             <div class="col-10">
-                                                                <strong>
-                                                                    <span>
-                                                                        <t t-esc="record.product_id.value"/>
-                                                                    </span>
-                                                                </strong>
+                                                                <div class="row">
+                                                                    <div class="col">
+                                                                        <strong t-esc="record.product_id.value"/>
+                                                                    </div>
+                                                                    <div class="col-auto">
+                                                                        <strong class="float-right text-right">
+                                                                            <t t-esc="record.price_subtotal.value" groups="account.group_show_line_subtotals_tax_excluded"/>
+                                                                            <t t-esc="record.price_total.value" groups="account.group_show_line_subtotals_tax_included"/>
+                                                                        </strong>
+                                                                    </div>
+                                                                </div>
                                                                 <div class="text-muted">
                                                                     Quantity:
                                                                     <t t-esc="record.quantity.value"/>
@@ -883,21 +889,13 @@
                                                                     Unit Price:
                                                                     <t t-esc="record.price_unit.value"/>
                                                                 </div>
-                                                                <strong>
-                                                                    <span class="float-right text-right">
-                                                                        <t t-esc="record.price_subtotal.value" groups="account.group_show_line_subtotals_tax_excluded"/>
-                                                                        <t t-esc="record.price_total.value" groups="account.group_show_line_subtotals_tax_included"/>
-                                                                    </span>
-                                                                </strong>
                                                             </div>
                                                         </div>
                                                     </t>
                                                     <t t-if="record.display_type.raw_value === 'line_section' || record.display_type.raw_value === 'line_note'">
                                                         <div class="row">
                                                             <div class="col-12">
-                                                                <span>
-                                                                    <t t-esc="record.name.value"/>
-                                                                </span>
+                                                                <t t-esc="record.name.value"/>
                                                             </div>
                                                         </div>
                                                     </t>
diff --git a/addons/sale/views/sale_views.xml b/addons/sale/views/sale_views.xml
index 5df852f8124..cb705ab6025 100644
--- a/addons/sale/views/sale_views.xml
+++ b/addons/sale/views/sale_views.xml
@@ -590,48 +590,41 @@
                                     <field name="company_id" invisible="1"/>
                                     <templates>
                                         <t t-name="kanban-box">
-                                            <div t-attf-class="oe_kanban_card oe_kanban_global_click {{ record.display_type.raw_value ? 'o_is_' + record.display_type.raw_value : '' }}">
+                                            <div t-attf-class="oe_kanban_card oe_kanban_global_click pl-0 pr-0 {{ record.display_type.raw_value ? 'o_is_' + record.display_type.raw_value : '' }}">
                                                 <t t-if="!record.display_type.raw_value">
-                                                    <div class="row">
-                                                        <div class="col-8">
-                                                            <strong>
-                                                                <span>
-                                                                    <t t-esc="record.product_id.value"/>
-                                                                </span>
-                                                            </strong>
+                                                    <div class="row no-gutters">
+                                                        <div class="col-2 pr-3">
+                                                            <img t-att-src="kanban_image('product.product', 'image_128', record.product_id.raw_value)" t-att-title="record.product_id.value" t-att-alt="record.product_id.value" style="max-width: 100%;"/>
                                                         </div>
-                                                        <div class="col-4">
-                                                            <strong>
-                                                                <span class="float-right text-right">
-                                                                    <t t-esc="record.price_subtotal.value"/>
-                                                                </span>
-                                                            </strong>
-                                                        </div>
-                                                    </div>
-                                                    <div class="row">
-                                                        <div class="col-12 text-muted">
-                                                            <span>
-                                                                Quantity:
-                                                                <t t-esc="record.product_uom_qty.value"/>
-                                                                <t t-esc="record.product_uom.value"/>
-                                                            </span>
-                                                        </div>
-                                                    </div>
-                                                    <div class="row">
-                                                        <div class="col-12 text-muted">
-                                                            <span>
-                                                                Unit Price:
-                                                                <t t-esc="record.price_unit.value"/>
-                                                            </span>
+                                                        <div class="col-10">
+                                                            <div class="row">
+                                                                <div class="col">
+                                                                    <strong t-esc="record.product_id.value" />
+                                                                </div>
+                                                                <div class="col-auto">
+                                                                    <strong class="float-right text-right" t-esc="record.price_subtotal.value" />
+                                                                </div>
+                                                            </div>
+                                                            <div class="row">
+                                                                <div class="col-12 text-muted">
+                                                                    Quantity:
+                                                                    <t t-esc="record.product_uom_qty.value"/>
+                                                                    <t t-esc="record.product_uom.value"/>
+                                                                </div>
+                                                            </div>
+                                                            <div class="row">
+                                                                <div class="col-12 text-muted">
+                                                                    Unit Price:
+                                                                    <t t-esc="record.price_unit.value"/>
+                                                                </div>
+                                                            </div>
                                                         </div>
                                                     </div>
                                                 </t>
                                                 <t t-if="record.display_type.raw_value === 'line_section' || record.display_type.raw_value === 'line_note'">
                                                     <div class="row">
                                                         <div class="col-12">
-                                                            <span>
-                                                                <t t-esc="record.name.value"/>
-                                                            </span>
+                                                            <t t-esc="record.name.value"/>
                                                         </div>
                                                     </div>
                                                 </t>