From 3baa772b289d2db56f8cf800f9b3a898e42e8abd Mon Sep 17 00:00:00 2001 From: Jeremy Kersten Date: Thu, 19 Jan 2023 15:39:49 +0000 Subject: [PATCH] [FIX] sale: don't assign non-salesperson as salesperson on sales order Before this commit, if you create a sale order for partner who is not is not a salesman on the res.partner, you become the salesman of the sale.order. No matter if you are salesman or even employee. After this commit, the customer or public user will be not assigned as a salesman on sale.order when creating without forcing the user_id = False. closes odoo/odoo#110486 X-original-commit: 008cd34c49574f1b0c50132a75b50111422e431a Signed-off-by: Victor Feyens (vfe) --- addons/sale/models/sale_order.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/addons/sale/models/sale_order.py b/addons/sale/models/sale_order.py index 2c1860216d3..f1845eb7b77 100644 --- a/addons/sale/models/sale_order.py +++ b/addons/sale/models/sale_order.py @@ -421,7 +421,8 @@ class SaleOrder(models.Model): def _compute_user_id(self): for order in self: if not order.user_id: - order.user_id = order.partner_id.user_id or order.partner_id.commercial_partner_id.user_id or self.env.user + order.user_id = order.partner_id.user_id or order.partner_id.commercial_partner_id.user_id or \ + (self.user_has_groups('sales_team.group_sale_salesman') and self.env.user) @api.depends('partner_id', 'user_id') def _compute_team_id(self):