From 3b9511285a0a501f8a156d3835e8af8054bc484e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9my=20Voet=20=28ryv=29?= <ryv@odoo.com>
Date: Wed, 4 Aug 2021 07:52:07 +0000
Subject: [PATCH] [FIX] purchase_stock: avoid unaccess Error

The receipt count smart button is on the PO form even if the user is
not able to see the delivery.

Add `stock.group_stock_user` on the button
(Also remove the useless picking_ids fieds of the form).

task-2486811

Part-of: odoo/odoo#75041
---
 addons/purchase_stock/views/purchase_views.xml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/addons/purchase_stock/views/purchase_views.xml b/addons/purchase_stock/views/purchase_views.xml
index be0d86a0121..22a94b4e4f6 100644
--- a/addons/purchase_stock/views/purchase_views.xml
+++ b/addons/purchase_stock/views/purchase_views.xml
@@ -7,7 +7,10 @@
         <field name="inherit_id" ref="purchase.purchase_order_form"/>
         <field name="arch" type="xml">
             <xpath expr="//header/button[@name='action_rfq_send']" position="after">
-                <button name="action_view_picking" string="Receive Products" class="oe_highlight" type="object" attrs="{'invisible': ['|', '|' , ('is_shipped', '=', True), ('state','not in', ('purchase','done')), ('picking_count', '=', 0)]}" data-hotkey="y"/>
+                <button name="action_view_picking" 
+                    string="Receive Products" class="oe_highlight" type="object" 
+                    attrs="{'invisible': ['|', '|' , ('is_shipped', '=', True), ('state','not in', ('purchase','done')), ('picking_count', '=', 0)]}" 
+                    data-hotkey="y" groups="stock.group_stock_user"/>
             </xpath>
             <xpath expr="//header/button[@name='confirm_reminder_mail']" position="attributes">
                 <attribute name="attrs">{'invisible': ['|', '|', '|', ('state', 'not in', ('purchase', 'done')), ('mail_reminder_confirmed', '=', True), ('date_planned', '=', False), ('effective_date', '!=', False)]}</attribute>
@@ -16,9 +19,8 @@
                 <button type="object"
                     name="action_view_picking"
                     class="oe_stat_button"
-                    icon="fa-truck" attrs="{'invisible':[('picking_ids','=',[])]}">
+                    icon="fa-truck" attrs="{'invisible':[('picking_count','=', 0)]}" groups="stock.group_stock_user">
                     <field name="picking_count" widget="statinfo" string="Receipt" help="Incoming Shipments"/>
-                    <field name="picking_ids" invisible="1"/>
                 </button>
             </xpath>
             <xpath expr="//field[@name='currency_id']" position="after">