From 3b3ab08c3ca497a9fa6e66c8145dd3bac3d156a4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Mottet=20=28oms=29?= <oms@odoo.com>
Date: Mon, 5 Jul 2021 12:47:57 +0000
Subject: [PATCH] [FIX] website: set id in xml for carousel rendered by
 configurator
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Carousels (carousel and quotes_carousel snippets) in pages created by the
configurator are not added through a drag'n'drop. onBuilt and _assignUniqueId
are thefore not called. We set the unique id directly in the xml to make
the carousel slides also work when these snippets are added by the configurator.

task-2518565

closes odoo/odoo#73256

X-original-commit: 36387994d0a3038c87a754d4c27a6d34b30137e3
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
---
 addons/website/views/snippets/s_carousel.xml        | 13 +++++++------
 addons/website/views/snippets/s_quotes_carousel.xml | 13 +++++++------
 2 files changed, 14 insertions(+), 12 deletions(-)

diff --git a/addons/website/views/snippets/s_carousel.xml b/addons/website/views/snippets/s_carousel.xml
index d5ceb6bdb6c..cc30313c4c8 100644
--- a/addons/website/views/snippets/s_carousel.xml
+++ b/addons/website/views/snippets/s_carousel.xml
@@ -3,12 +3,13 @@
 
 <template id="s_carousel" name="Carousel">
     <section class="s_carousel_wrapper" data-vxml="001">
-        <div id="myCarousel" class="s_carousel s_carousel_default carousel slide" data-interval="10000">
+        <t t-set="uniq" t-value="datetime.datetime.now().microsecond"/>
+        <div t-attf-id="myCarousel{{uniq}}" class="s_carousel s_carousel_default carousel slide" data-interval="10000">
             <!-- Indicators -->
             <ol class="carousel-indicators">
-                <li data-target="#myCarousel" data-slide-to="0" class="active"/>
-                <li data-target="#myCarousel" data-slide-to="1"/>
-                <li data-target="#myCarousel" data-slide-to="2"/>
+                <li t-attf-data-target="#myCarousel{{uniq}}" data-slide-to="0" class="active"/>
+                <li t-attf-data-target="#myCarousel{{uniq}}" data-slide-to="1"/>
+                <li t-attf-data-target="#myCarousel{{uniq}}" data-slide-to="2"/>
             </ol>
             <!-- Content -->
             <div class="carousel-inner">
@@ -56,11 +57,11 @@
                 </div>
             </div>
             <!-- Controls -->
-            <a class="carousel-control-prev o_not_editable" contenteditable="false" href="#myCarousel" data-slide="prev" role="img" aria-label="Previous" title="Previous">
+            <a class="carousel-control-prev o_not_editable" contenteditable="false" t-attf-href="#myCarousel{{uniq}}" data-slide="prev" role="img" aria-label="Previous" title="Previous">
                 <span class="carousel-control-prev-icon"/>
                 <span class="sr-only">Previous</span>
             </a>
-            <a class="carousel-control-next o_not_editable" contenteditable="false" href="#myCarousel" data-slide="next" role="img" aria-label="Next" title="Next">
+            <a class="carousel-control-next o_not_editable" contenteditable="false" t-attf-href="#myCarousel{{uniq}}" data-slide="next" role="img" aria-label="Next" title="Next">
                 <span class="carousel-control-next-icon"/>
                 <span class="sr-only">Next</span>
             </a>
diff --git a/addons/website/views/snippets/s_quotes_carousel.xml b/addons/website/views/snippets/s_quotes_carousel.xml
index c843e95c9eb..bc31dc20c7d 100644
--- a/addons/website/views/snippets/s_quotes_carousel.xml
+++ b/addons/website/views/snippets/s_quotes_carousel.xml
@@ -3,12 +3,13 @@
 
 <template id="s_quotes_carousel" name="Quotes">
     <section class="s_quotes_carousel_wrapper" data-vxml="001" data-vcss="001">
-        <div id="myQuoteCarousel" class="s_quotes_carousel s_carousel_default carousel slide o_cc o_cc2" data-interval="10000">
+        <t t-set="uniq" t-value="datetime.datetime.now().microsecond"/>
+        <div t-attf-id="myQuoteCarousel{{uniq}}" class="s_quotes_carousel s_carousel_default carousel slide o_cc o_cc2" data-interval="10000">
             <!-- Indicators -->
             <ol class="carousel-indicators">
-                <li data-target="#myQuoteCarousel" data-slide-to="0" class="active"/>
-                <li data-target="#myQuoteCarousel" data-slide-to="1"/>
-                <li data-target="#myQuoteCarousel" data-slide-to="2"/>
+                <li t-attf-data-target="#myQuoteCarousel{{uniq}}" data-slide-to="0" class="active"/>
+                <li t-attf-data-target="#myQuoteCarousel{{uniq}}" data-slide-to="1"/>
+                <li t-attf-data-target="#myQuoteCarousel{{uniq}}" data-slide-to="2"/>
             </ol>
             <!-- Content -->
             <div class="carousel-inner">
@@ -59,11 +60,11 @@
                 </div>
             </div>
             <!-- Controls -->
-            <div class="carousel-control-prev o_not_editable" data-target="#myQuoteCarousel" data-slide="prev" role="img" aria-label="Previous" title="Previous">
+            <div class="carousel-control-prev o_not_editable" t-attf-data-target="#myQuoteCarousel{{uniq}}" data-slide="prev" role="img" aria-label="Previous" title="Previous">
                 <span class="carousel-control-prev-icon"/>
                 <span class="sr-only">Previous</span>
             </div>
-            <div class="carousel-control-next o_not_editable" data-target="#myQuoteCarousel" data-slide="next" role="img" aria-label="Next" title="Next">
+            <div class="carousel-control-next o_not_editable" t-attf-data-target="#myQuoteCarousel{{uniq}}" data-slide="next" role="img" aria-label="Next" title="Next">
                 <span class="carousel-control-next-icon"/>
                 <span class="sr-only">Next</span>
             </div>